From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 2/3] syscalls: refactor vfork01 using new API
Date: Thu, 5 Mar 2026 16:03:24 +0100 [thread overview]
Message-ID: <aambPOCOw3eowGcp@yuki.lan> (raw)
In-Reply-To: <20260304-fork_refactoring-v2-2-016c47c90bc1@suse.com>
Hi!
> - /*
> - * Get the device number and the inode number of "." (current-
> - * working directory) for the parent process.
> - */
> - if (stat(Pcwd, &Stat_cwd_Pbuf) < 0) {
> - tst_brkm(TFAIL, cleanup, "stat(2) failed to get info. of "
> - "working directory in parent process");
> - }
> + if (p_cwd)
> + free(p_cwd);
free(NULL) is no-op, the if () is not needed.
Otherwise:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-03-05 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 15:02 [LTP] [PATCH v2 0/3] Refactor tests which are verifying fork/vfork functionalities Andrea Cervesato
2026-03-04 15:02 ` [LTP] [PATCH v2 1/3] syscalls: refactor fork09 using new API Andrea Cervesato
2026-03-05 14:09 ` Cyril Hrubis
2026-03-04 15:02 ` [LTP] [PATCH v2 2/3] syscalls: refactor vfork01 " Andrea Cervesato
2026-03-05 15:03 ` Cyril Hrubis [this message]
2026-03-04 15:02 ` [LTP] [PATCH v2 3/3] syscalls: refactor vfork02 " Andrea Cervesato
2026-03-05 15:32 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aambPOCOw3eowGcp@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.