From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Mark Cave-Ayland" <mark.caveayland@nutanix.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Zide Chen" <zide.chen@intel.com>,
"Dapeng Mi" <dapeng1.mi@linux.intel.com>,
qemu-devel@nongnu.org, devel@lists.libvirt.org
Subject: Re: [PATCH v2 14/21] hw/core/qdev-properties: allow qdev properties accept flags
Date: Fri, 6 Mar 2026 09:19:49 +0000 [thread overview]
Message-ID: <aaqcNeyNO2nmqEje@redhat.com> (raw)
In-Reply-To: <87seadjp5c.fsf@pond.sub.org>
On Fri, Mar 06, 2026 at 10:14:23AM +0100, Markus Armbruster wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > I might be totally wrong, but occasionally I've considered using
> > object_set_properties_from_qdict() internally as much more compact form
> > compared to 'object_new()/set_this_property and set that one too' noodle.
>
> Clear signal our C interface to QOM object configuration is lacking.
>
> Going through a QDict is disgusting, though. There has to be a more
> direct way. One that doesn't involve building temporary trees just so
> we can use existing visitors.
>
> What if we could pass the entire configuration as a struct? Instead of
> setting properties one by one, pass a struct literal and be done.
Or we pass things as typed variadic args.
object_new_args(TYPE_NAME,
"foo": someval,
"bar: otherval,
NULL);
we know the QAPI type for each named property, so we know how to
interpret type-correct values for each property in the var-args.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-03-06 9:20 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 3:23 [PATCH v2 00/21] qom: introduce property flags to track external user input Zhao Liu
2026-02-10 3:23 ` [PATCH v2 01/21] qom/object: use BIT macro for ObjectPropertyFlags Zhao Liu
2026-03-20 9:53 ` Thomas Huth
2026-02-10 3:23 ` [PATCH v2 02/21] qom/object: cache ObjectPropertyFlags in ObjectProperty Zhao Liu
2026-03-20 9:53 ` Thomas Huth
2026-02-10 3:23 ` [PATCH v2 03/21] qom/object: factor out object_class_property_try_add() Zhao Liu
2026-02-10 14:41 ` BALATON Zoltan
2026-02-11 7:14 ` Zhao Liu
2026-02-10 3:23 ` [PATCH v2 04/21] qom/object: add flags argument in object_{class_}property_try_add() Zhao Liu
2026-02-10 3:23 ` [PATCH v2 05/21] qom/object: rename object_{class_}property_try_add() to object_{class_}property_add_full() Zhao Liu
2026-02-10 3:23 ` [PATCH v2 06/21] qom/object: add helpers to set/get/clear property flags Zhao Liu
2026-02-10 3:23 ` [PATCH v2 07/21] qom/object: introduce user interaction flags for properties Zhao Liu
2026-02-10 9:49 ` Daniel P. Berrangé
2026-02-10 9:58 ` Daniel P. Berrangé
2026-02-11 8:19 ` Zhao Liu
2026-02-10 14:44 ` BALATON Zoltan
2026-02-11 7:22 ` Zhao Liu
2026-02-10 3:23 ` [PATCH v2 08/21] qom/object: add from_user argument in object_property_parse() Zhao Liu
2026-02-10 3:23 ` [PATCH v2 09/21] qom/object: mark global property set from CLI as USER_SET Zhao Liu
2026-02-10 3:23 ` [PATCH v2 10/21] qom/qom-hmp-cmd: mark properties set from HMP (non-JSON) "qom-set" " Zhao Liu
2026-02-10 3:23 ` [PATCH v2 11/21] qom/qom-qmp-cmd: mark properties set from QMP/HMP (JSON) " Zhao Liu
2026-02-10 3:23 ` [PATCH v2 12/21] qom/object_interfaces: mark properties set from qdict & keyval " Zhao Liu
2026-02-10 3:23 ` [PATCH v2 13/21] system/vl: mark property set in object_parse_property_opt() " Zhao Liu
2026-02-10 3:23 ` [PATCH v2 14/21] hw/core/qdev-properties: allow qdev properties accept flags Zhao Liu
2026-02-10 9:41 ` Peter Krempa
2026-02-11 7:10 ` Zhao Liu
2026-02-10 9:56 ` Daniel P. Berrangé
2026-02-11 7:30 ` Zhao Liu
2026-02-11 16:58 ` Daniel P. Berrangé
2026-02-12 15:25 ` Zhao Liu
2026-02-12 15:42 ` Daniel P. Berrangé
2026-03-09 13:34 ` Zhao Liu
2026-02-18 9:51 ` Igor Mammedov
2026-03-06 9:14 ` Markus Armbruster
2026-03-06 9:19 ` Daniel P. Berrangé [this message]
2026-03-06 9:30 ` Markus Armbruster
2026-03-09 13:52 ` Zhao Liu
2026-02-10 3:23 ` [PATCH v2 15/21] target/i386: deprecate fill-mtrr-mask property Zhao Liu
2026-02-10 3:23 ` [PATCH v2 16/21] target/i386: deprecate cpuid-0xb property Zhao Liu
2026-02-10 3:23 ` [PATCH v2 17/21] hw/intc/ioapic: deprecate version property Zhao Liu
2026-02-10 3:23 ` [PATCH v2 18/21] target/i386: mark x-consistent-cache property as internal-only Zhao Liu
2026-02-10 3:23 ` [PATCH v2 19/21] target/i386: remove redundant validation for lbr-fmt property Zhao Liu
2026-03-13 22:34 ` Chen, Zide
2026-02-10 3:23 ` [PATCH v2 20/21] target/i386: detect user provided lbr-fmt via property flag Zhao Liu
2026-03-13 22:36 ` Chen, Zide
2026-02-10 3:23 ` [PATCH v2 21/21] hw/core/qdev-properties: support valid default value for DEFINE_PROP_UINT64_CHECKMASK Zhao Liu
2026-03-13 22:36 ` Chen, Zide
2026-02-10 10:12 ` [PATCH v2 00/21] qom: introduce property flags to track external user input Daniel P. Berrangé
2026-02-10 10:44 ` Michael S. Tsirkin
2026-02-10 11:00 ` Daniel P. Berrangé
2026-02-10 15:00 ` BALATON Zoltan
2026-02-10 15:28 ` Zhao Liu
2026-02-10 15:16 ` BALATON Zoltan
2026-02-11 7:24 ` Zhao Liu
2026-02-11 11:28 ` BALATON Zoltan
2026-02-12 15:31 ` Zhao Liu
2026-02-12 15:56 ` BALATON Zoltan
2026-02-10 15:41 ` Daniel P. Berrangé
2026-02-11 7:06 ` Zhao Liu
2026-02-11 11:18 ` Daniel P. Berrangé
2026-03-11 13:05 ` Markus Armbruster
2026-03-11 13:14 ` Daniel P. Berrangé
2026-03-11 13:38 ` Peter Krempa
2026-03-16 15:43 ` Markus Armbruster
2026-03-16 16:05 ` BALATON Zoltan
2026-03-16 18:00 ` Markus Armbruster
2026-03-20 10:09 ` Daniel P. Berrangé
2026-03-23 15:37 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaqcNeyNO2nmqEje@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=dapeng1.mi@linux.intel.com \
--cc=devel@lists.libvirt.org \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=mark.caveayland@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=zhao1.liu@intel.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.