Re: [PATCH 4/4] iotests/244: Add test cases for keep_data_file

[Kevin Wolf <kwolf@redhat.com>]

Am 30.05.2025 um 10:44 hat Hanna Czenczek geschrieben:
> Add various test cases around keep_data_file to the existing data_file
> test suite 244.
> 
> Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
> ---
>  tests/qemu-iotests/244     | 71 ++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/244.out | 53 ++++++++++++++++++++++++++++
>  2 files changed, 124 insertions(+)

> +# No preallocation is OK when also specifying data_file_raw; otherwise, none of
> +# the data file will be mapped, i.e. its contents will stay hidden, so
> +# requesting its contents to be kept (but hidden) doesn't make much sense.
> +#
> +# Metadata preallocation is OK: It will not overwrite the data file's contents,
> +# but ensure the contents are mapped and visible.
> +#
> +# Any data preallocation (like falloc) is not OK, as this would overwrite the
> +# data file's contents despite keep_data_file requesting they should not be
> +# overwritten.
> +#
> +# Note that all of these cases use the data file created above: This verifies
> +# that when passing keep_data_file=on, the data file is always kept as-is (and
> +# e.g. not deleted on error).
> +for prealloc in off metadata falloc; do

Why not add full just for the sake of completeness?

Kevin