From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B440BF01832 for ; Fri, 6 Mar 2026 14:22:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1247796.1546230 (Exim 4.92) (envelope-from ) id 1vyW3r-00028e-FE; Fri, 06 Mar 2026 14:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1247796.1546230; Fri, 06 Mar 2026 14:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vyW3r-00028X-Cg; Fri, 06 Mar 2026 14:21:51 +0000 Received: by outflank-mailman (input) for mailman id 1247796; Fri, 06 Mar 2026 14:21:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vyW3q-00028M-ER for xen-devel@lists.xenproject.org; Fri, 06 Mar 2026 14:21:50 +0000 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azlp170110003.outbound.protection.outlook.com [2a01:111:f403:c110::3]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9537522a-1967-11f1-9ccf-f158ae23cfc8; Fri, 06 Mar 2026 15:20:10 +0100 (CET) Received: from CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) by IA3PR03MB8456.namprd03.prod.outlook.com (2603:10b6:208:53c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18; Fri, 6 Mar 2026 14:20:07 +0000 Received: from CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343]) by CH7PR03MB7860.namprd03.prod.outlook.com ([fe80::f5ba:35df:1c9f:b343%4]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 14:20:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9537522a-1967-11f1-9ccf-f158ae23cfc8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HyDyyH3UZz3LLNqtdQFrTZGfKRQSQPYdRjWToHF/2ILjBPrB4NQFkbLkuoU1UmKG7Ln4oFqDEC/ELmBXLR+n2vRsAwLhIKoSiov9U9MkzxiEfwCSUD52HmryQKCLKTKhcLuEH4xPviAS6UZltxtUWXgcotujLwmcaBofoEuSn7kV1EaeomJrnWxA/Hc8caHPvioTz8L4tf28E87gbxAVWtLVS9OrqYMOqLLBJhuFR47rgZtl2q8ApEZ08K5FfUtLuqqXbQN/maPF2xdeDHmRmQkwAqxKmJozSNmj9QjxmY/a+zI5Bvg2l1mJJ6mPFqerfCyYVkqdkYtkq0w8NFmRTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2EU4qSkvZhAQNhEkyrOIgureEUnebpHF+nXMaNnoQdY=; b=VGKs6eNGrOu8ffdBin/J65Yms4uy6/d2P5NySTXzcUdrF0IgSTVqzlq24o/cjiX4i8A9Ho9Wdy4oECFUOAna+oJ2xRcBMk6vC7zRIz41Xu9Kd4cJweBUCeqQvg12GypIKn7AaakfsPUYkP4VW3o7aWmGXKZOQl8zc7sp/N0dwQCxolrFlqrC3qMR6nX2ihWQtQDXitRZ84bkWueidrMyvoUFH8j8hX1eegw8MOEZB9vrUBVvp/0zz8P3Usr+a3lmVNFTseUQqE7+UnlWYdIaI+tzTn50Cf2pJKyFZzUfSzSAs7HFi1WU4J+Ipeq32wX3weLvKcRNu6loaovkimczPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2EU4qSkvZhAQNhEkyrOIgureEUnebpHF+nXMaNnoQdY=; b=MJcHjJ5+Q0vXTSUPZ1sW4Sm0I8WsWZud2Btk95KDAByUIxJZNnn9r6EidjJwy8IEADNJTyLD9plKrnkAyI55viygdfhPBLTjA3TT1lAd3QZo/OESVdyzavYHP8A4BECvSAqYk8P7mKCYckKB4luW5q8uhy/Nmikc3pNHOJtj2yA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 6 Mar 2026 15:20:03 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Julien Grall , Stefano Stabellini , Anthony PERARD , Michal Orzel Subject: Re: [PATCH] core-parking: shrink and relocate core_parking_cpunum[] Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR1P264CA0206.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:56::19) To CH7PR03MB7860.namprd03.prod.outlook.com (2603:10b6:610:24e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH7PR03MB7860:EE_|IA3PR03MB8456:EE_ X-MS-Office365-Filtering-Correlation-Id: b344f33b-43f2-47ab-7077-08de7b8b77a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: 4yburyWBAJKpVvUzW3YByqlmoKnnWk7iUnFV6eoDajoxH9omh9x+yv4x923zNK2T4SjIBylQOt1dP4KIIp8PEvcTnoTDjK2IXQUbsy74cFRSafjWVuvtxeuleue/JXfIfP6q0lw4AxO4QF9THtrhqoW8o3tnuI/8h9vS1F7DYnMVBLOqGtX9cqYn4sImccxFYIa2Cy/eF+u7nD4Y+zznDu0ASXB9dlyHSvoBBguF7oXG1K9p7ojdIH4Vw0Eq4IytF9jXU95niBg7N42lD1B+fh3D1LXZLqIa2bmVPC5R62M0XXnqTKqgCA8FJVBJ8s40YM0HGiE+vRM5FPBQThC6+LSa5RrM+s8IO9xnmmhf6hDsvvaISGJ+dHzG7KLmBLRM7uOEiM0umrQIgEUHusEUgVAUYUyYEeltVl6mun9t3lCBZttACXdQhobR5wabbPru32H3WcDSKQjazPOKAEqPXsnUpwagjYteQcghsuorI7bgToi/vG3NcGgdircd3XVNyPDavuQxJ6/9WlQSZ498G4JMIt0Rvu7b/ZTDjnbMEOA/ZdZZisEjKs4XjVtY3ZxADGEmIRC+6kAM9QzhnTiVjSYh//M6s+6NfFKeOo1j8dQuCRsuJS7EEEF5q6xFuhwCaIQLTR/0A32lASr4SrGaeC/pCBWlVZY6asAja1tl2VNPQFuF+i9WTg2VSddgzTkWEUKc8E7C3dv/23Y/ZMU9pTq68D1kJYEAGTT3Ip7AYLY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH7PR03MB7860.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk9sdG01OFphZEZXSzNBdWkzY3hpVlNwKzR0dWs2cnQrUUdEc3AxMTgyWEYw?= =?utf-8?B?dmtLYXU3VlFQVklGK1lNdEU0UUx1dmkrTEMrc2sxZmd5eFBaN3lObnZMVVdp?= =?utf-8?B?bGc3NmhnQ1Z4NHFqTUt0QkxSUURDWjhpdHNhZVdRK0pQeXlEZGM4MlhqNTBX?= =?utf-8?B?Z0ZLb1dON2JBakhCTXhPdnpiYS9KMWhjQzB4Vzc1OTE2MytlZFJCRTZQRXE2?= =?utf-8?B?VEEwcjg2WXZ1aExvalRlRUU4ZXozZm9lZjdLdGhwUEg4Wi83YUdpMFdrMWJw?= =?utf-8?B?QmFKYW5sSzJtN0pDVkpKNWJGamlHZ1ZUK1J1QnZnaE1WQnRLN0lXcGlMcWFE?= =?utf-8?B?TlJlTmFqWTlsSzMrQlU4Vkl3WERSYkZkVUt1WE5KNHloNWV2YlZOQmhnYlZV?= =?utf-8?B?NHE0NWxrVEtuM0dETXdVNEE5bSttNjVZS0lEZjBQZkdhTzJZMzd0Y2FQaDVr?= =?utf-8?B?aVJlcVlvRlpkZC9DN1gxOUNXZjhPM1pxTVh4d0hoS0FJOHRCUGx4V1JiSnEx?= =?utf-8?B?enRsZDJmaUlOSTVPZFMyT09jOXlJTXU5ODYzdGo3c3BpNHBFb3FJK25oSkJX?= =?utf-8?B?VVBuMlcrZGlhZkU0dzB2d3ZsbisxWUVqYVl5aWdhaEJGclNnUENUbGRzMHln?= =?utf-8?B?VnQybjJ1bmd6cW9KSndrVmt4Q2tBLzh4LzQwNUMrVVp6Q0ZvTlhGQWh6WlF4?= =?utf-8?B?c0lybGVNK01wT21YdUg5Sm1aTmhQVWJmNjFSSGU2Nkt0MytSNjljK2k1SlR6?= =?utf-8?B?K2hwbmJDL2xJV0I5MW1jZi9HZEltMFlQYVdSdGwrYUpQcnNqaXl3bzVOMDUx?= =?utf-8?B?dHp6QzlKeHlJSmMzYTgwdGp1cU4xVklldFpnbW5hR2pJVTVtRmt1YW16dHFa?= =?utf-8?B?MEs2Nm5mckl3b0hrOCsyMmZ1VzJTd2pBemYvbXJCSVd4VWFuN0xvaStlcnZN?= =?utf-8?B?Y0lMcDcydmR3ZGdlNXFaWVNxdjA5V3k4L2xGK21Nd2dFS1ZoV3BPbHB2ZlY1?= =?utf-8?B?dUtwMVV6MUx3ZGlJem9ZRXVkZUVWbVY3Nkt4RktOR255VFFuN3BZUi93QWp0?= =?utf-8?B?ZnJUVm0vTUJUeEo4WHRIbFNyM3FKSk8xS25ORW9QcDlsRDhyY0NycWVLYlNG?= =?utf-8?B?aDA0a3E1T05PYnRjYlRkZU5ZSm5HWUVORUFMcHNBZVFuYVptZzJKSnNGbWE5?= =?utf-8?B?UWFJZ0hkV3VySDEzdjl4dTl1UnEyVzJhai9pcjJ6dkJpcSsvU3R0eTc3aG5I?= =?utf-8?B?eEYwUjlPOE1tRmJINzVoR1gxOXhEUmpqaUtESFR6VUZjakU1NWUrVVo2SXg1?= =?utf-8?B?TFNpRnAzckRtelltOFM1bHhtcGRYREhPczErQmFTa1A3Zit4OHhuQmRMaXlX?= =?utf-8?B?Uzc4WFRIR01FbzcvNU9LUmNCRWJHVnR5dFc3cHplY2xqMDFJVzZYRFlWS2lX?= =?utf-8?B?Vlc3U1pzRERXRVpwc2kwaVcyVmg5OHFVdmRKWFZDMkoyOEhGMU0rSXJYVElB?= =?utf-8?B?dGFySGVsbkhWckV3RW9Yd3l3S3hpdUNDenl5Rzk3S0NHRTFRbE5UMnc2b214?= =?utf-8?B?RHJSbkRxSkFla1NXejhSRVdUdTc2SzJrTmliUXNyaFZ6Z0NNZEM4aDFyUW1i?= =?utf-8?B?d2lLaTRDT2JQQ1B2MjNaQnhjWmM4aFg3SnB2OVZicTNsWHpMNmE4Yk5Ia0JE?= =?utf-8?B?UGJvaklGdDczZ2YydHZEZmljUTR5MmorSmRCRDBnV1NkSkdkRUpvRTN6SWVX?= =?utf-8?B?V2p2Mk9BZ0QxSEoyQjNJZk80SUVJUGxtMmYxYkFaS0cvTjdvalY1SXJqcDlp?= =?utf-8?B?WDg4ZHFNUEZ2YzhKWmFBV28zQWRDamlkd09Rem40SksvU2dPa05KV3FaUDJK?= =?utf-8?B?eGtjV3hGQ3BPck9wWVM4TURTRXUyaXIwZjNuMllqWEZNTHU2OC9FNVVOWVNV?= =?utf-8?B?WENqY0g2bzFoeGRmaDVvc2NsWlJtTUNsb21VcGlzUlZiaEtFQ3E3YVZQbm9Z?= =?utf-8?B?QnlUVk14bTFhdXNrZUU5LzVkOFZMUFdZYWFOdDJCbG9rWGNlVkNoRkh4TUhE?= =?utf-8?B?M3BlNmo3WGlsMWtaWFlGWjBRQ0tpSEhtbWt3NC9lOE5yYWxrb0drV0wyTXFu?= =?utf-8?B?YVpMQ0VXanpISnFLeGdsVmVOUFRJWFduanZzbXFEbUFEQUxXT0ZKeUs4bVFO?= =?utf-8?B?YmtnN2ZwMHNLMElWNERBcXVKQjZGSEVlbEFKNml4U2NjS2VMVUlPcHVYVEo3?= =?utf-8?B?aEF5L1EycW9sUmhOYlVDc0o0eDlTT1ZENE45R2hzQm9QZ0xjZFRGR3A1Vk1j?= =?utf-8?B?UTgyRlRPcWNlQjZVTmN0TkdnOXgzQTEvUkJvQ20xSGl6Y0tLUEJEdz09?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b344f33b-43f2-47ab-7077-08de7b8b77a0 X-MS-Exchange-CrossTenant-AuthSource: CH7PR03MB7860.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 14:20:07.6346 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X2K3mzJpnpCQevumkBoopuWOIHKz3pdrOEJOdeKxLFI0Usqbv0caGX1A/XYmknnkWNl5xuwzOVTpoo484oqgfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR03MB8456 On Wed, Nov 12, 2025 at 04:38:13PM +0100, Jan Beulich wrote: > This NR_CPUS-dimensioned array is likely unused on most installations. > Therefore it is especially wasteful for it to consume more space than > really needed. Use the smallest possible type. > > Further the array having all fields set to -1 is actually useless. Nothing > relies on it, and core_parking_remove() doesn't restore the sentinel for > vacated slots. Drop the initializers, moving the array to .bss. > > Finally take the opportunity and update an adjacent variable's type, where > a fixed-width type was pretty clearly inappropriate to use. > > Signed-off-by: Jan Beulich > --- > I assume there is a reason this is acting (mostly) as a LIFO. Else a > simple cpumask_t would suffice. > > An alternative would be to use the new BRK allocator, at least for NR_CPUS > above a certain threshold. Can't we just allocate this memory using xvzalloc_array()? If we do care about it being too big certainly allocating only when needed, and based on the number of possible CPUs on the system would be much better than playing games with the array type? Thanks, Roger.