Re: [PATCH] hw/nvme: add `model` parameter

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Mar 05, 2026 at 01:47:45PM +0100, Klaus Jensen wrote:
> On Mar  5 13:11, Avi Kivity wrote:
> > On Mon, Mar 2, 2026 at 4:50 PM Avi Kivity <avi@scylladb.com> wrote:
> > 
> > >
> > >
> > > On Mon, Mar 2, 2026 at 4:39 PM Daniel P. Berrangé <berrange@redhat.com>
> > > wrote:
> > >
> > >> On Mon, Mar 02, 2026 at 04:27:48PM +0200, Avi Kivity wrote:
> > >> > Add a `model` parameter, readable with nvme-cli. This allows
> > >> > impersonating other disk manufacturers or hypervisors, similar
> > >> > to the the -smbios option.
> > >> >
> > >> > Signed-off-by: Avi Kivity <avi@scylladb.com>
> > >> > ---
> > >> >
> > >> > Disclosure: prepared with AI assistance. I believe it to be of good
> > >> > quality.
> > >>
> > >> Can you clarify how AI was involved,
> > >
> > >
> > > I asked an LLM (Claude) to add a model parameter to the nvme code, which
> > > it did, then I asked it to documented it, which it also did.
> > >
> > >
> > >> as QEMU's policy is to decline
> > >> any contributions where AI was involing in an authoring role:
> > >>
> > >
> > > Very unfortunate. It would have taken me an hour or two to re-orient
> > > myself in the code base, for something that took me a couple of minutes
> > > with AI.
> > >
> > 
> > So what's the verdict?
> > 
> > FWIW I think the probability of AI copying these few lines from some
> > non-GPL project is zero.
> 
> As maintainer I don't have a problem taking this patch, but I'm not sure
> how to deal with the policy in this instance.

When introducing the policy we had debated whether to allow so called
"trivial" patches where one might argue the copyrightability concerns
are negligible, but could not come to agreement on that matter so left
it as strict policy.

> Daniel, please advise if I can take this. I'd have written the patch
> like this myself.

To avoid having to exhaust time debating this, I've wrote new
patches myself without direct reference to Avi's proposal, which
do the equivalent thing, plus some more on top.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|