From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Andrew Davis <afd@ti.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] remoteproc: pru: Use rproc_of_parse_firmware() to get firmware name
Date: Fri, 6 Mar 2026 10:35:10 -0700 [thread overview]
Message-ID: <aasQTtI4mkH9Vd6a@p14s> (raw)
In-Reply-To: <20260302202728.322073-1-afd@ti.com>
On Mon, Mar 02, 2026 at 02:27:27PM -0600, Andrew Davis wrote:
> There is a helper function to get the firmware name, make use of that.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> drivers/remoteproc/pru_rproc.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
... and this one too.
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index 5e3eb7b86a0e3..19b107d29242d 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -1003,11 +1003,9 @@ static int pru_rproc_probe(struct platform_device *pdev)
> if (!data)
> return -ENODEV;
>
> - ret = of_property_read_string(np, "firmware-name", &fw_name);
> - if (ret) {
> - dev_err(dev, "unable to retrieve firmware-name %d\n", ret);
> - return ret;
> - }
> + ret = rproc_of_parse_firmware(dev, 0, &fw_name);
> + if (ret)
> + return dev_err_probe(dev, ret, "unable to retrieve firmware-name\n");
>
> rproc = devm_rproc_alloc(dev, pdev->name, &pru_rproc_ops, fw_name,
> sizeof(*pru));
> --
> 2.39.2
>
prev parent reply other threads:[~2026-03-06 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 20:27 [PATCH 1/2] remoteproc: pru: Use rproc_of_parse_firmware() to get firmware name Andrew Davis
2026-03-02 20:27 ` [PATCH 2/2] remoteproc: pru: Remove empty remove callback Andrew Davis
2026-03-06 17:35 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aasQTtI4mkH9Vd6a@p14s \
--to=mathieu.poirier@linaro.org \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.