From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E90534B691 for ; Sat, 7 Mar 2026 10:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772878803; cv=none; b=UtXkoomlBzni52l1K2Xvrv8y6cYosP6OKFmofdDPDA6IrMUTT07TYgp9WPfe74IDAlZ+9o36IrzQOS0Yj7FOILJ+7RZWwzNgKSIYaPXZncA7VhghtgSYqm4YowfeDQH0Vx8GNX+OtUZoyf8X+jJitcCY1oajwagyTGzB/5gib3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772878803; c=relaxed/simple; bh=UgzszF2w+GWMSIr+7HCPwCnvRTeEDIRE6WXIsTPqOr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O+wQiI6ON9+054HnsqMTQotN1/vOcCRL8QSds6U77kaRZ9FCbgIwYmYaIyhhlg5bwis1OaoeynlUUY8rlZkycZlIAeYJvdv2FBe4FyIHZSYMmPR4UUxuX0T6lZOJ8mt6mGvQxNnnOq0dsJKoaLDjmDx++iWsbqaNOGwrWmU/e+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=SHoNKXWm; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="SHoNKXWm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1772878798; bh=o5DTDhZeNB9ECfHMcIEiz4fHlmh0QEcHUaOtObGzzNQ=; h=From:Message-ID:From; b=SHoNKXWm8ABNhDif6NnnKxIt+pkx2s4+ChlcqRHgmrKSnxr/945mUO8ScF3jKoscN l3A+EC38B4RlK36fodKacirFLt+SY9H/ACzgOWqyBp/4QWovo7FZqrKHzQmlYT/3To elJ0yj1TZEvtY2eHErrkvH8vLPSy9MhfYEXKI6bM= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 9DC73C0A1A; Sat, 07 Mar 2026 11:19:58 +0100 (CET) Date: Sat, 7 Mar 2026 11:19:58 +0100 From: Willy Tarreau To: david.laight.linux@gmail.com Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v4 next 10/23] tools/nolibc: Rename the 'errnum' parameter to strerror() Message-ID: References: <20260302101815.3043-1-david.laight.linux@gmail.com> <20260302101815.3043-11-david.laight.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302101815.3043-11-david.laight.linux@gmail.com> On Mon, Mar 02, 2026 at 10:18:02AM +0000, david.laight.linux@gmail.com wrote: > From: David Laight > > Change the parameter variable name from 'errno' to 'errnum'. > Matches any documentation and avoids any issues that might happen > if errno is actually a #define (which is not uncommon). Good point! And more importantly, shadowing the real errno is super risky in case we'd call a macro that accesses it from that function. > > Signed-off-by: David Laight Acked-by: Willy Tarreau Willy