From: Kohei Enju <kohei@enjuk.jp>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
intel-wired-lan@lists.osuosl.org,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH] iwl-net: ice: fix locking in ice_dcb_rebuild()
Date: Sat, 21 Mar 2026 01:55:01 +0900 [thread overview]
Message-ID: <ab148uuvjby_nMMW@x1> (raw)
In-Reply-To: <20260320160707.3047815-1-bvanassche@acm.org>
On 03/20 09:07, Bart Van Assche via Intel-wired-lan wrote:
> Move the mutex_lock() call up to prevent that DCB settings change after
> the first ice_query_port_ets() call. The second ice_query_port_ets()
> call in ice_dcb_rebuild() is already protected by pf->tc_mutex.
>
> This also fixes a bug in an error path, as before taking the first
> "goto dcb_error" in the function jumped over mutex_lock() to
> mutex_unlock().
>
> This bug has been detected by the clang thread-safety analyzer.
nit:
I believe the subject should be
[PATCH iwl-net] ice: fix locking in ice_dcb_rebuild()
since iwl-net is the target tree name.
next prev parent reply other threads:[~2026-03-20 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 16:07 [Intel-wired-lan] [PATCH] iwl-net: ice: fix locking in ice_dcb_rebuild() Bart Van Assche via Intel-wired-lan
2026-03-20 16:55 ` Kohei Enju [this message]
2026-03-26 7:24 ` Loktionov, Aleksandr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab148uuvjby_nMMW@x1 \
--to=kohei@enjuk.jp \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bvanassche@acm.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.