From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Cong Liu <liucong2@kylinos.cn>
Subject: Re: [PATCH mptcp-next v3] selftests: mptcp: fix incorrect fd checks in main_loop
Date: Wed, 19 Mar 2025 18:40:47 +0100 [thread overview]
Message-ID: <ab1836f2-cd26-4d35-a8d0-58060d17cb02@kernel.org> (raw)
In-Reply-To: <e965bea9-25ac-4b1a-9f18-0c0c3c4a9633@kernel.org>
On 19/03/2025 18:35, Matthieu Baerts wrote:
> Hi Geliang, Cong,
>
> On 18/03/2025 12:15, Geliang Tang wrote:
>> From: Cong Liu <liucong2@kylinos.cn>
>>
>> Fix a bug where the code was checking the wrong file descriptors
>> when opening the input files. The code was checking 'fd' instead
>> of 'fd_in', which could lead to incorrect error handling.
>>
>> Fixes: 05be5e273c84 ("selftests: mptcp: add disconnect tests")
>> Fixes: ca7ae8916043 ("selftests: mptcp: mptfo Initiator/Listener")
>> Co-developed-by: Geliang Tang <geliang@kernel.org>
>> Signed-off-by: Geliang Tang <geliang@kernel.org>
>> Signed-off-by: Cong Liu <liucong2@kylinos.cn>
>> ---
>>
>> v3:
>> - resend the pending patch from Cong Liu, he said to me that he has
>> no time to deal with this recently.
>> - add another "Fixes" tag as Matt suggested.
>> - update the subject and commit log.
>
> Thank you for the v3!
Now in our tree:
New patches for t/upstream-net and t/upstream:
- f1aedae2b9e9: selftests: mptcp: fix incorrect fd checks in main_loop
- Results: 337db8693fa1..15fd746f34c5 (export-net)
- Results: 8131e8aff41d..2bea3081157b (export)
Tests are now in progress:
- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/9faaf0099006d44557034273d9204d64385cfb1a/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/b1252371e4122d56004e65cece710905a3de6334/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-03-19 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 11:15 [PATCH mptcp-next v3] selftests: mptcp: fix incorrect fd checks in main_loop Geliang Tang
2025-03-18 12:21 ` MPTCP CI
2025-03-19 17:35 ` Matthieu Baerts
2025-03-19 17:40 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1836f2-cd26-4d35-a8d0-58060d17cb02@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=liucong2@kylinos.cn \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.