All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Valla <francesco@valla.it>
To: "Freihofer, Adrian" <adrian.freihofer@siemens.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	 Francesco Castagnotto <fcastagnotto@linux.com>
Subject: Re: [PATCH RFC 1/4] bootconfig: add recipe
Date: Fri, 20 Mar 2026 14:27:19 +0100	[thread overview]
Message-ID: <ab1J5aEpSIGSTRw3@bywater> (raw)
In-Reply-To: <4ba9dee07620ce57643a005f6578fbd32efd9e8f.camel@siemens.com>

Hi Adrian,

On Thu, Mar 19, 2026 at 08:54:35AM +0000, Freihofer, Adrian wrote:
> Hi Franceso
> 
> Thank you for the patches.
> 
> On Thu, 2026-03-19 at 00:30 +0100, Francesco Valla wrote:
> > Add a new recipe for the bootconfig tool, with source coming directly
> > from the kernel shared workdir.
> > 
> > Signed-off-by: Francesco Valla <francesco@valla.it>
> > ---
> > �meta/recipes-kernel/bootconfig/bootconfig.bb | 44
> > ++++++++++++++++++++++++++++
> > �1 file changed, 44 insertions(+)
> > 
> > diff --git a/meta/recipes-kernel/bootconfig/bootconfig.bb
> > b/meta/recipes-kernel/bootconfig/bootconfig.bb
> > new file mode 100644
> > index
> > 0000000000000000000000000000000000000000..77ee70dd1839ef90a292cf829f4
> > f3a4353f85c28
> > --- /dev/null
> > +++ b/meta/recipes-kernel/bootconfig/bootconfig.bb
> > @@ -0,0 +1,44 @@
> > +SUMMARY = "Apply, delete or show boot config"
> > +DESCRIPTION = "bootconfig is a tool that can be used to add a boot
> > config block \
> > +at the end of a kernel initramfs, as well as remove it or show its
> > content."
> > +LICENSE = "GPL-2.0-only"
> > +
> > +inherit kernelsrc kernel-arch
> > +
> > +do_populate_lic[depends] += "virtual/kernel:do_shared_workdir"
> > +do_configure[depends] += "virtual/kernel:do_shared_workdir"
> > +
> > +EXTRA_OEMAKE = "\
> > +��� -C ${S}/tools/bootconfig \
> > +��� O=${B} \
> > +��� CROSS=${TARGET_PREFIX} \
> > +��� CC="${CC} ${DEBUG_PREFIX_MAP} -ffile-prefix-
> > map=${STAGING_KERNEL_DIR}=${KERNEL_SRC_PATH} ${CFLAGS}" \
> > +��� HOSTCC="${BUILD_CC} ${BUILD_CFLAGS}" \
> > +��� LD="${LD}" \
> > +��� AR=${AR} \
> > +��� ARCH=${ARCH} \
> > +��� V=1 \
> > +��� 'DESTDIR=${D}' \
> > +��� 'prefix=${prefix}' \
> > +��� 'bindir=${bindir}' \
> > +"
> > +
> > +do_compile() {
> > +	oe_runmake ${B}/bootconfig
> > +}
> > +
> > +do_install() {
> > +	install -d ${D}${bindir}
> > +	oe_runmake install
> > +}
> > +
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> 
> This is not understandable to me. From the description I would assume 
> this tool runs on the host machine.
> 

I probably overthought the usecases here, with bootconfig being used on
the target for on-the-fly bootconfig modification. But this wouldn't
work with a FIT image obviously.

> > +
> > +python do_package:prepend() {
> > +��� d.setVar('PKGV', d.getVar("KERNEL_VERSION").split("-")[0])
> > +}
> > +
> > +B = "${WORKDIR}/${BPN}-${PV}"
> > +
> > +BBCLASSEXTEND = "native nativesdk"
> 
> If the tool runs on the host machine, should this not be a pure -native
> recipe without this line e.g. named bootconfig-native.bb
> 
> Is bootconfig a good name for a recipe? Or should it be e.g. linux-
> bootconfig-native.bb?
> 

linux-bootconfig is a good name, I'll go with it in the next revision.

> 
> Side note: We need to be careful not to create a dependency of the
> initramfs on the kernel build directory. Such a dependency would
> essentially invalidate the sstate-cache for the kernel, which we want
> to avoid.

Agreed, one of the unpoken reasons for the RFC label is that the
reasoning about dependencies has not been completed yes. I'm still
facing challenges e.g. for FIT vs WIC cross-dependencies when a
dm-veriry rootfs is used and its parameters are inserted into the FIT
image that lives in the boot partition.
But I wanted to gather a first round of impressions with a (working)
first version while working on it.

> 
> Regards,
> Adrian

Thank you!

Reagrds,
Francesco



  reply	other threads:[~2026-03-20 13:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 23:30 [PATCH RFC 0/4] Add support for bootconfig on initramfs and FIT images Francesco Valla
2026-03-18 23:30 ` [PATCH RFC 1/4] bootconfig: add recipe Francesco Valla
2026-03-19  8:54   ` Freihofer, Adrian
2026-03-20 13:27     ` Francesco Valla [this message]
2026-03-18 23:30 ` [PATCH RFC 2/4] image_types: add bootconfig conversion type Francesco Valla
2026-03-18 23:30 ` [PATCH RFC 3/4] recipes-test: add bootconfig-test recipe Francesco Valla
2026-03-18 23:30 ` [PATCH RFC 4/4] kernel-fit-image: add bootconfig support Francesco Valla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab1J5aEpSIGSTRw3@bywater \
    --to=francesco@valla.it \
    --cc=adrian.freihofer@siemens.com \
    --cc=fcastagnotto@linux.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.