From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792883634; b=zCpvZjFc9Jzte9HwMkFyRZ2d2XHkXlQVbH8XlWIDW2ucmN1J9FKQGTgPkCyFgUEoJ90x iyQuXC+3ZUUT/ZvJ3hZ6vxnDn8WQOhnOVeNfJd9uXxdx6dmLhk8yODjMxH5xP0LmT4Ul7 m2OPImafnFclK/CKjFgRRxxCdo7FDcsTwivuXimYhfoxpZHDab/mf5wnj2edf2HEVum1N DDStwa81tAO4rg0aYHbk/7N7F7wCvNZw1Sd2sdwsQp8I5e3B1nIS/kPq3lNpv3gdVK/Ff SHWjgaLgUka6wYBd9tHopG1Wmx0I0TcDGi24HjyOjpnUx+iUeZRzdDpnlPRroHSJJQA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792883634; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding: Content-Disposition; bh=imAl4+nQz/6gt4gpxMhLcrwfP6Z7GTEGSm74OZaRico=; b=blWau3VjZ5OSzJbOG0xDzbtQuxTkfBiI4oaMtCiylq6VeLJXtprDbDUw/P4P5kjXnB3+ Ld5iwoh4kkQsOTwPCFMi8YRSC/U4J+EBiNyPHSpCe7kjZw074tkQry2G2F1oZm0samz+2 wrN09K1hxRzeHiMWRsyJQixm6LhNeJYmDNn7zvNRoqwqPLUlYdg1sUP3632HCPhAPcy30 4/fjMLvVVAlBwE8t18bJ010stHNzxpNWzDWV+7N25ZHvdlJPBIAGI/OZQCqda7ekaSqUv jhkTydPip55XY46+YLjN+P/QHpZy8BevUjS6/t6CCLQypZj4LoU9n2dP/cG8xsd2yYQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=NrStFlRl; arc=none smtp.remote-ip=74.125.82.54 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with UTF8SMTPS id B25BD606A328 for ; Sat, 24 Oct 2026 23:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B25BD606A328 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=NrStFlRl Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-188406bb948so1532735c88.1 for ; Sat, 24 Oct 2026 16:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792883633; x=1793488433; darn=vger.kernel.org; h=content-disposition:content-transfer-encoding:content-type :mime-version:references:in-reply-to:subject:cc:to:from:message-id :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=imAl4+nQz/6gt4gpxMhLcrwfP6Z7GTEGSm74OZaRico=; b=NrStFlRltiFi7cA7liJFpE6qPKybS4VZpOjC5fp0LXf/iEtTddkuQspnqk3FuCL2Gl P8nT2Nhhfx1/QFKJ6SAiJlDtZYbjs8u/CP9secYM9yFnL4kBM0oGONLZ9hYteeSBdwbb f3G0Je9HzdAkRDG//UKBtwTAdcYm9aCV2s7lxjj2pvM/XMG6w+iL60Aj+Coba8Kyrjrf M0jXUlBHfMi2WxcHgsnkEXOShdfRCuJSOO2Z9QcuaqYSR3Z85Y5U9quONEDqssJVybiN nDX67zcJAbBmTxfJJIrDE6Kqdf77Mma98YmhJlSeC1e/v4gfGW3n9sPtTyXkwOKeAH5y TDgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792883633; x=1793488433; h=content-disposition:content-transfer-encoding:content-type :mime-version:references:in-reply-to:subject:cc:to:from:message-id :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=imAl4+nQz/6gt4gpxMhLcrwfP6Z7GTEGSm74OZaRico=; b=NXG6GAxkIBgIoXMtM2rprQliSxuEu7QmK9Ck58s/4R39HcI/YklMUJJ12LoHkH4+PK uUvG3cfhuTiIO8NKNqWHlPAPdXk0oNPKzGkeAmQGmJ5WbacErl/YXXeqhlh0Qnj9h1kF uP2wCrfFgVBk4y5gjoyMatUBjyKcNa9RxG/yV+iV6xUwuvtLoOitp7crylptIDTVViGN xrPHV24C8cJXt5LqGxx1JbLRMsSYYRzPmY7KIkn5IqdNkxSaWWzpXtJogxzVYPeu7EPn quKqSrmrU0QRpXJYZT6ANl5IuChoklPBr0TqhKmFrs42xX7TpXrMPDOB6nylPexgOmwg YLWw== X-Forwarded-Encrypted: i=1; AKwUvBwjdUT/OMvehAD1kVb1TgV15dbyTOX+BymXP3cPs/ScHMHQiz0PLiBs90ZP769x0/B/kYZh6UWoCrSK7iL3MWA65RmN@vger.kernel.org X-Gm-Message-State: AFq9FYIIOPD4higfHRw/k+gxStBefsRz1qSCuwpeDi7ES1167nOUUz3k ZRIotx2pYEOzcD+jPq1RfcJpGcrQ9wEtnM/8SApRtc8PVwyFqXqn/Mxs X-Gm-Gg: AYBFou3qf18f1eZoAa3R0Nd2Xg+KukWyMUq/iTbknYfFU/HdsQACFchtdTPouad/oiD /7IN8cucKH9N36/3QGlCbwgubbK5yyhRSFEzeCt0HPoIbMmBKUJaWo5bEQSDqMHsNY/ElkiQqdL XuF3AqLM5ocYquzNv81KMCgS/aqfbfbfDw7v6Tkhtj7W88Bu/Ef60eGLhIDYPWoe2bv+VghVnsD 1afDSxiEOYsXV+2TgRKF2nCl80HZNQYtSfEWY64Z5QrBlnOfk+sqyVFT4YaAexsoTxtTwgD07t5 oqyyO5w1MRAV1ddjdT1ZBd4LJBjrveRt3krhRMTcG7LF1gfrtVoJ1Q7JoQrTuyeXNEUQOpWU8vE 0IVPSUpFYpLMwNkVLweed93K9mJ/cUmuv++3WHWZtdQUHqEUsMjrrpmCY40oTxCDvgfUgfPZNkE RJPtGNx7wpeFnKUYlNE3AonjpqUTFvdhahtvvReRbFPNBBkTGyUWMoBp1boiTrN83DrI5voIDAH FdZBZeQEMvyjTJWPueAA8kKvxI8RyX81HLlHTdnhSYDkciLJ8JX3Wmz6/1Mf7Q53ir/z4WotCCZ qjRLRQoTrvCNCAPbXqL/HoAAjHkbHCW2zFWAzuQb X-Received: by 2002:a05:7022:49c:b0:144:c128:4c4b with SMTP id a92af1059eb24-19937309cd8mr5409029c88.36.1792883632404; Sat, 24 Oct 2026 16:13:52 -0700 (PDT) Received: from localhost ([2a00:79e0:2ebe:8:8fe4:693:7158:24de]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-198a2a5937dsm10508969c88.20.2026.10.24.16.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2026 16:13:51 -0700 (PDT) Date: Sat, 24 Oct 2026 16:13:50 -0700 Message-ID: From: Dmitry Torokhov To: Rong Zhang Cc: Mark Pearson , "Derek J. Clark" , Ike Panhc , Hans de Goede , Ilpo Järvinen , Maxim Mikityanskiy , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] platform/x86: ideapad-laptop: do not poke keyboard controller In-Reply-To: <5bdb870be988333df200ac7d4904dd1bda6ef52f.camel@rong.moe> References: <4b2f60a7ceac543bd8b889b9c0772b2c@gmail.com> <8cdbdcb893e2353e0ea2fe919e0c8a6a53f8b683.camel@rong.moe> <7b21717e80a7b779ab94d964ca40ee68@gmail.com> <5bdb870be988333df200ac7d4904dd1bda6ef52f.camel@rong.moe> X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Rong, On Sat, Oct 24, 2026 at 11:30:06PM +0800, Rong Zhang wrote: > However, the methodology has been changed from hardware-based to > software-based. Because of the fundamental change, it has the potential > to break something if some users depends on the side-effect of toggling > the aux port. > > While my device never needs the quirk, I can think of several useful > side-effects: > > - pause the interrupt (and hence pause event handling) to save some > energy > - prevent the touchpad from waking up the platform > - reset faulty touchpads > > By switching to the software-based methodology, all these capabilities > have gone. Of course, relying on these side-effects is a misuse, but > relying on the parameter itself without reporting it to the mailing list > is also a misuse! More below. This reminds me of https://xkcd.com/1172/ ("Workflow"). Also note that I8042_CMD_AUX_DISABLE / I8042_CMD_AUX_ENABLE only toggles the AUX clock inhibit bit in the 8042 controller; it does not power down or reset the touchpad (psmouse is unaware that ideapad-laptop poked the controller behind its back, which is the whole problem), and i8042 already manages the AUX port and wakeup state across suspend and resume. > A completely new behavior reusing an old knob is always prone to break > *something* in a obscure way unless users are notified about the change. > Breaking something with a visible warning [1] in kmsg is much better than > potentially breaking something in radio silence. > > We don't want to support poking i8042 anymore, so the use of > 'ctrl_ps2_aux_port' is anyway becoming unsupported. The parameter was > introduced only for debugging and is expected to be removed at any time. > If users don't report their use of the parameter to the mailing list, > they are already relying on a broken setup. > > By renaming it and breaking the unsupported setup loudly, we encourage > users to report quirky devices, as well as getting rid of an outdated > parameter name. > > [1]: ideapad_laptop: unknown parameter 'ctrl_ps2_aux_port' ignored We already have DMI matching for this quirk (ctrl_ps2_aux_port_list[], which has only ever contained the 2011 IdeaPad Z570 since commit c69e7d843d2c added it in 2022), and the module parameter simply sets the exact same priv->features.ctrl_ps2_aux_port flag as the DMI table. Intentionally breaking the module parameter for anyone who might be using it for its intended purpose (making the touchpad toggle hotkey work on an older IdeaPad) just because of hypothetical spacebar-heating workflows does not make sense to me. Thanks. -- Dmitry