From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: paeyz <iwasbaeyz@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org, Kees Cook <kees@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] adfs: validate nzones in adfs_read_map()
Date: Fri, 20 Mar 2026 16:05:10 +0000 [thread overview]
Message-ID: <ab1wNgL7VI9iyN_h@shell.armlinux.org.uk> (raw)
In-Reply-To: <2026032039-agility-ferocity-6ee0@gregkh>
On Fri, Mar 20, 2026 at 04:40:57PM +0100, Greg KH wrote:
> On Sat, Mar 21, 2026 at 12:21:31AM +0900, paeyz wrote:
> > From: Bae Yeonju <iwasbaeyz@gmail.com>
> >
> > Hi,
> >
> > I tested moving the nzones validation to adfs_validate_bblk() on
> > 6.12.36 with KASAN enabled.
> >
> > With this change, a crafted image with nzones=0 is rejected during
> > validation:
> >
> > ADFS-fs (loop0): error: can't find an ADFS filesystem on dev loop0.
> >
> > mount() returns -EINVAL, and no crash or KASAN report is observed.
> >
> > So the issue can be prevented by validating nzones earlier in the
> > validation path.
> >
> > Tested-by: Bae Yeonju <iwasbaeyz@gmail.com>
>
> Great, can you rework your patch to move the check to that location and
> send it?
... great, giving me no chance to reply to your previous email...
In netdev land, we have a rule: wait 24 hours between posting updates,
so that discussion has a chance of completing. I suggest that would
have been good here.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-03-20 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 14:23 [PATCH] adfs: validate nzones in adfs_read_map() Greg Kroah-Hartman
2026-03-20 14:37 ` Russell King (Oracle)
2026-03-20 15:05 ` Greg Kroah-Hartman
2026-03-20 15:21 ` paeyz
2026-03-20 15:40 ` Greg KH
2026-03-20 15:52 ` [PATCH v2] adfs: validate nzones in adfs_validate_bblk() paeyz
2026-03-20 16:04 ` Greg KH
2026-03-20 16:08 ` Russell King (Oracle)
2026-03-20 16:11 ` Greg KH
2026-03-21 4:45 ` [PATCH v3] " paeyz
2026-03-20 16:05 ` Russell King (Oracle) [this message]
2026-03-20 16:02 ` [PATCH] adfs: validate nzones in adfs_read_map() Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1wNgL7VI9iyN_h@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=iwasbaeyz@gmail.com \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.