From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDA041099B40 for ; Fri, 20 Mar 2026 21:19:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43B4210E05A; Fri, 20 Mar 2026 21:19:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="bYC0V5FN"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B0DB10E05A for ; Fri, 20 Mar 2026 21:19:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1774041580; cv=none; d=zohomail.com; s=zohoarc; b=aaGoaHjUhMxHWMRhSnCTwGTZXHSkaWmeBtppZjPj2JcgBIqOAPCmy6+Ch+DNGSdpHw/HEqWKTnOXHFN0yh+D8Ld1La3UFBPd/+b9tEJCPkWJY+EPw7FzsPoJw+uezZ9nwm1K4DJLm+QoT44nuI1OdYVeWj6s9/73R0cWYedWKLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774041580; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=SrfGOzwOsuPkIZyE7B3D3aXPgdDWl5kgcEWkFVxwrEQ=; b=WUeqECfRzS/V0D5qyT6CYMLhZ6qeL7qDctB9bOzLW7fJdCm0f2YkEGF+Koa3DCsDnMslEFA1T4/9JAoDpuFlOKCTFkMQpm+6BcMziPKnkFHroqbYB93If4E2S2UvzVb3OLQyCQK84TGZH/63TQ45SaDj6GwuBBKNoEZSpwBkg0A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1774041580; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-Id:Reply-To; bh=SrfGOzwOsuPkIZyE7B3D3aXPgdDWl5kgcEWkFVxwrEQ=; b=bYC0V5FNA3b8oq4/6TtvmOMNoFX1Qkx3hdVgBKMZrUNsNsc/QXLZtRr5feqWtF+4 Ln2rpjk1p+8rxFbq3x+7daytFmV1/HG8F2775AQpApDYmoNNQlWc1ekUJTEuSrqSocB qvciEUtRbNaQ5AOReCHvGvxH4jAhdfYuddHmVQiI= Received: by mx.zohomail.com with SMTPS id 1774041578365880.9401943068087; Fri, 20 Mar 2026 14:19:38 -0700 (PDT) Date: Fri, 20 Mar 2026 21:19:31 +0000 From: =?utf-8?Q?Adri=C3=A1n?= Larumbe To: Biju Cc: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Biju Das , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 2/4] drm/panfrost: Drop redundant optional clock checks in runtime PM Message-ID: References: <20260320164158.487406-1-biju.das.jz@bp.renesas.com> <20260320164158.487406-3-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260320164158.487406-3-biju.das.jz@bp.renesas.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Biju, On 20.03.2026 16:41, Biju wrote: > From: Biju Das > > The clk_enable() and clk_disable() APIs already handle NULL clock pointers > gracefully — clk_enable() returns 0 and clk_disable() returns immediately > when passed a NULL or optional clock. The explicit if (pfdev->bus_clock) > guards around these calls in the runtime suspend/resume paths are > therefore unnecessary. Remove them to simplify the code. > > Reviewed-by: Steven Price > Signed-off-by: Biju Das > --- > v1->v2: > * Collected tag > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > index dedc13e56631..01e702a0b2f0 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > @@ -429,11 +429,9 @@ static int panfrost_device_runtime_resume(struct device *dev) > if (ret) > goto err_clk; > > - if (pfdev->bus_clock) { > - ret = clk_enable(pfdev->bus_clock); > - if (ret) > - goto err_bus_clk; > - } > + ret = clk_enable(pfdev->bus_clock); > + if (ret) > + goto err_bus_clk; > } It seems clk_prepare_enable() can also deal with NULL clock device pointers gracefully, so maybe you could also do away with pointer checks in panfrost_clk_init? Other than that, Reviewed-by: Adrián Larumbe > panfrost_device_reset(pfdev, true); > @@ -464,9 +462,7 @@ static int panfrost_device_runtime_suspend(struct device *dev) > panfrost_gpu_power_off(pfdev); > > if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) { > - if (pfdev->bus_clock) > - clk_disable(pfdev->bus_clock); > - > + clk_disable(pfdev->bus_clock); > clk_disable(pfdev->clock); > reset_control_assert(pfdev->rstc); > } > -- > 2.43.0 Adrian Larumbe