From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE01BC433EF for ; Tue, 9 Nov 2021 18:15:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC1376103B for ; Tue, 9 Nov 2021 18:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC1376103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5E5A78393F; Tue, 9 Nov 2021 19:15:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="OD9IDUj7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CCAC583944; Tue, 9 Nov 2021 19:15:18 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E4B51836A6 for ; Tue, 9 Nov 2021 19:15:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1162F3F1AD for ; Tue, 9 Nov 2021 18:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636481712; bh=g3+iJU2yD4/pSUSUorDALAS5UaBLMfEusZ13qXYx2QA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OD9IDUj7v0IvIW37ozor7PX8pbF+OCOe9Z70SgmBpaboWIqvpi5h/vmeRkHNfKq26 BZfsWow8uLSUvF2CvugZSl8gFRoOWc3Mhd9B+yGvMmwlpcrNpJVxfBQ/4l7BF0/kxn S5C+NEYMJfIdDm8E2KWFR0OTx14mqD6Tqb4w6wO+LkAXYzVXv6KZtCdOGsVvU90TGN VJZm798vrcu7D4ksxcwpwmxALpaXSWJVk1sm3Wgt5JPWVgIOkfBfJf6TK31FQuldyx 2vr+osp6TuSKLUgoPyANoLz/abuE3yu3JrS5vCB+XxTjKlHTjB7SsMvN6gBi2UhWUS 5pOQqaom8ungg== Received: by mail-wr1-f69.google.com with SMTP id f3-20020a5d50c3000000b00183ce1379feso5002021wrt.5 for ; Tue, 09 Nov 2021 10:15:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=g3+iJU2yD4/pSUSUorDALAS5UaBLMfEusZ13qXYx2QA=; b=zEKfQGX1UEKd25pGWcq969BJihjXutgn+A2FvgF2dpTksIUJgdQSjJIaF1iEzo+1JI ndC0ztecE4L4D5oOrXOE2euUnTyamcDoYTCLSj4wHPS+LPSDlg6jLNZOaiTUFefucWiz m1er7C95QQq1oV59Cd/O/Y4rHORmN4oQZXMsWZRAtq9PKPgwq1TxYebT3OBVhudaHsTv mTo115fMbETnJPtbVfq+sIqK//91Uc2BffDf4MvzrJFvinfld//ej81Uk9GpVdIW8AJt P33PvCM5j7suCwDv/41FWuoe81arMk7OWoIqmwCpoyfhqaq0m7FfUVt1yUJ9jWn3qvpb aynw== X-Gm-Message-State: AOAM530nLjOxqTMFUz2LMzRXdMr4tf+TkuADAw7wwVJTDcUalDlnYz2p gpRSHQzi7RsEBhjY9pRlEHyUzbTiPrjmV5uZkwgD/uhpcYQvStxg/J7P9i5J4KFV8GzhsOUoLTG 9Dcltvjxk5LiS3rJDe6/8jGuX+rJETH4= X-Received: by 2002:a05:600c:a08:: with SMTP id z8mr9751207wmp.52.1636481711756; Tue, 09 Nov 2021 10:15:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpIQ+FcZjP8+8QYvZBwKS7iZEgUdCKuGvtqOd/2uh843JIi4+mk2HyAhMMqLDSD1sJ8aE1Xg== X-Received: by 2002:a05:600c:a08:: with SMTP id z8mr9751178wmp.52.1636481711553; Tue, 09 Nov 2021 10:15:11 -0800 (PST) Received: from [192.168.123.55] (ip-88-152-144-157.hsi03.unitymediagroup.de. [88.152.144.157]) by smtp.gmail.com with ESMTPSA id a4sm3041505wmg.10.2021.11.09.10.15.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 10:15:11 -0800 (PST) Message-ID: Date: Tue, 9 Nov 2021 19:15:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices() Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de, Andre Przywara , Heinrich Schuchardt , Alexander Graf References: <20211109101901.24015-1-heinrich.schuchardt@canonical.com> <20211109101901.24015-2-heinrich.schuchardt@canonical.com> <20211109175526.GW24579@bill-the-cat> From: Heinrich Schuchardt In-Reply-To: <20211109175526.GW24579@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11/9/21 18:55, Tom Rini wrote: > On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: > >> The UEFI specification requires for ExitBootServices() that "the boot >> services watchdog timer is disabled". We already disable the software >> watchdog. We should additionally disable the hardware watchdogs. >> >> Reported-by: Andre Przywara >> Signed-off-by: Heinrich Schuchardt > > Let me start by saying thank you for bringing this up with UEFI folks as > well. To be clear, for right now I would much rather see U-Boot > continue to be non-complaint with UEFI in this regard and assume that a > running watchdog will be able to be handled by the running OS (which > tends to be the case, but not always as sunxi has just shown) than to > attempt to be complaint with the spec as it stands now as I am hopeful > that we can get this case handled in a way that matches long standing > industry practice. > We have either merge this patch or [1/1] watchdog: don't autostart watchdog on Sunxi boards https://patchwork.ozlabs.org/project/uboot/patch/20211105183431.117221-1-heinrich.schuchardt@canonical.com/ or we will be breaking boot processes that have been running up to now. As Sunxi watchdogs were only enabled by a recent patch disabling autostart should not cause any harm. If you want to be able to deviate from the UEFI spec, this should be customizable and disabled by default. Best regards Heinrich