All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/7] drm/i915/pmu: Add running counter
Date: Mon, 9 Apr 2018 10:13:42 +0100	[thread overview]
Message-ID: <ab4bc169-1fb6-4d72-34e5-b5a7f76e0d70@linux.intel.com> (raw)
In-Reply-To: <152304625845.23749.17252860421999973083@mail.alporthouse.com>


On 06/04/2018 21:24, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-04-05 13:39:22)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> We add a PMU counter to expose the number of requests currently executing
>> on the GPU.
>>
>> This is useful to analyze the overall load of the system.
>>
>> v2:
>>   * Rebase.
>>   * Drop floating point constant. (Chris Wilson)
>>
>> v3:
>>   * Change scale to 1024 for faster arithmetics. (Chris Wilson)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Do we want these separate in the final push? Is there value in reverting
> one but not the others? They seem a triumvirate.

I think the only benefit to have them separate for me was that rebasing 
was marginally easier. I can just as well squash them if that is preferred.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-04-09  9:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 12:39 [PATCH v5 0/7] Queued/runnable/running engine stats Tvrtko Ursulin
2018-04-05 12:39 ` [PATCH 1/7] drm/i915/pmu: Fix enable count array size and bounds checking Tvrtko Ursulin
2018-04-05 12:39 ` [PATCH 2/7] drm/i915: Keep a count of requests waiting for a slot on GPU Tvrtko Ursulin
2018-04-06 20:16   ` Chris Wilson
2018-04-09 16:37   ` [PATCH v10 " Tvrtko Ursulin
2018-04-05 12:39 ` [PATCH 3/7] drm/i915: Keep a count of requests submitted from userspace Tvrtko Ursulin
2018-04-06 20:17   ` Chris Wilson
2018-04-09  9:11     ` Tvrtko Ursulin
2018-04-09  9:25       ` Chris Wilson
2018-04-09 10:17         ` Tvrtko Ursulin
2018-04-09 10:27           ` Chris Wilson
2018-04-09 10:29             ` Chris Wilson
2018-04-09 10:40             ` Tvrtko Ursulin
2018-04-09 10:51               ` Chris Wilson
2018-04-09 11:43                 ` Tvrtko Ursulin
2018-04-09 11:54                   ` Chris Wilson
2018-04-09 16:38   ` [PATCH v4 " Tvrtko Ursulin
2018-04-05 12:39 ` [PATCH 4/7] drm/i915/pmu: Add queued counter Tvrtko Ursulin
2018-04-06 20:19   ` Chris Wilson
2018-04-05 12:39 ` [PATCH 5/7] drm/i915/pmu: Add runnable counter Tvrtko Ursulin
2018-04-06 20:22   ` Chris Wilson
2018-04-05 12:39 ` [PATCH 6/7] drm/i915/pmu: Add running counter Tvrtko Ursulin
2018-04-06 20:24   ` Chris Wilson
2018-04-09  9:13     ` Tvrtko Ursulin [this message]
2018-04-05 12:39 ` [PATCH 7/7] drm/i915: Engine queues query Tvrtko Ursulin
2018-04-05 13:05   ` Lionel Landwerlin
2018-04-06 20:25     ` Chris Wilson
2018-04-09 16:38   ` [PATCH v3 " Tvrtko Ursulin
2018-04-05 13:49 ` ✓ Fi.CI.BAT: success for Queued/runnable/running engine stats (rev4) Patchwork
2018-04-05 16:08 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-04-09 17:12 ` ✗ Fi.CI.BAT: failure for Queued/runnable/running engine stats (rev7) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2018-06-06 12:48 [PATCH v6 0/7] Queued/runnable/running engine stats Tvrtko Ursulin
2018-06-06 12:48 ` [PATCH 6/7] drm/i915/pmu: Add running counter Tvrtko Ursulin
2018-06-06 14:40   ` Tvrtko Ursulin
2018-06-06 15:23     ` Chris Wilson
2018-06-06 15:52       ` Tvrtko Ursulin
2018-06-07 13:25     ` Tvrtko Ursulin
2018-06-07 14:45       ` Chris Wilson
2018-03-19 18:16 [PATCH v4 0/7] Queued/runnable/running engine stats Tvrtko Ursulin
2018-03-19 18:16 ` [PATCH 6/7] drm/i915/pmu: Add running counter Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab4bc169-1fb6-4d72-34e5-b5a7f76e0d70@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.