From: Bryan O'Donoghue <bod@kernel.org>
To: "Erikas Bitovtas" <xerikasxx@gmail.com>,
"Vikash Garodia" <vikash.garodia@oss.qualcomm.com>,
"Dikshita Agarwal" <dikshita.agarwal@oss.qualcomm.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney@redhat.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v7 5/8] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
Date: Fri, 15 May 2026 11:00:27 +0100 [thread overview]
Message-ID: <ab53da53-6ac9-472d-990c-2b1c1a24b5cd@kernel.org> (raw)
In-Reply-To: <20260514-msm8939-venus-rfc-v7-5-33c6c6fb9285@gmail.com>
On 13/05/2026 22:24, Erikas Bitovtas wrote:
> Since in downstream kernel VENUS_CORE0_GDSC and VENUS_CORE1_GDSC have a
> device tree property "qcom,supports-hw-trigger", add a HW_CTRL_TRIGGER
> flag to these GDSCs to indicate that their control can be passed to
> hardware.
>
> Signed-off-by: Erikas Bitovtas<xerikasxx@gmail.com>
> ---
I'm going to push back on this wording.
Take ownership of the proposed solution. "Do what downstream does" is
cargo-cultism. You have spotted a flag in downstream and tested your
code with/without the change, clearly demonstrating that HW_CTRL_TRIGGER
is required.
Downstream is irrelevant. Your testing and imprimatur are all that is
relevant to the commit log.
Please fix.
---
bod
next prev parent reply other threads:[~2026-05-15 10:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DNbx21zMg31pkwSpiMB9_CkOmf_zlDEkQXoUA-a8l2NewLmiwCe1HyivIJV1oKaYtXo6gTR7qvePk9rqflNU7Q==@protonmail.internalid>
2026-05-13 21:24 ` [PATCH v7 0/8] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-13 21:24 ` [PATCH v7 1/8] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
2026-05-14 6:33 ` Krzysztof Kozlowski
2026-05-15 9:51 ` Bryan O'Donoghue
2026-05-13 21:24 ` [PATCH v7 2/8] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
2026-05-13 21:24 ` [PATCH v7 3/8] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas
2026-05-13 21:24 ` [PATCH v7 4/8] arm64: dts: qcom: msm8939-asus-z00t: add Venus Erikas Bitovtas
2026-05-13 21:24 ` [PATCH v7 5/8] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
2026-05-14 12:30 ` sashiko-bot
2026-05-15 10:00 ` Bryan O'Donoghue [this message]
2026-05-13 21:24 ` [PATCH v7 6/8] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
2026-05-14 12:56 ` sashiko-bot
2026-05-15 10:03 ` Bryan O'Donoghue
2026-05-13 21:24 ` [PATCH v7 7/8] media: qcom: venus: add codec blacklist mechanism Erikas Bitovtas
2026-05-15 10:12 ` Bryan O'Donoghue
2026-05-13 21:24 ` [PATCH v7 8/8] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
2026-05-15 9:53 ` [PATCH v7 0/8] media: qcom: venus: add MSM8939 support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab53da53-6ac9-472d-990c-2b1c1a24b5cd@kernel.org \
--to=bod@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=git@apitzsch.eu \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.