From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC30CF4F1 for ; Sat, 6 Sep 2025 14:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757168351; cv=none; b=OG/ZCXcGX2IBIhOTNxxbp+7MacLEplGEFi+SfcPj3gCgJWuPbvBGK94eoXndvmlHWkF5gmAXuJeUfOGzLCNxgQkVtFAs8O3ECcMem3W72GOw8zoSroO7OJJaFMliQXDTgee4109zBZVBP0Fu6q7g2A+HicLB4czBt3vtSV3+XF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757168351; c=relaxed/simple; bh=DhsWzRd/y1W9ugFZAexJhGqlHORUB2SvMNRdbrGUs3U=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=M256JB39Bq5981FU25hKUHtxoGr5PJO0UOsBruY2aHzE4ZDTc1lgHfCPi7KlPIoDliVqIWcCv81+vLXX+fMlFuUuvxXSb1TTHoiHZJCQirhAf1XicBjAYyHggRjI2jCBdg9esb6U8IznzhB398ZzpSLSyXnWskrNFXJYOuLIfKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TZONr0oU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TZONr0oU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED02FC4CEE7; Sat, 6 Sep 2025 14:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757168350; bh=DhsWzRd/y1W9ugFZAexJhGqlHORUB2SvMNRdbrGUs3U=; h=Subject:From:To:Date:In-Reply-To:References:From; b=TZONr0oUWDB6jTNB188gLt7c7FDa6Nts31uR5eUYHlQcqPZnGLvzbMMMJw9oIGG0e fTZr7ZPd42o5NbMnGbMy+LO1UoJizv1UGp+R5xBA8NTG37x/4d2O1sJWkXKhbKoQuT p2QKv/3TIwE0cxV4El56Vu7ZFJmcLxnKxjmKKTjhbfmGtjWg6Zc59U0njMJyQQfn9t VUht5GvDVcNW8LWejJlzsY5pXCv3fL9KITn/PNkLYyrrqTB8ObgZivinc2g7AiLk3B 9LV/HQCBiaVvE9PT9zTJ2AVcXl8tFfJAEg7af/YHmRfJRU2MJ4j5EJzw3XwVam74Kg yc9Pj1bz9nPLQ== Message-ID: Subject: Re: [PATCH mptcp-net 4/7] netlink: specs: mptcp: fix if-idx attribute type From: Geliang Tang To: "Matthieu Baerts (NGI0)" , mptcp@lists.linux.dev Date: Sat, 06 Sep 2025 22:19:08 +0800 In-Reply-To: <20250829-mptcp-pm-user-c-flag-v1-4-78b25dda7708@kernel.org> References: <20250829-mptcp-pm-user-c-flag-v1-0-78b25dda7708@kernel.org> <20250829-mptcp-pm-user-c-flag-v1-4-78b25dda7708@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.56.0-1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Matt, On Fri, 2025-08-29 at 22:33 +0200, Matthieu Baerts (NGI0) wrote: > This attribute is used as a signed number in the code in > pm_netlink.c: > >   nla_put_s32(skb, MPTCP_ATTR_IF_IDX, ssk->sk_bound_dev_if)) > > The specs should then reflect that. Note that other 'if-idx' > attributes > from the same .yaml file use a signed number as well. > > Fixes: bc8aeb2045e2 ("Documentation: netlink: add a YAML spec for > mptcp") > Signed-off-by: Matthieu Baerts (NGI0) Patches 4-6 LGTM! Reviewed-by: Geliang Tang [mptcp-net,4/7] netlink: specs: mptcp: fix if-idx attribute type [mptcp-net,5/7] doc: mptcp: net.mptcp.pm_type is deprecated [mptcp-net,6/7] selftests: mptcp: shellcheck: support v0.11.0 These three patches are relatively independent and can be removed from this series. They should be merged into the export branch first and do not need to be included in the v2 iteration. I changed the states of them as "Queued". WDYT? Thanks, -Geliang > --- >  Documentation/netlink/specs/mptcp_pm.yaml | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/netlink/specs/mptcp_pm.yaml > b/Documentation/netlink/specs/mptcp_pm.yaml > index > 02f1ddcfbf1cfd81a398dd03c52bb9f281c1aa08..d15335684ec3d6256505f2b3887 > ce5818eb57462 100644 > --- a/Documentation/netlink/specs/mptcp_pm.yaml > +++ b/Documentation/netlink/specs/mptcp_pm.yaml > @@ -256,7 +256,7 @@ attribute-sets: >          type: u32 >        - >          name: if-idx > -        type: u32 > +        type: s32 >        - >          name: reset-reason >          type: u32