From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06F54E6FE49 for ; Sun, 8 Sep 2024 09:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:Subject:References:Cc: To:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6I0PGXFcJtv17L4hw4+ULLUrMUjXMTD+t8C83lI4Y/w=; b=yR7HBzJfE5J5/e GwhHuGP3ypA+Bnkgv30mPgATyVhwTaLyyIYmnUNx3IhRorIxdAJIPPGT1tlztlC3AUel4A8b3McIb +lU/dQWf4aUYvh5vFzLyTV+VUblQpcn4+VA96Nb3+k5ECt4HryuS15Tk3d4GBXOIovbmqacY2zfwB MdrZ3pXr+s3Yu1QV170G29hzjju8QbObSBh8oS6AO2ZyMxFet7Cr9yZ1Rmc+CEvxszW+aIaiC/FnT CllSju2hBzYaJgHOXybZ9ph2GJkJE5XlXwEsyYULlwD6ocW655kzWaxz7qa/RSM3UOGwTvRi1rEOE 8mshJryuvO9Rk/RnfvJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snE0U-0000000GTIo-2u3C; Sun, 08 Sep 2024 09:14:54 +0000 Received: from mout.web.de ([212.227.17.11]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snDy8-0000000GSl4-1csw; Sun, 08 Sep 2024 09:12:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1725786702; x=1726391502; i=markus.elfring@web.de; bh=WCMJWEieh/sXV2CRivFT84rsK/t+kM3zpH1slTwVITk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=GCj7k49Tx/Lbx9BOMox0uWwLn5BevksJ8proerqSJxEF6ETIuNFBL1hyXbXX+ouh aQbtsnnttRHBarnvr0TNcVdsl0CAgCFLdNlNKHIiwlawR0yur6FWW08S2rKrjhnde JAnPiL661yKYygz6Rn/Xst4cVb4suSX1FzZSTlTGf8/ZDsS6CwUIjDOKaqi/38WUl BcyiqCI+BTCiOmjEa509/AHQmp1ZqUgu7tLtyZfyiSGexn5XPhff1Za5+2TZdZvlP yWmmcdsiBWlsOBGjuVOZxKJ4LoW+Ww2hc0uDsv0HcJ6ovt0nKiDRUO70v30iL9Tif StwdfmPS1INWbIgq/Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.80.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mf3uS-1s87a02mnC-00mEdG; Sun, 08 Sep 2024 11:11:42 +0200 Message-ID: Date: Sun, 8 Sep 2024 11:11:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Algea Cao , Cristian Ciocaltea , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, Andrzej Hajda , Andy Yan , Conor Dooley , Daniel Vetter , David Airlie , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Mark Yao , Maxime Ripard , Neil Armstrong , Rob Herring , Robert Foss , Sandy Huang , Sascha Hauer , Thomas Zimmermann Cc: LKML , Alexandre Arnoud , Luis de Arquer References: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com> Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com> X-Provags-ID: V03:K1:PJluZpNkDXlZ3wkBX5/Gqh/OwUEU3EH/o63oMUDBKTJGS5rOy8l tLwTiwnKIsd0JwYJGqrZj40eP3l+rSCYh1XNNEcr3iyt0ouyCKinmqYbQhMRzBCstjxX4Hh CodzD4RfYB1DsHm1q1+vztQUEr8oK+KWPwJUzVHsCsEsRCcFyiq22MOdN8/XyNoeqbCxw09 /7R1YQdoLWnNnrbOautug== UI-OutboundReport: notjunk:1;M01:P0:RoHr7exywYI=;VDzCZb0+H1eula7sqILN1mFZDuw rzBqr//2R5GEMKkyiriv5zyZqUaS4/00MPyIZtZaMkHm+a2lDmymIwCLE2DbX2qd+5tBczgE8 0BXJ1VpSKZhFwLLld6/yzGqWvmZ0wI5KGRTqyLd+AEcgn2aCEYePFeb51ACMkJFA3isHDBCzF pZG+jq8WWdMFEHop9PPBy/bQRzHqrXdMAjpIkzsPfSRg72vwQM0xQjItM1ePNPde0jbH/oDTd LflTRZxkbj4lZ0jc7tljIUwoPZOA4bRWPSEgXTubzuH3O9cLmN7TqBkP8Ar77kdnfBm3fdx5r WIE+uHxOq+DhETnKm4fFrlEPWtz1uvQ/K6a2t3LtvKM59ifQJZaQONxH3rSUS3sVSnt7/T6FS ldO0wJ0IhAlhP1ziHsqmmz8bv4laJ2jb/s42l0icSfIKr6rxc73SHfLy1pxFiRbknZjDXWIlg a2Lzdd0KP07/Rgq/E4/VFXCc2HgM6jEsTlvYxDZNXZZXuyECOetT/Ut9ms8Iatvi/vYAl6Dja y5BAqbzCh+clapxDa8Ek62E6cD6CK4e8u40h8L94gdIDrPBj7zfELurEC03KupzyMn2PTDae0 6GSATlihwoboef7AvG1ExMmOYjBMkfK3uwscUD+u8037oMEMY0iWpOuQie20EswoN9rPzp5lz 5Qjglihp0gwyi51kRHGbHoLX2tViqVCmwZ/agCygCpaU7O3KAXJoYZUrCZ3GL3PLBGMaUVogh ho8PJXJBeZGS8ltsLuAepk+W0+zRMaAxebaZsrjmcYx89pRbpRnVjmmeeoINdELpxtnpZX4Uo 1yk6rGl8IIOCh1xgQ01u+2Sw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240908_021228_730436_B1D1166A X-CRM114-Status: UNSURE ( 5.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org 4oCmCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1pLXFwLmMK PiBAQCAtMCwwICsxLDcwOCBAQArigKYKPiArc3RhdGljIGludCBkd19oZG1pX3FwX2kyY194ZmVy KHN0cnVjdCBpMmNfYWRhcHRlciAqYWRhcCwKPiArCQkJICAgICAgIHN0cnVjdCBpMmNfbXNnICpt c2dzLCBpbnQgbnVtKQo+ICt7CuKApgo+ICsJbXV0ZXhfbG9jaygmaTJjLT5sb2NrKTsK4oCmCj4g Kwlkd19oZG1pX3FwX21vZChoZG1pLCAwLCBJMkNNX09QX0RPTkVfTUFTS19OIHwgSTJDTV9OQUNL X1JDVkRfTUFTS19OLAo+ICsJCSAgICAgICBNQUlOVU5JVF8xX0lOVF9NQVNLX04pOwo+ICsKPiAr CW11dGV4X3VubG9jaygmaTJjLT5sb2NrKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9CuKApgoK VW5kZXIgd2hpY2ggY2lyY3Vtc3RhbmNlcyB3b3VsZCB5b3UgYmVjb21lIGludGVyZXN0ZWQgdG8g YXBwbHkgYSBzdGF0ZW1lbnQKbGlrZSDigJxndWFyZChtdXRleCkoJmkyYy0+bG9jayk74oCdPwpo dHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC92Ni4xMS1yYzYvc291cmNlL2luY2x1ZGUv bGludXgvbXV0ZXguaCNMMTk2CgpSZWdhcmRzLApNYXJrdXMKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApM aW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0E10E6FE49 for ; Sun, 8 Sep 2024 09:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:Subject:References:Cc:To:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WCMJWEieh/sXV2CRivFT84rsK/t+kM3zpH1slTwVITk=; b=bFdbtgHSFS6YD+IPFxrtFD3Eh4 aG2Y7JcGuJw/vgk+c+YxG3RW6q7H3kP8NXEaLH4Azwf85/O+ZQYtrskKOcEnWVL7znFILu4jNnHhO yJXMabUHDihjaxR2/C0DKuMo8PApa+bva8OQZafmri4Jxun0iRMY34xwGttFsuvCYynsOOZ1xnoB7 yemL6o5QygeHRtT+yfKAWs6UqunW3rQ4ppcVOZyKYGbjMkhBqQiZVbCB0vahTBiNaNKKyrRiSZY/9 Z5TSgU619MKs8ppKMwnW327zzoXvyQHh8ukoXrMNLK6plXKntnCwNI0FhQCw+I7l04P3FDXoNLaES 8mqy4DRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snE0T-0000000GTIJ-2mEw; Sun, 08 Sep 2024 09:14:53 +0000 Received: from mout.web.de ([212.227.17.11]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snDy8-0000000GSl4-1csw; Sun, 08 Sep 2024 09:12:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1725786702; x=1726391502; i=markus.elfring@web.de; bh=WCMJWEieh/sXV2CRivFT84rsK/t+kM3zpH1slTwVITk=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=GCj7k49Tx/Lbx9BOMox0uWwLn5BevksJ8proerqSJxEF6ETIuNFBL1hyXbXX+ouh aQbtsnnttRHBarnvr0TNcVdsl0CAgCFLdNlNKHIiwlawR0yur6FWW08S2rKrjhnde JAnPiL661yKYygz6Rn/Xst4cVb4suSX1FzZSTlTGf8/ZDsS6CwUIjDOKaqi/38WUl BcyiqCI+BTCiOmjEa509/AHQmp1ZqUgu7tLtyZfyiSGexn5XPhff1Za5+2TZdZvlP yWmmcdsiBWlsOBGjuVOZxKJ4LoW+Ww2hc0uDsv0HcJ6ovt0nKiDRUO70v30iL9Tif StwdfmPS1INWbIgq/Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.80.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mf3uS-1s87a02mnC-00mEdG; Sun, 08 Sep 2024 11:11:42 +0200 Message-ID: Date: Sun, 8 Sep 2024 11:11:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Algea Cao , Cristian Ciocaltea , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, Andrzej Hajda , Andy Yan , Conor Dooley , Daniel Vetter , David Airlie , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Mark Yao , Maxime Ripard , Neil Armstrong , Rob Herring , Robert Foss , Sandy Huang , Sascha Hauer , Thomas Zimmermann Cc: LKML , Alexandre Arnoud , Luis de Arquer References: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com> Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:PJluZpNkDXlZ3wkBX5/Gqh/OwUEU3EH/o63oMUDBKTJGS5rOy8l tLwTiwnKIsd0JwYJGqrZj40eP3l+rSCYh1XNNEcr3iyt0ouyCKinmqYbQhMRzBCstjxX4Hh CodzD4RfYB1DsHm1q1+vztQUEr8oK+KWPwJUzVHsCsEsRCcFyiq22MOdN8/XyNoeqbCxw09 /7R1YQdoLWnNnrbOautug== UI-OutboundReport: notjunk:1;M01:P0:RoHr7exywYI=;VDzCZb0+H1eula7sqILN1mFZDuw rzBqr//2R5GEMKkyiriv5zyZqUaS4/00MPyIZtZaMkHm+a2lDmymIwCLE2DbX2qd+5tBczgE8 0BXJ1VpSKZhFwLLld6/yzGqWvmZ0wI5KGRTqyLd+AEcgn2aCEYePFeb51ACMkJFA3isHDBCzF pZG+jq8WWdMFEHop9PPBy/bQRzHqrXdMAjpIkzsPfSRg72vwQM0xQjItM1ePNPde0jbH/oDTd LflTRZxkbj4lZ0jc7tljIUwoPZOA4bRWPSEgXTubzuH3O9cLmN7TqBkP8Ar77kdnfBm3fdx5r WIE+uHxOq+DhETnKm4fFrlEPWtz1uvQ/K6a2t3LtvKM59ifQJZaQONxH3rSUS3sVSnt7/T6FS ldO0wJ0IhAlhP1ziHsqmmz8bv4laJ2jb/s42l0icSfIKr6rxc73SHfLy1pxFiRbknZjDXWIlg a2Lzdd0KP07/Rgq/E4/VFXCc2HgM6jEsTlvYxDZNXZZXuyECOetT/Ut9ms8Iatvi/vYAl6Dja y5BAqbzCh+clapxDa8Ek62E6cD6CK4e8u40h8L94gdIDrPBj7zfELurEC03KupzyMn2PTDae0 6GSATlihwoboef7AvG1ExMmOYjBMkfK3uwscUD+u8037oMEMY0iWpOuQie20EswoN9rPzp5lz 5Qjglihp0gwyi51kRHGbHoLX2tViqVCmwZ/agCygCpaU7O3KAXJoYZUrCZ3GL3PLBGMaUVogh ho8PJXJBeZGS8ltsLuAepk+W0+zRMaAxebaZsrjmcYx89pRbpRnVjmmeeoINdELpxtnpZX4Uo 1yk6rGl8IIOCh1xgQ01u+2Sw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240908_021228_730436_B1D1166A X-CRM114-Status: UNSURE ( 5.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org =E2=80=A6 > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c > @@ -0,0 +1,708 @@ =E2=80=A6 > +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap, > + struct i2c_msg *msgs, int num) > +{ =E2=80=A6 > + mutex_lock(&i2c->lock); =E2=80=A6 > + dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N, > + MAINUNIT_1_INT_MASK_N); > + > + mutex_unlock(&i2c->lock); > + > + return ret; > +} =E2=80=A6 Under which circumstances would you become interested to apply a statement like =E2=80=9Cguard(mutex)(&i2c->lock);=E2=80=9D? https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L1= 96 Regards, Markus