From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C895C282EC for ; Mon, 17 Mar 2025 13:53:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tuAtY-0005dk-Fo; Mon, 17 Mar 2025 09:52:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuAtN-0005c7-OZ for qemu-devel@nongnu.org; Mon, 17 Mar 2025 09:52:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuAtK-0002Eq-O6 for qemu-devel@nongnu.org; Mon, 17 Mar 2025 09:52:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742219549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T6T8xZZNeuei7oarzd8J4fEsPYV1+S7tz80DZvtRAPM=; b=gTwxHW56I8fgFUjLvvS5wlTD3K7/pO+tE9h8607Uv2GEamBaX9vL30GUDlEeoMiIRC7s5N 0BGcZLqvFuP/YSQBwvB/nIdXG+Z8F0JFHPxi1ZhyGhkzm4lbugxcCOkuUgcGDNkN66I8kd qQrgyYgfb9YuqLxwAM4v2Axg3uLl3ZE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-UI6h6vh1NtSmWk-q1qVScA-1; Mon, 17 Mar 2025 09:52:26 -0400 X-MC-Unique: UI6h6vh1NtSmWk-q1qVScA-1 X-Mimecast-MFC-AGG-ID: UI6h6vh1NtSmWk-q1qVScA_1742219545 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so16312235e9.1 for ; Mon, 17 Mar 2025 06:52:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742219545; x=1742824345; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T6T8xZZNeuei7oarzd8J4fEsPYV1+S7tz80DZvtRAPM=; b=RTy9Hz0D867xp4N3nJjGtvryo6h06Afr08JlqVgShR2NyHM/SczSvYhC7evx2EW02c C6DQJ5fTw1hNj+vuCm49qjNuI+e5jtiaO83sDPtQoHlkWiI5E2e5nhG+J+leKpCGoTav rFdJXoPe6u2yqJvgemT7/mJUi+ExGqskusOIqLVdFjh/CmQfIr9VLgfYDY1dO9b0Ce+S tb6qtJ5qw5BmNcvj73ewN1C41PvmbH0yFquizlJ6MDy+pYSRAdLUUix5BjlZ4OZv6FYN vPdQ5Eh3itHqNOaxsWtE5D9SzFgL6Al+61O0KU+YOvHgY5epi3sBG6s5RpuXoodTip9L YyPg== X-Forwarded-Encrypted: i=1; AJvYcCUqiIqGIZqy31BQXskT38/5l6KNvleVRaLj3iPfWIZ2NxBa/pa2VuszJIqlL5U6rrdP8NUxdBIKdDLH@nongnu.org X-Gm-Message-State: AOJu0YzXmWrbOjYr3cWAVL2nHgLktduv9bjpQVgu5+5E7kjbD+voulFx V3M6e4/dhvmk1zx2ouDJobhT4eBbv21TsccohZehNS+5T6dBGc4OHgc7DBMpBWKhE0QdKK9nMkl EBZnfPrBsxNM3w0peH1JXZXmRcfaRymepg1LnsEpAc9ethAXbRkjw X-Gm-Gg: ASbGnct/wgh7a5CzbntdOU8qH3MiKMOaXUxyNea225nG3dTrKnQpHT4SeL+41q66VKw 0FdKrS9ztvHgeJp7hHffo/Z4Dk+2oVGur434pBqQRGyQc93POuUu+1XRSEj8jtP+VkOOMx63NiA w/K2779sF8sPcAJa0hPC2JKQaC7RKoY6QadZozTURUTnuOvZPhxsGyS0SEwdmA0/w9lBZwFDPoR +5cu1oREwSktKv5uk4BWDrFfhzW34akdHx8rPdYNopdko9dQItkwA9GKBWh9jiUNHLZTEK+kuWs 5tUpamROpczUj4QvMcjXmXmIXJwhO/XW4h1cECq1eszBkV0= X-Received: by 2002:a05:600c:4f0d:b0:43d:42b:e186 with SMTP id 5b1f17b1804b1-43d1ec71e13mr115537615e9.8.1742219545301; Mon, 17 Mar 2025 06:52:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyIpwCQHMwZGeph3du+2HLp0CV5Fa4jD7TSR5NutrTJazjdQ6qAslJ1DtxEKhsARj+6nhXTw== X-Received: by 2002:a05:600c:4f0d:b0:43d:42b:e186 with SMTP id 5b1f17b1804b1-43d1ec71e13mr115537285e9.8.1742219544902; Mon, 17 Mar 2025 06:52:24 -0700 (PDT) Received: from [192.168.0.7] (ip-109-42-51-207.web.vodafone.de. [109.42.51.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1ffb629dsm106120725e9.3.2025.03.17.06.52.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Mar 2025 06:52:24 -0700 (PDT) Message-ID: Date: Mon, 17 Mar 2025 14:52:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] hw/s390x/ccw: Have CCW machine implement a qmp_dump_skeys() callback To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Richard Henderson , David Hildenbrand , Anton Johansson , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Marcel Apfelbaum , Zhao Liu , Christian Borntraeger , Ilya Leoshkevich , Eduardo Habkost , Yanan Wang , Pierrick Bouvier , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Eric Blake , "Dr. David Alan Gilbert" , Halil Pasic , Markus Armbruster , Eric Farman References: <20250310151414.11550-1-philmd@linaro.org> <20250310151414.11550-4-philmd@linaro.org> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250310151414.11550-4-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.335, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/03/2025 16.14, Philippe Mathieu-Daudé wrote: > In preparation to make @dump-skeys command generic, > extract s390_qmp_dump_skeys() out of qmp_dump_skeys(). > Register it as CCW qmp_dump_skeys() callback. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/s390x/storage-keys.h | 1 + > hw/s390x/s390-skeys.c | 7 ++++++- > hw/s390x/s390-virtio-ccw.c | 3 +++ > 3 files changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth