Re: [PATCH wireless-next v3 0/8] Adding NO_STA flag and reworking RX link resolution

[Ramasamy Kaliappan <ramasamy.kaliappan@oss.qualcomm.com>]

On 8/19/2026 7:27 PM, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@intel.com>
> 
> Hi,
> 
> This patchset refactors the RX link resolution a bit to fix some issues
> where mac80211 might accept frames on the wrong link and incorrectly
> translate the address. It also adds a new NL80211_ATTR_FRAME_CMD_NO_STA
> flag so that userspace can know whether address translation was done by
> the kernel on RX and can also prevent address translation for management
> frames during TX.
> 
> This together should be enough to fix the existing issues in hostapd
> where stations that are still associated try to authenticate again but
> hostapd for example ends up sending the frame to an old link address.
> 
> Benjamin
> 
> PS: Sorry, the last mail had various issues, so resending properly now.
> 
> v3:
>   * Fix issues found during review
> 
> v2:
>   * Remove unused variable in rtw89
> 
> Changes in v1:
>   * Add NAN_DATA interface handling
>   * Handle NO_STA flag correctly for NAN
>   * Fixed forwarding of station parameter
>   * Rebase and other small fixes
> 
> Changes in RFCv2:
>   * Port other drivers to new API (untested)
>   * Fix a checkpatch warning
> 
> Benjamin Berg (8):
>    wifi: iwlwifi: use link_sta internally to the driver
>    wifi: mac80211: change public RX API to use link stations
>    wifi: mac80211: refactor RX link_id and station handling
>    wifi: mac80211: rework RX packet handling
>    wifi: cfg80211: add attribute for TX/RX denoting there is no station
>    wifi: mac80211: report to cfg80211 when no STA is known for a frame
>    wifi: mac80211: pass station to ieee80211_tx_skb_tid
>    uwifi: mac80211: pass error station if non-STA transmit was requested
> 
>   drivers/net/wireless/ath/ath11k/dp_rx.c       |   2 +-
>   drivers/net/wireless/ath/ath12k/dp_mon.c      |   2 -
>   drivers/net/wireless/ath/ath12k/dp_rx.c       |  20 +-
>   drivers/net/wireless/ath/ath12k/hw.h          |  20 +-
>   drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c |  20 +-
>   drivers/net/wireless/ath/ath12k/wifi7/dp_rx.h |  12 +-
>   drivers/net/wireless/ath/ath12k/wifi7/hw.c    |   6 +-
>   drivers/net/wireless/ath/ath12k/wmi.c         |   6 -
>   drivers/net/wireless/intel/iwlwifi/mld/agg.c  |  17 +-
>   drivers/net/wireless/intel/iwlwifi/mld/agg.h  |   4 +-
>   drivers/net/wireless/intel/iwlwifi/mld/rx.c   |  50 +-
>   drivers/net/wireless/intel/iwlwifi/mld/rx.h   |   2 +-
>   .../wireless/intel/iwlwifi/mld/tests/agg.c    |   7 +-
>   drivers/net/wireless/intel/iwlwifi/mvm/rx.c   |   2 +-
>   drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c |   6 +-
>   drivers/net/wireless/mediatek/mt76/mac80211.c |  22 +-
>   drivers/net/wireless/realtek/rtw89/core.c     |   7 -
>   .../wireless/virtual/mac80211_hwsim_main.c    |   3 -
>   include/net/cfg80211.h                        |   4 +
>   include/net/mac80211.h                        |  25 +-
>   include/uapi/linux/nl80211.h                  |   7 +
>   net/mac80211/agg-tx.c                         |   4 +-
>   net/mac80211/ap.c                             |   3 -
>   net/mac80211/ht.c                             |   2 +-
>   net/mac80211/ieee80211_i.h                    |  11 +-
>   net/mac80211/iface.c                          |   7 +-
>   net/mac80211/mlme.c                           |  10 +-
>   net/mac80211/offchannel.c                     |  13 +-
>   net/mac80211/rx.c                             | 447 ++++++++++--------
>   net/mac80211/scan.c                           |  10 +-
>   net/mac80211/tdls.c                           |   2 +-
>   net/mac80211/tx.c                             |  10 +-
>   net/wireless/nl80211.c                        |   8 +-
>   33 files changed, 413 insertions(+), 358 deletions(-)
> 

The changes look good to me, no hwsim test cases failure.

Note: The hostapd changes posted in: [PATCH 0/6] hostapd: handle nl80211 
no_sta flag in management frames


Reviewed-by: Ramasamy Kaliappan <ramasamy.kaliappan@oss.qualcomm.com>