All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avnish Chouhan <avnish@linux.ibm.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: grub-devel@gnu.org, brking@linux.ibm.com, meghanaprakash@in.ibm.com
Subject: Re: [PATCH v2] ieee1275: support added for multiple nvme bootpaths
Date: Tue, 03 Jun 2025 11:33:20 +0530	[thread overview]
Message-ID: <ab9b5e6bd9bcc3a18e8e7cf033fa945b@linux.ibm.com> (raw)
In-Reply-To: <20250529162240.i66eevvrvtyv2qd7@tomti.i.net-space.pl>

Hi Daniel,

Yes, you are correct. I'll do the change as suggested.
Thank you!

Regards,
Avnish Chouhan

On 2025-05-29 21:52, Daniel Kiper wrote:
> Hi Avnish,
> 
> On Thu, May 29, 2025 at 11:59:27AM +0530, Avnish Chouhan wrote:
>> Hi Daniel,
>> 
>> I believe we need this change. We are using this function
>> "of_path_get_nvme_nsid" in the patch which is defined in other file, 
>> and
>> this "of_path_get_nvme_nsid" calls the function
>> "block_device_get_sysfs_path_and_link". If we don't define this in the
>> header file, we get this error below.
>> Thank you!
>> 
>> *****
>> 
>> In file included from grub-core/osdep/ofpath.c:2:
>> grub-core/osdep/linux/ofpath.c:228:1: error: no previous prototype for
>> ‘block_device_get_sysfs_path_and_link’ [-Werror=missing-prototypes]
>>   228 | block_device_get_sysfs_path_and_link(const char *devicenode)
>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> If you drop both changes then everything should be OK.
> 
> Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

      reply	other threads:[~2025-06-03  6:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 11:04 [PATCH v2] ieee1275: support added for multiple nvme bootpaths Avnish Chouhan
2025-05-26 19:30 ` Daniel Kiper
2025-05-28 11:20   ` Avnish Chouhan
2025-05-28 17:56     ` Daniel Kiper
2025-05-29  6:29       ` Avnish Chouhan
2025-05-29 16:22         ` Daniel Kiper
2025-06-03  6:03           ` Avnish Chouhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab9b5e6bd9bcc3a18e8e7cf033fa945b@linux.ibm.com \
    --to=avnish@linux.ibm.com \
    --cc=brking@linux.ibm.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=meghanaprakash@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.