Re: [PATCH] staging: atomisp: fix block comment style in refcount.c

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Mar 09, 2026 at 10:55:16PM +0100, Oskar Ray-Frayssinet wrote:
> Fix block comment formatting to comply with kernel coding style:
> - Add leading '*' on continuation lines
> - Move trailing '*/' to a separate line
> - Remove unnecessary braces around single statement block

Are they the only ones to fix in the entire driver?

...

>  /* TODO: enable for other memory aswell
> -	 now only for ia_css_ptr */
> + * now only for ia_css_ptr
> + */

/*
 * Please, fix them in a better
 * way as depicted by this comment.
 */

...

>  			/*	ia_css_debug_dtrace(IA_CSS_DBG_TRACE,
> -				"ia_css_refcount_uninit: freeing (%x)\n",
> -				entry->data);*/
> +			 *	"ia_css_refcount_uninit: freeing (%x)\n",
> +			 *	entry->data);
> +			 */

No, instead use #if 0 ... #endif. Or even better if you find any existing
compile-time definition for that (instead of 0).

...

>  				/* ia_css_debug_dtrace(IA_CSS_DBEUG_TRACE,
> -				   "ia_css_refcount_decrement: freeing\n");*/
> +				 * "ia_css_refcount_decrement: freeing\n");
> +				 */

Ditto.

...

> -			if (entry->count != 0) {
> +			if (entry->count != 0)
>  				IA_CSS_WARNING("Ref count for entry %x is not zero!", entry->id);
> -			}

Make this to be a separate patch, and find more occurrences of a such.

-- 
With Best Regards,
Andy Shevchenko