From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1773FD2D63 for ; Tue, 10 Mar 2026 12:07:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1250070.1547512 (Exim 4.92) (envelope-from ) id 1vzvrs-0003tJ-TY; Tue, 10 Mar 2026 12:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1250070.1547512; Tue, 10 Mar 2026 12:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vzvrs-0003tC-QA; Tue, 10 Mar 2026 12:07:20 +0000 Received: by outflank-mailman (input) for mailman id 1250070; Tue, 10 Mar 2026 12:07:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vzvrr-0003sl-KI for xen-devel@lists.xenproject.org; Tue, 10 Mar 2026 12:07:19 +0000 Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae4fbfdf-1c79-11f1-b164-2bf370ae4941; Tue, 10 Mar 2026 13:07:17 +0100 (CET) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 21B4B7A0208; Tue, 10 Mar 2026 08:07:16 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 10 Mar 2026 08:07:16 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Mar 2026 08:07:14 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae4fbfdf-1c79-11f1-b164-2bf370ae4941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1773144435; x=1773230835; bh=rJNy2V1r18eUkt+FDuWvUZnnrRhtKNBTvcoO1cA8wGY=; b= DtprdXdK47iH0UKWxVfFYMLu0GnDVyAk6B55KQGr8VtNreseOebu8GzwWedR1Apj PrS4ZyM3w5RUWBu8S6SHnCfJeTdq7Qilrgnojks4O4kAkkFbOEcRdNrBWguXZZez ROMsI4M7bHKfe3Uu/t1v+0cGtgX5VgvVmCZb9+vCtXXWNpQBcefEeouXotAS5uW/ FPejGNmjiGIV+g5X68jH+1fkTs2WhNtPXHBFebZ0PSCAm6IaiuOevTedLaZ8Pw2y lgAFJr8C+0vfr4Ang5fp1kwnDcmZFs2gz40XyuHMnMZTEhNpklFEOv/9oyYcc+ea XOg9HXMefb3xDGPFmJLDdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773144435; x=1773230835; bh=rJNy2V1r18eUkt+FDuWvUZnnrRhtKNBTvco O1cA8wGY=; b=jdSxJPL1JWV9W5hoG/3GRukqxd8+feRmcjh6UEb+NeOBTV46HlX 5TxsAf0cPhaU8JhXiYeVrRHHIocsxRcjx3f8zrfX+WhB1IH2jpAefXy224aqnbMN CwItqe7OTYL2oFKTVj2z41/2XVcB9OpPcpq5yXuy4e4LSjueTU1OcFr63g9qSijs VgwGPE1JMjqiYy3ovkuSFN/hAyEQvk63sGHKDbwlJOh5QKTEpgncRi6jKqTvPYlq AbprotWDbzfY9/7mWBskPCQAm7kcsqfWEw/zWyftNhVrKN85whZvIrjpR3zFh1k+ TP7UDikRbjyLaOTnF28aUBPyGb5J22CarQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvkedtleekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgvkhcu ofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinhhvih hsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfduleet feevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehi nhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomhdpnhgspghrtghpthhtohepjedpmh houggvpehsmhhtphhouhhtpdhrtghpthhtohepshhouhhmhigrjhihohhtihhsrghrkhgr rhdvfeesghhmrghilhdrtghomhdprhgtphhtthhopeigvghnqdguvghvvghlsehlihhsth hsrdigvghnphhrohhjvggtthdrohhrghdprhgtphhtthhopehsrghrkhgrrhhsohhumhih rghjhihothhivdefsehgmhgrihhlrdgtohhmpdhrtghpthhtohepjhgsvghulhhitghhse hsuhhsvgdrtghomhdprhgtphhtthhopeguphhsmhhithhhsegrphgvrhhtuhhsshholhhu thhiohhnshdrtghomhdprhgtphhtthhopehrohhgvghrrdhprghusegtihhtrhhigidrtg homhdprhgtphhtthhopegrnhgurhgvfidrtghoohhpvghrfeestghithhrihigrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 10 Mar 2026 13:07:12 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Soumyajyotii Ssarkar Cc: xen-devel@lists.xenproject.org, sarkarsoumyajyoti23@gmail.com, Jan Beulich , "Daniel P . Smith" , Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper Subject: Re: [PATCH v2 1/3] x86/efi: Add BGRT image preservation during boot Message-ID: References: <20260306132935.13727-1-soumyajyotisarkar23@gmail.com> <20260306132935.13727-2-soumyajyotisarkar23@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p0lgbi4TdJfZJK01" Content-Disposition: inline In-Reply-To: <20260306132935.13727-2-soumyajyotisarkar23@gmail.com> --p0lgbi4TdJfZJK01 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 10 Mar 2026 13:07:12 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Soumyajyotii Ssarkar Cc: xen-devel@lists.xenproject.org, sarkarsoumyajyoti23@gmail.com, Jan Beulich , "Daniel P . Smith" , Roger Pau =?utf-8?B?TW9ubsOp?= , Andrew Cooper Subject: Re: [PATCH v2 1/3] x86/efi: Add BGRT image preservation during boot On Fri, Mar 06, 2026 at 06:59:33PM +0530, Soumyajyotii Ssarkar wrote: > The ACPI BGRT (Boot Graphics Resource Table) contains a pointer to a > boot logo image stored in BootServicesData memory. When Xen reclaims > this memory during boot, the image is lost and the BGRT table becomes > invalid, causing Linux dom0 to report ACPI checksum errors. >=20 > Add preservation logic similar to ESRT table handling: > - Locate BGRT table via XSDT during EFI boot services phase > - Validate BMP image signature and size (max 16 MB) > - Copy image to EfiACPIReclaimMemory (safe from reclamation) > - Update BGRT table with new image address > - Recalculate ACPI table checksum >=20 > The preservation runs automatically during efi_exit_boot() before > Boot Services are terminated. This ensures the image remains > accessible to dom0. >=20 > Open-coded ACPI parsing is used because Xen's ACPI subsystem is not > available during the EFI boot phase. The RSDP is obtained from the > EFI System Table, and the XSDT is walked manually to find BGRT. >=20 > Signed-off-by: Soumyajyotii Ssarkar > --- > xen/arch/x86/efi/efi-boot.h | 2 + > xen/common/efi/boot.c | 187 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 189 insertions(+) >=20 > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > index 42a2c46b5e..27792a56ff 100644 > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -910,6 +910,8 @@ void __init efi_multiboot2(EFI_HANDLE ImageHandle, >=20 > efi_relocate_esrt(SystemTable); >=20 > + efi_preserve_bgrt_img(SystemTable); > + See my remark on v1 - efi_start() wants this change too. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --p0lgbi4TdJfZJK01 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmmwCXAACgkQ24/THMrX 1yxuFQf9F1Sk9gsZiIayNgHTQJ41+Gdxf+DCn91KFOV3PKS0xjWCP162pvYMgU1o RCTk+Zp1ycBVH2YgJSSKyq3//Iq8kH4drkso2aVGIdnoFHxwnUnvhPazwd+pQ0yT tRGTsfJB2pbOxQUzxaqQYHjBf9D9yjxLpnhD0pXwL0fEZl6cS1x2r6OrxHuZ9EQ8 34u2ZK4gQ4iT34ll1xC3hJXevXLsjwvceGLOCB7Gf9MuoBvMs+cJmVps4SuYqti9 lfsIFyoOVcA30WjKLI1k5rBtgup/6EJi0m6NkhGYuEgaDd/nOuVAH0o+soR1aamU pEMOT0EzcOqAb68z5+x8mwSTPtXtoA== =MFMh -----END PGP SIGNATURE----- --p0lgbi4TdJfZJK01--