From: Patrick Steinhardt <ps@pks.im>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] history: initialize rev_info in cmd_history_reword()
Date: Tue, 10 Mar 2026 13:16:08 +0100 [thread overview]
Message-ID: <abALiEDdNXCTzVux@pks.im> (raw)
In-Reply-To: <b0b8633f-be95-48eb-8244-d0e3f1a7be72@web.de>
On Sun, Mar 08, 2026 at 10:57:02AM +0100, René Scharfe wrote:
> git history reword expects a single valid revision argument and errors
> out if it doesn't get it. In that case the struct rev_info passed to
> release_revisions() for cleanup is still uninitialized, which can result
> in attempts to free(3) random pointers. Avoid that by initializing the
> structure.
This looks obviously correct to me. Thanks!
Patrick
prev parent reply other threads:[~2026-03-10 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 9:57 [PATCH] history: initialize rev_info in cmd_history_reword() René Scharfe
2026-03-10 12:16 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abALiEDdNXCTzVux@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.