From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
linux-nfs@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Daniel Gomez <da.gomez@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <raemoar63@gmail.com>,
Christian Loehle <christian.loehle@arm.com>
Subject: Re: [PATCH] kthread: remove kthread_exit()
Date: Tue, 10 Mar 2026 06:11:17 -0700 [thread overview]
Message-ID: <abAYdbtYE2tHPNnM@infradead.org> (raw)
In-Reply-To: <CAHk-=wi_kwtWt4Swi=k2zJTnStoBaw3vneHz8ccVNDyVD1nvWg@mail.gmail.com>
On Mon, Mar 09, 2026 at 09:37:26AM -0700, Linus Torvalds wrote:
> On Mon, 9 Mar 2026 at 08:43, Christoph Hellwig <hch@infradead.org> wrote:
> >
> > Because it can't f&*^ up the state of random tasks.
>
> Christoph, you make no sense.
Thanks, I always appreciated rational and detailed answers.
>
> "do_exit()" cannot mess up random tasks. It can only exit the
> *current* task. The task that is running right now in that module.
Yes. And random code should not be able to end arbitrary tasks.
> So what is the actual problem? No more random rants. Explain yourself
> without making wild handwaving gestures.
Wow, you're a bit aggressive, aren't you? Maybe take your meds in the
morning to stay a bit calmer. As said before I don't think allowing
random code (and module is a proxy for that) do exit a task. They
really should not be exiting random kthreads either, but certainly
not more than that.
> Now, there are real exports in this area that are actually strange and
> should be removed: for some historical reason we export 'free_task()'
> which makes no sense to me at all (but probably did at some point).
>
> Now *that* is a strange export that can mess up another task in major ways.
No argument about that, but that's not the point here.
next prev parent reply other threads:[~2026-03-10 13:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 14:52 [PATCH RFC v2] pidfs: convert rb-tree to rhashtable Christian Brauner
2026-01-20 15:43 ` Mateusz Guzik
2026-01-21 10:59 ` Jan Kara
2026-01-22 10:18 ` Christian Brauner
2026-01-22 13:21 ` Jan Kara
2026-02-20 15:11 ` Guillaume Tucker
2026-02-24 13:22 ` Christian Brauner
2026-02-24 16:25 ` make_task_dead() & kthread_exit() Christian Brauner
2026-02-24 17:04 ` Mark Brown
2026-02-24 18:27 ` Guillaume Tucker
2026-02-24 19:30 ` Linus Torvalds
2026-02-26 4:09 ` David Gow
2026-02-26 9:47 ` Christian Brauner
2026-02-27 16:54 ` Linus Torvalds
2026-03-03 10:03 ` Alice Ryhl
2026-03-06 11:05 ` Christian Loehle
2026-03-06 14:07 ` [PATCH] kthread: remove kthread_exit() Christian Brauner
2026-03-06 14:44 ` Christoph Hellwig
2026-03-06 18:27 ` Linus Torvalds
2026-03-09 9:36 ` Christian Brauner
2026-03-09 15:43 ` Christoph Hellwig
2026-03-09 16:37 ` Linus Torvalds
2026-03-09 17:27 ` Linus Torvalds
2026-03-10 13:11 ` Christoph Hellwig [this message]
2026-03-08 8:41 ` David Gow
2026-03-06 16:28 ` make_task_dead() & kthread_exit() Linus Torvalds
2026-02-26 4:08 ` David Gow
2026-02-24 16:37 ` [PATCH RFC v2] pidfs: convert rb-tree to rhashtable Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abAYdbtYE2tHPNnM@infradead.org \
--to=hch@infradead.org \
--cc=Dai.Ngo@oracle.com \
--cc=andrii@kernel.org \
--cc=anna@kernel.org \
--cc=ast@kernel.org \
--cc=atomlin@atomlin.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=christian.loehle@arm.com \
--cc=chuck.lever@oracle.com \
--cc=da.gomez@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davidgow@google.com \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jlayton@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mcgrof@kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=petr.pavlu@suse.com \
--cc=raemoar63@gmail.com \
--cc=samitolvanen@google.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tom@talpey.com \
--cc=torvalds@linux-foundation.org \
--cc=trondmy@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.