From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AF2FEB105B for ; Tue, 10 Mar 2026 14:29:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vzy5I-0001lR-Pq; Tue, 10 Mar 2026 10:29:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzy5G-0001ce-Mo for qemu-devel@nongnu.org; Tue, 10 Mar 2026 10:29:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vzy5E-0001gq-S8 for qemu-devel@nongnu.org; Tue, 10 Mar 2026 10:29:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773152956; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7EIB8Cyp0ps9bHDjK5SRVWmP/UvJe7yFQ0kGEewfFMQ=; b=HRLnd5Y1//763kNAcvrA3O2XO2WFUKkAmGPxzH9TVVvD2EMBhwzc9jlcbq/ueNMv3/ER7H sCnyEMud2LDnyW18kN2jDqPNNivZHYpWA4pXOTk9mGq3dxeJ0RxaRrBQJO66CZgEj28VSP 2vxZkYTFcMdz/VDltJwK1My/MX9+h7s= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-pbnotDF_MWGbX0wpbKLIxw-1; Tue, 10 Mar 2026 10:29:10 -0400 X-MC-Unique: pbnotDF_MWGbX0wpbKLIxw-1 X-Mimecast-MFC-AGG-ID: pbnotDF_MWGbX0wpbKLIxw_1773152949 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 674CF1956050; Tue, 10 Mar 2026 14:29:09 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.213]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6533A1800351; Tue, 10 Mar 2026 14:29:07 +0000 (UTC) Date: Tue, 10 Mar 2026 14:29:03 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Peter Maydell , Peter Xu Subject: Re: [PATCH 6/8] io: Fix TLS bye task leak Message-ID: References: <20260310135540.8679-1-farosas@suse.de> <20260310135540.8679-6-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260310135540.8679-6-farosas@suse.de> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 10, 2026 at 10:55:38AM -0300, Fabiano Rosas wrote: > Recent fixes to TLS tasks memory handling have left the TLS bye task > uncovered. Fix by freeing the task in the same way the handshake task > is freed. > > Direct leak of 704 byte(s) in 4 object(s) allocated from: > #1 0x7f5909b1d6a0 in g_malloc0 ../glib/gmem.c:163 > #2 0x557650496d61 in qio_task_new ../io/task.c:58:12 > #3 0x557650475d7f in qio_channel_tls_bye ../io/channel-tls.c:352:12 > #4 0x55764f7a1bb4 in migration_tls_channel_end ../migration/tls.c:159:5 > #5 0x55764f709750 in migration_ioc_shutdown_gracefully ../migration/multifd.c:462:9 > #6 0x55764f6fcf53 in multifd_send_terminate_threads ../migration/multifd.c:493:13 > #7 0x55764f6fcafb in multifd_send_shutdown ../migration/multifd.c:580:5 > #8 0x55764f6e1b14 in migration_cleanup ../migration/migration.c:1323:9 > #9 0x55764f6f5bac in migration_cleanup_bh ../migration/migration.c:1350:5 > > Fixes: d39d0f3acd ("io: fix cleanup for TLS I/O source data on cancellation") > Signed-off-by: Fabiano Rosas > --- > io/channel-tls.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Acked-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|