All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Hugo Villeneuve <hugo@hugovil.com>,
	robin@protonic.nl, andy@kernel.org,  geert@linux-m68k.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	 hvilleneuve@dimonoff.com, mkorpershoek@kernel.org,
	matthias.bgg@gmail.com,  angelogioacchino.delregno@collabora.com,
	lee@kernel.org, alexander.sverdlin@gmail.com,
	 marek.vasut@gmail.com, akurz@blala.de,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 4/4] Input: charlieplex_keypad: add GPIO charlieplex keypad
Date: Tue, 10 Mar 2026 18:37:34 +0000	[thread overview]
Message-ID: <abBkk4Ng-_MDHd6t@google.com> (raw)
In-Reply-To: <aari1Y1CPZSYEVj3@ashevche-desk.local>

On Fri, Mar 06, 2026 at 04:21:09PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 05, 2026 at 02:20:50PM -0500, Hugo Villeneuve wrote:
> > +static void charlieplex_keypad_poll(struct input_dev *input)
> > +{
> > +	struct charlieplex_keypad *keypad = input_get_drvdata(input);
> 
> > +	int oline;
> 
> Why signed?
> 
> > +	int code;
> > +
> > +	for (code = 0, oline = 0; oline < keypad->nlines; oline++) {
> 
> Can be like
> 
> 	code = 0;
> 	for (unsigned int oline = 0; oline < keypad->nlines; oline++) {
> 
> as iterator is not used outside the loop.
> 
> > +		DECLARE_BITMAP(values, MATRIX_MAX_ROWS);
> 
> > +		int iline;
> 
> Why signed?

Does it make any difference given practical limits on nlines?

Thanks.

-- 
Dmitry


  reply	other threads:[~2026-03-10 18:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 19:20 [PATCH v4 0/4] input: add GPIO-based charlieplex keypad Hugo Villeneuve
2026-03-05 19:20 ` [PATCH v4 1/4] dt-bindings: input: add debounce-delay-ms common property Hugo Villeneuve
2026-03-12 15:03   ` Rob Herring (Arm)
2026-03-05 19:20 ` [PATCH v4 2/4] dt-bindings: input: add settling-time-us " Hugo Villeneuve
2026-03-12 15:02   ` Rob Herring
2026-03-12 15:44     ` Hugo Villeneuve
2026-03-05 19:20 ` [PATCH v4 3/4] dt-bindings: input: add GPIO charlieplex keypad Hugo Villeneuve
2026-03-12 15:02   ` Rob Herring (Arm)
2026-03-05 19:20 ` [PATCH v4 4/4] Input: charlieplex_keypad: " Hugo Villeneuve
2026-03-06 14:21   ` Andy Shevchenko
2026-03-10 18:37     ` Dmitry Torokhov [this message]
2026-03-10 19:18       ` Andy Shevchenko
2026-03-11 14:26         ` Hugo Villeneuve
2026-03-12 16:12     ` Hugo Villeneuve
2026-03-05 19:23 ` [PATCH v4 0/4] input: add GPIO-based " Hugo Villeneuve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abBkk4Ng-_MDHd6t@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=akurz@blala.de \
    --cc=alexander.sverdlin@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mkorpershoek@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.