From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: jic23@kernel.org, m.tretter@pengutronix.de, mchehab@kernel.org,
p.zabel@pengutronix.de, tiffany.lin@mediatek.com,
andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org,
pure.logic@nexus-software.ie, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, kernel@pengutronix.de,
kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz,
marcelo.schmitt1@gmail.com, maudspierings@gocontroll.com,
hverkuil+cisco@kernel.org, ribalda@chromium.org,
straube.linux@gmail.com, dan.carpenter@linaro.org,
lukagejak5@gmail.com, ethantidmore06@gmail.com,
samasth.norway.ananda@oracle.com, karanja99erick@gmail.com,
s9430939@naver.com, tglx@kernel.org, mingo@kernel.org,
sun.jian.kdev@gmail.com, weibu@redadmin.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, skhan@linuxfoundation.org
Subject: Re: [PATCH 1/7] staging: greybus: simplify cleanup using __free
Date: Tue, 10 Mar 2026 23:07:16 +0200 [thread overview]
Message-ID: <abCIBPZzZBfMoOtm@ashevche-desk.local> (raw)
In-Reply-To: <20260310200513.2162018-2-sanjayembedded@gmail.com>
On Wed, Mar 11, 2026 at 01:35:07AM +0530, Sanjay Chitroda wrote:
> Replace manual cleanup logic with __free attribute from cleanup.h. This
> removes explicit kfree() calls and simplifies the error handling paths.
>
> No functional change intended for kmalloc().
...
> + struct gb_camera_configure_streams_request *req __free(kfree) =
> + kmalloc(req_size, GFP_KERNEL);
> + struct gb_camera_configure_streams_response *resp __free(kfree) =
> + kmalloc(resp_size, GFP_KERNEL);
> if (!req || !resp) {
Now this check should be done in a better way.
> - kfree(req);
> - kfree(resp);
> return -ENOMEM;
> }
>
> done_skip_pm_put:
> mutex_unlock(&gcam->mutex);
To complete this, one may add a prerequisite to use guard()() first.
> - kfree(req);
> - kfree(resp);
> return ret;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-10 21:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 20:05 [PATCH 0/7] drivers: Simplify cleanup paths using __free Sanjay Chitroda
2026-03-10 20:05 ` [PATCH 1/7] staging: greybus: simplify cleanup " Sanjay Chitroda
2026-03-10 21:07 ` Andy Shevchenko [this message]
2026-03-11 6:51 ` Dan Carpenter
2026-03-11 7:06 ` Greg KH
2026-03-10 20:05 ` [PATCH 2/7] iio: ssp_sensors: " Sanjay Chitroda
2026-03-10 21:11 ` Andy Shevchenko
2026-03-10 20:05 ` [PATCH 3/7] iio: st_sensors: " Sanjay Chitroda
2026-03-11 0:04 ` David Lechner
2026-03-12 20:52 ` kernel test robot
2026-03-13 0:23 ` kernel test robot
2026-03-10 20:05 ` [PATCH 4/7] media: mediatek: vcodec: " Sanjay Chitroda
2026-03-19 21:08 ` Nicolas Dufresne
2026-03-10 20:05 ` [PATCH 5/7] media: chips-media: coda: " Sanjay Chitroda
2026-03-10 20:05 ` [PATCH 6/7] media: allegro: " Sanjay Chitroda
2026-03-10 20:05 ` [PATCH 7/7] staging: rtl8723bs: " Sanjay Chitroda
2026-03-10 21:42 ` Andrew Lunn
2026-03-11 6:45 ` Greg KH
2026-03-10 21:04 ` [PATCH 0/7] drivers: Simplify cleanup paths " Andy Shevchenko
2026-03-10 21:52 ` David Lechner
2026-03-11 1:57 ` Sanjay Chitroda
2026-03-11 5:42 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abCIBPZzZBfMoOtm@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dan.carpenter@linaro.org \
--cc=dlechner@baylibre.com \
--cc=elder@kernel.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hverkuil+cisco@kernel.org \
--cc=jic23@kernel.org \
--cc=johan@kernel.org \
--cc=karanja99erick@gmail.com \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=lukagejak5@gmail.com \
--cc=m.tretter@pengutronix.de \
--cc=marcelo.schmitt1@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=maudspierings@gocontroll.com \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
--cc=p.zabel@pengutronix.de \
--cc=pure.logic@nexus-software.ie \
--cc=ribalda@chromium.org \
--cc=s9430939@naver.com \
--cc=samasth.norway.ananda@oracle.com \
--cc=sanjayembeddedse@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=straube.linux@gmail.com \
--cc=sun.jian.kdev@gmail.com \
--cc=tglx@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=weibu@redadmin.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.