From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] xtables-translate: Return non-zero if translation fails
Date: Tue, 10 Mar 2026 22:39:56 +0100 [thread overview]
Message-ID: <abCPrKdqjPwrjWVL@orbyte.nwl.cc> (raw)
In-Reply-To: <abBWyuHDm7MT9JC3@strlen.de>
On Tue, Mar 10, 2026 at 06:37:14PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > Untranslated parts in output are easily overlooked and also don't disrupt
> > piping into nft (which is a bad idea to begin with), so make a little
> > noise if things go sideways:
>
> Makes sense to me.
>
> Acked-by: Florian Westphal <fw@strlen.de>
There is a downside: Previously, you could check "translatability" of an
entire dump. With my patch, you have to drop/comment out problematic
rules in order to continue.
It is not exactly a trivial change but maybe worth the effort to
implement a "keep going" flag, what do you think?
Cheers, Phil
next prev parent reply other threads:[~2026-03-10 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:18 [iptables PATCH] xtables-translate: Return non-zero if translation fails Phil Sutter
2026-03-10 17:37 ` Florian Westphal
2026-03-10 21:39 ` Phil Sutter [this message]
2026-03-13 12:51 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abCPrKdqjPwrjWVL@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.