All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jingyuan Liang <jingyliang@chromium.org>
Cc: Jiri Kosina <jikos@kernel.org>,
	 Benjamin Tissoires <bentiss@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	 Mark Brown <broonie@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	 Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,  devicetree@vger.kernel.org,
	hbarnor@chromium.org, Jarrett Schultz <jaschultz@microsoft.com>,
	 Dmitry Antipov <dmanti@microsoft.com>
Subject: Re: [PATCH 01/12] Documentation: Correction in HID output_report callback description.
Date: Tue, 10 Mar 2026 22:10:53 -0700	[thread overview]
Message-ID: <abD5HV7TeNHtq8hi@google.com> (raw)
In-Reply-To: <20260303-send-upstream-v1-1-1515ba218f3d@chromium.org>

On Tue, Mar 03, 2026 at 06:12:53AM +0000, Jingyuan Liang wrote:
> From: Jarrett Schultz <jaschultz@microsoft.com>
> 
> Originally output_report callback was described as must-be asynchronous,
> but that is not the case in some implementations, namely i2c-hid.
> Correct the documentation to say that it may be asynchronous.
> 
> Signed-off-by: Dmitry Antipov <dmanti@microsoft.com>
> Signed-off-by: Jingyuan Liang <jingyliang@chromium.org>
> ---
>  Documentation/hid/hid-transport.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/hid/hid-transport.rst b/Documentation/hid/hid-transport.rst
> index 6f1692da296c..2008cf432af1 100644
> --- a/Documentation/hid/hid-transport.rst
> +++ b/Documentation/hid/hid-transport.rst
> @@ -327,8 +327,8 @@ The available HID callbacks are:
>  
>     Send raw output report via intr channel. Used by some HID device drivers
>     which require high throughput for outgoing requests on the intr channel. This
> -   must not cause SET_REPORT calls! This must be implemented as asynchronous
> -   output report on the intr channel!
> +   must not cause SET_REPORT calls! This call might be asynchronous, so the
> +   caller should not expect an immediate response!

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-03-11  5:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  6:12 [PATCH 00/12] Add spi-hid transport driver Jingyuan Liang
2026-03-03  6:12 ` [PATCH 01/12] Documentation: Correction in HID output_report callback description Jingyuan Liang
2026-03-11  5:10   ` Dmitry Torokhov [this message]
2026-03-03  6:12 ` [PATCH 02/12] HID: Add BUS_SPI support and define HID_SPI_DEVICE macro Jingyuan Liang
2026-03-11  5:11   ` Dmitry Torokhov
2026-03-03  6:12 ` [PATCH 03/12] HID: spi-hid: add transport driver skeleton for HID over SPI bus Jingyuan Liang
2026-03-03  6:12 ` [PATCH 04/12] HID: spi-hid: add spi-hid driver HID layer Jingyuan Liang
2026-03-03  6:12 ` [PATCH 05/12] HID: spi-hid: add HID SPI protocol implementation Jingyuan Liang
2026-03-03  6:12 ` [PATCH 06/12] HID: spi_hid: add spi_hid traces Jingyuan Liang
2026-03-03  6:12 ` [PATCH 07/12] HID: spi_hid: add ACPI support for SPI over HID Jingyuan Liang
2026-03-11  5:27   ` Dmitry Torokhov
2026-03-13  1:24     ` Jingyuan Liang
2026-03-03  6:13 ` [PATCH 08/12] HID: spi_hid: add device tree " Jingyuan Liang
2026-03-03  6:13 ` [PATCH 09/12] dt-bindings: input: Document hid-over-spi DT schema Jingyuan Liang
2026-03-03  7:24   ` Rob Herring (Arm)
2026-03-03 13:53   ` Rob Herring
     [not found]     ` <CAEe3GZHSqepvjjopLwrWX3_n4+RnCeVVQnAO=Swixgu2z3OpUw@mail.gmail.com>
2026-03-12  0:58       ` Fwd: " Jingyuan Liang
2026-03-13  1:14         ` Jingyuan Liang
2026-03-07  7:25   ` Val Packett
2026-03-09  5:44     ` Dmitry Torokhov
2026-03-13  1:00     ` Jingyuan Liang
2026-03-03  6:13 ` [PATCH 10/12] HID: spi-hid: add power management implementation Jingyuan Liang
2026-03-03  6:13 ` [PATCH 11/12] HID: spi-hid: add panel follower support Jingyuan Liang
2026-03-03  6:13 ` [PATCH 12/12] HID: spi-hid: add quirkis to support mode switch for Ilitek touch Jingyuan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abD5HV7TeNHtq8hi@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmanti@microsoft.com \
    --cc=hbarnor@chromium.org \
    --cc=jaschultz@microsoft.com \
    --cc=jikos@kernel.org \
    --cc=jingyliang@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.