All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
	linux-kernel@vger.kernel.org,  linux-block@vger.kernel.org,
	linux-mm@kvack.org, Brian Geffon <bgeffon@google.com>,
	 Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH 3/5] zram: recompression priority param should override algo
Date: Wed, 11 Mar 2026 14:29:57 +0900	[thread overview]
Message-ID: <abD9faU5BcoCNcfY@google.com> (raw)
In-Reply-To: <831636c74ca6d72317de02d96585cc6833d082e6.1772180459.git.senozhatsky@chromium.org>

On (26/02/27 17:21), Sergey Senozhatsky wrote:
> Recompression algorithm lookup by name is ambiguous and
> can lead to unexpected results.  The problem is that
> the system can configure the same algorithm but with
> different parameters (compression level, C/D-dicts, etc.)
> multiple times:
> 
>     [zstd clevel=3] [zstd clevel=8 dict=/etc/dict]
> 
> making it impossible to distinguish compressors by name.
> It is advised to always use "priority".  Additionally,
> override "algo" with "priority", when both params are
> provided.

I don't like this patch.  Andrew, can you drop that whole
series?  I'll send a v2.

  reply	other threads:[~2026-03-11  5:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  8:21 [PATCH 1/5] zram: do not autocorrect bad recompression parameters Sergey Senozhatsky
2026-02-27  8:21 ` [PATCH 2/5] zram: drop ->num_active_comps Sergey Senozhatsky
2026-02-27  8:21 ` [PATCH 3/5] zram: recompression priority param should override algo Sergey Senozhatsky
2026-03-11  5:29   ` Sergey Senozhatsky [this message]
2026-02-27  8:21 ` [PATCH 4/5] zram: update recompression documentation Sergey Senozhatsky
2026-02-27  8:21 ` [PATCH 5/5] zram: remove chained recompression Sergey Senozhatsky
2026-02-28 20:05 ` [PATCH 1/5] zram: do not autocorrect bad recompression parameters Andrew Morton
2026-03-03  2:59   ` Sergey Senozhatsky
2026-03-03  4:28     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abD9faU5BcoCNcfY@google.com \
    --to=senozhatsky@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=bgeffon@google.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.