All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Andy Shevchenko <andy@kernel.org>,
	Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c
Date: Wed, 11 Mar 2026 09:54:17 +0300	[thread overview]
Message-ID: <abERmUmWxAXm5dB6@stanley.mountain> (raw)
In-Reply-To: <20260310-atomisp-remove-void-return-v2b-v3-6-3fdddab41271@yahoo.pl>

On Tue, Mar 10, 2026 at 10:39:17PM +0100, Tomasz Unger wrote:
> Remove redundant 'return;' statements at the end of void functions
> in rx.c. Void functions do not need an explicit return
> statement at the end.
> 
> Found with checkpatch.pl --strict.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
>  drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
> index 9cfb8bc97e24..bf9be11335d4 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
> @@ -44,7 +44,6 @@ void ia_css_isys_rx_enable_all_interrupts(enum mipi_port_id port)
>  	 */
>  	ia_css_irq_enable(IA_CSS_IRQ_INFO_CSS_RECEIVER_ERROR, true);
>  
> -	return;

Delete the blank line.

>  }
>  
>  /* This function converts between the enum used on the CSS API and the
> @@ -197,7 +196,6 @@ void ia_css_isys_rx_clear_irq_info(enum mipi_port_id port,
>  				port,
>  				_HRT_CSS_RECEIVER_IRQ_ENABLE_REG_IDX, bits);
>  
> -	return;

Same.

>  }
>  
>  static int ia_css_isys_2400_set_fmt_type(enum atomisp_input_format input_format,
> @@ -638,7 +636,6 @@ void ia_css_isys_rx_configure(const rx_cfg_t *config,
>  	 */
>  	input_system_reg_store(INPUT_SYSTEM0_ID, 0x207, 1);
>  
> -	return;

Same.

regards,
dan carpenter



  reply	other threads:[~2026-03-11  6:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260310-atomisp-remove-void-return-v2b-v3-0-3fdddab41271.ref@yahoo.pl>
2026-03-10 21:39 ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Tomasz Unger
2026-03-10 21:39   ` [PATCH v3 01/28] media: staging: atomisp: Remove unnecessary return statement in void function Tomasz Unger
2026-03-10 21:39   ` [PATCH v3 02/28] media: staging: atomisp: Remove unnecessary return statements in inputfifo.c Tomasz Unger
2026-03-10 21:39   ` [PATCH v3 03/28] media: staging: atomisp: Remove unnecessary return statement in bufq.c Tomasz Unger
2026-03-10 21:39   ` [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c Tomasz Unger
2026-03-11  6:53     ` Dan Carpenter
2026-03-10 21:39   ` [PATCH v3 05/28] media: staging: atomisp: Remove unnecessary return statements in frame.c Tomasz Unger
2026-03-10 21:39   ` [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c Tomasz Unger
2026-03-11  6:54     ` Dan Carpenter [this message]
2026-03-10 21:39   ` [PATCH v3 07/28] media: staging: atomisp: Remove unnecessary return statement in binary.c Tomasz Unger
2026-03-10 21:39   ` [PATCH v3 08/28] media: staging: atomisp: Remove unnecessary return statements in ia_css_debug.c Tomasz Unger
2026-03-11  6:56     ` Dan Carpenter
2026-03-10 21:39   ` [PATCH v3 09/28] media: staging: atomisp: Remove unnecessary return statement in mmu_public.h Tomasz Unger
2026-03-10 22:46   ` [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions Andy Shevchenko
2026-03-10 21:46 Tomasz Unger
2026-03-10 21:46 ` [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c Tomasz Unger
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10 22:09 [PATCH v3 00/28] media: staging: atomisp: Remove unnecessary return statements from void functions tomasz.unger
2026-03-10 22:09 ` [PATCH v3 06/28] media: staging: atomisp: Remove unnecessary return statements in rx.c tomasz.unger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abERmUmWxAXm5dB6@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomasz.unger@yahoo.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.