From: Dan Carpenter <dan.carpenter@linaro.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Ai Chao <aichao@kylinos.cn>,
gregkh@linuxfoundation.org, b-liu@ti.com, johan@kernel.org,
badhri@google.com, heikki.krogerus@linux.intel.com,
valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
tiwai@suse.de, kees@kernel.org, christophe.jaillet@wanadoo.fr,
prashanth.k@oss.qualcomm.com, khtsai@google.com, tglx@kernel.org,
mingo@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] usbip: vhci_sysfs: Use safer strscpy() instead of strcpy()
Date: Wed, 11 Mar 2026 10:22:48 +0300 [thread overview]
Message-ID: <abEYSBb8LJo9iVPL@stanley.mountain> (raw)
In-Reply-To: <b49bc467-8c51-41fc-a7ee-5770a9720deb@linuxfoundation.org>
On Tue, Mar 10, 2026 at 04:10:20PM -0600, Shuah Khan wrote:
> On 3/10/26 03:44, Ai Chao wrote:
> > Use a safer function strscpy() instead of strcpy() for copying to
> > arrays.
> >
> > Only idiomatic code replacement, and no functional changes.
>
> It is a functional change since it calls a new routine. Get rid
> of this line from change log.
>
> How did you test this patch? I am curious because of you are
> describing the change as "idiomatic code replacement"
>
I liked the commit message... To me it says that patch affect
runtime. It doesn' fix any bugs or introduce any bugs. Too often
these changes are sold as a "potential" bugfix, which means people
haven't bothered to check whether it fixes a bug or not.
It's the right thing to add a note under the --- cut off that the
patch hasn't been tested. Testing isn't required for this sort
of patch but a note is good so reviewers will know to be careful.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-11 7:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 9:44 [PATCH 0/6] Use safer strscpy() instead of strcpy() Ai Chao
2026-03-10 9:44 ` [PATCH 1/6] USB: serial: ti_usb_3410_5052: " Ai Chao
2026-03-17 14:37 ` Johan Hovold
2026-03-10 9:44 ` [PATCH 2/6] usb: musb: " Ai Chao
2026-03-10 9:44 ` [PATCH 3/6] usb: gadget: functionfs: " Ai Chao
2026-03-10 9:44 ` [PATCH 4/6] usb: typec: tcpm: " Ai Chao
2026-03-10 9:44 ` [PATCH 5/6] usb: gadget: udc: " Ai Chao
2026-03-10 9:44 ` [PATCH 6/6] usbip: vhci_sysfs: " Ai Chao
2026-03-10 22:10 ` Shuah Khan
2026-03-11 7:22 ` Dan Carpenter [this message]
2026-03-24 21:34 ` Shuah Khan
2026-03-25 11:09 ` Dan Carpenter
[not found] <7990xi1aonqb-79968wxve9t0@nsmail8.2--kylin--1>
2026-03-26 18:19 ` Shuah Khan
2026-03-30 14:49 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abEYSBb8LJo9iVPL@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=aichao@kylinos.cn \
--cc=b-liu@ti.com \
--cc=badhri@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=i@zenithal.me \
--cc=johan@kernel.org \
--cc=kees@kernel.org \
--cc=khtsai@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=prashanth.k@oss.qualcomm.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@kernel.org \
--cc=tiwai@suse.de \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.