From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
Brian Geffon <bgeffon@google.com>,
linux-block@vger.kernel.org, linux-mm@kvack.org,
gao xu <gaoxu2@honor.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH] zram: do not permit params change after init
Date: Wed, 11 Mar 2026 17:27:54 +0900 [thread overview]
Message-ID: <abEnBEPQDpF6Sgpv@google.com> (raw)
In-Reply-To: <20260310060407.1133800-1-senozhatsky@chromium.org>
On (26/03/10 15:01), Sergey Senozhatsky wrote:
> First, algorithm_params_store(), like any sysfs handler,
> should grab device init lock.
>
> Second, like any write() sysfs handler, it should grab
> device init lock in exclusive mode.
>
> Third, it should not permit change of algos' parameters
> after device init, as this doesn't make sense - we cannot
> compress with one C/D dict and then just change C/D dict
> to a different one, for example.
>
> Fixes: 4eac932103a5d ("zram: introduce algorithm_params device attribute")
> Cc: gao xu <gaoxu2@honor.com>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Andrew, I will include this patch into v2 of the zram fixups,
can you please drop it for now?
We need to protect algo lookup path as well, which accesses
->comp_algs. I'll fix that in v2.
prev parent reply other threads:[~2026-03-11 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 6:01 [PATCH] zram: do not permit params change after init Sergey Senozhatsky
2026-03-10 14:01 ` Brian Geffon
2026-03-10 14:02 ` Brian Geffon
2026-03-11 8:27 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abEnBEPQDpF6Sgpv@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=gaoxu2@honor.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.