Re: [PATCH v2] ARM: dts: renesas: r9a06g032-rzn1d400-db: use interrupt for Micrel PHYs

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

Hi Geert,

> > +       pins_gpio2: pins-gpio2 {
> 
> Please move this below, to preserve sort order (alphabetical,
> and ignoring underscores that will be removed soon).

Will do.

> 
> > +               pinmux = <RZN1_PINMUX(147, RZN1_FUNC_GPIO)>,
> > +                        <RZN1_PINMUX(149, RZN1_FUNC_GPIO)>;
> > +               drive-strength = <6>;
> > +               bias-disable;
> 
> Shouldn't this be bias-pull-up, given the pull-up resistors R20 and
> R78 on the interrupt lines are marked "not assembled" in the schematics?

Ups, yes, "not assembled". Will update and test on HW tomorrow.

> The rest LGTM, so with the above clarified:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks,

   Wolfram