From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazon11011018.outbound.protection.outlook.com [52.101.125.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DC912C21E8 for ; Wed, 11 Mar 2026 16:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.125.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773245503; cv=fail; b=PJfUM0qahng+d7ScXyJXarWmNpYsnGAMnV898ZNZiysIKfflUE3hAFbyTDtqLzlEkB7AClVzBeIJLK97ZRaxx/N2t2kApnuBk4kiuSpD6hFK/SCAb8e/Gq2yLmgxmW0NdgBDIjqFSDDvGKDBJeOLq3RyCRunxzcxz7l0PKA9KfY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773245503; c=relaxed/simple; bh=pYgCPo05rmqL0vDTeb2sg5QSyRmyZmXt+ZFVws2/d3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=pZoyfmp7YnC+P/Q4lUS08ozE7whClIdw6SsgprnmEN3iuUeLctM8Rr4RaQXXw8Gys2KJphPdnlrjpgiFxaSckHJM3zwv4zA58b2WFYR0mkz1kU2w79/dP+pKQOMogDc/wkvc6stHgQQmrP/BfAI6oKLKeE9l7oMIYrQMlNel+l4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b=JzEMDy0S; arc=fail smtp.client-ip=52.101.125.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=bp.renesas.com header.i=@bp.renesas.com header.b="JzEMDy0S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L1gMGz7F6MQ7AThqKeIHTPtU+JisBQxo/MHE+z0PxO10Gy/O+HBUGIJs50WTwGFZZ4jMpPq/oEN2n4Vg13Fk8XasU9GDsyk4yxr0Cb4mRI5P/5xtEDTkoH5XFuiVa6oEhZJwAPgMKMj1KpWQlk0PGxj408yV3HJJThtKY1KPUyuSfvtoHsmEbhMjSAPua3dgmPcBqpxBmjwDtNWrPkbPHFYK7B13/K4zltFjsCmBgnDuMCMprkXAEhGMDm3mu1Ti07U+k8pmPs6703EqyHP6xMLMD+DmxH6Jsnm7rJkFQZwQjd1XW2qUmgFPrJLW0Jh0vIwTLGwwF+udxpMxKxJ8iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HogGDDG94OkutqaOL6yh8IbTVmfEs+I0UCOx+ONm1xk=; b=E9I1mYnJdjBryKuWcuso++A3NXDNR2+4snnLOGkP49ctxOVKErEqEbUSxZ0k68mtgiL56quqy20cNaIDopMfS/NuLUaZaW50djgyyYimnvCBOjs2j7YIRQcqNXQVxMRGuknKEDKSKicHJxg20gb8d206SC8hzqi8WgU7QwllUSzRlJ7m8AwlNwvcw1fr3grLdX/EdadhTXFMQUKltkEdV2thB/2YAAe9eAL74wfA/5or1deGpu1WcOhFkmUNdjyJJBO7yCbH6w0CNC8MMxMvNCpl5vEv7hdbC/mjTcBYCxI688/1x0IUebCwK3wCbO/ItoqwnaP1x64LujFzm6duTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bp.renesas.com; dmarc=pass action=none header.from=bp.renesas.com; dkim=pass header.d=bp.renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bp.renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HogGDDG94OkutqaOL6yh8IbTVmfEs+I0UCOx+ONm1xk=; b=JzEMDy0S7aqcBtArFglIyurUjRR9tv+fAbNAXKdekTs97Mf+O//rsCPv/KUwFvBuatpTkL39focNbBoGCbGfJAkPe1V073a1pF13fRqr/rCgUho3XQkMYg4LAS6x+Mne7AlpVdt6QCixhb8TobEuwoGdnxixnxx3vT5v3xA7s9c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=bp.renesas.com; Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) by TYWPR01MB9469.jpnprd01.prod.outlook.com (2603:1096:400:1a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.11; Wed, 11 Mar 2026 16:11:38 +0000 Received: from TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8]) by TYCPR01MB11947.jpnprd01.prod.outlook.com ([fe80::33f1:f7cd:46be:e4d8%5]) with mapi id 15.20.9700.013; Wed, 11 Mar 2026 16:11:39 +0000 Date: Wed, 11 Mar 2026 17:11:09 +0100 From: Tommaso Merciai To: Bartosz Golaszewski Cc: Philipp Zabel , Mark Brown , Geert Uytterhoeven , linux-kernel@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH] reset: don't overwrite fwnode_reset_n_cells Message-ID: References: <20260310151515.34681-1-bartosz.golaszewski@oss.qualcomm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310151515.34681-1-bartosz.golaszewski@oss.qualcomm.com> X-ClientProxiedBy: FR2P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::15) To TYCPR01MB11947.jpnprd01.prod.outlook.com (2603:1096:400:3e1::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB11947:EE_|TYWPR01MB9469:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b56a1eb-88ad-46a7-fdbd-08de7f88e03b X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|366016|1800799024|38350700014|7053199007|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: 0QMQqR7ffkkAFJ2SU6ELnAYvl0zmljO1O7bugo6R4PPN6vGKdQKDV4noEPGqnJah/lIoAn7tIdcUbz16f5gwApeZD67y/F7Vn76esdS3l9ukFc4B40eUc8u8V4wPvn0uNtGaf/PP9xERj8k1Jvfrgdgqqe2X8yPuTBi9o+DkKQ1Sro6RwF11EoCkphgJF+y5mlDhiFoHJEswOx2Y3ervH88Dzb8dlS4fru2EO4xd4QJ7o+zabM7wMqMVi6pzFdWpk85+v/2YCHk6viqFXSLTT220atNsArfr9h+zEezbRmx4+ov29dmJ+OlyT8AwZ1+tM+UM/oGtgmhyF3BdrsfWz2/W5QQLqK32Vzy6SZ0IxSdP3wYStFloxMngAInX7O6giVcqUaZozbyRKqUQdXcVUKv3Nvo7upUC+NkFWEBVot/OHwCUZVVrDLGQ8GY/+ULuL+l7scKfrT3rj2qTHWj8LXGY6MLAj4Ut3IFeqpLqiSJIlGl8p7A4BQ3DRzScPEo3h/VQYCssIZYdjxdwP/ATaCwQ7g9nYMJ6jKAon/NpVnFh6R9btlEc7Ma5DR2WXWqO2T/lOq9G1Od7NBS4+Ziw2cwwVeLEbW020HZiGC2ii8aDkYoidQgmy41ZVNLhqDinIDJiR09lGrIXerUDlJEYrHNX948rT0FJ+Ra/rzVXFF7aX7hCZquQ/mGGXCZqWqY0H5XfWSDKeAzUxRfu0I2xNEnysHoSsP1+c6mjXTwjCdU46Ap1SWUIk7i2gML2mQWhIGbc5DokEET9GvDCRedPdklYIKXCVRn4Wn9p6yvYoWc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYCPR01MB11947.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(366016)(1800799024)(38350700014)(7053199007)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xynB3O3tqqGLSJPXLR3FANCeYw7vZSYd7Egx5hRWllEhX1/V9HlP/k5FxDlo?= =?us-ascii?Q?do/0Cvsox4C7h/qkeuGesypkICi+bEnOSo89LRaLUrYogILgUp68HOmlcQZx?= =?us-ascii?Q?DGqBQnCQ6EpSxuIJ1nhRHkXyDV9OqPZdpMdTY3GP987lLUGTdBGG6dWn9476?= =?us-ascii?Q?jVQhmS3cktjWFPMLwehIzba19UMgdZFzOGaiBNoBt1JznkqaO+4M4V9qcmg5?= =?us-ascii?Q?OEbEcdOI+DSuyFjgHHXGOgciXIjU87H+S4LRc28smlaRqCmfVC3TkrCf6ipf?= =?us-ascii?Q?fLck3603i4wZxIMhKQota4Cc/jW+WvavU7ILY9+u3Hfx4y0ljeuGa5N39jPC?= =?us-ascii?Q?YzAc5CbOj/GgeVUiRgbX+prqMI6t6x9Ks485tHzOS4U5VlukY1v0bcSH/2N9?= =?us-ascii?Q?uZiC/DeCu5gnDcCigNaSJOETu1Od92aRQSKZrxiSOauADL3VM2vZ24yCpkG6?= =?us-ascii?Q?W6ypsPyzEe77d2PjjEaib/EMFiDt3zJsg3VNXGNLoud9T4BQas5PUl/1Mh2P?= =?us-ascii?Q?Ry/fIjwoFmD989yOvF/NoQje+iSUKMD58/LetIlK1QmmdEHFMbGsLiO8YU8G?= =?us-ascii?Q?zgf2+84G/3ox0Fx/9852UU1UL7925Uy86Z1UB4SCOlEQlahKsXHbgEDSLu0J?= =?us-ascii?Q?cnam/UPBt+vYQpxp1YTUwU979rayVz/dosKBHWjWKAGOOx1dIsWxDPXbx3RN?= =?us-ascii?Q?ZQuxFdlN4UBApo5wXTjMYo2Rpy9sYSkJEnnvQpDjxYoAhjgtk6HFh4ogzAdq?= =?us-ascii?Q?YjfOYWFBOnuzsCbEo+3EYb4egUgxyE6kjRGp41K7fbM2mp6Y/9RqVJDnXx1I?= =?us-ascii?Q?K0rCyraEW3BmTRwXe9BUdjK/8X/UiSBi8KJ9KUgQU3liHIV0kM7/AgfN9MDK?= =?us-ascii?Q?zpftBkBp+VINqdxV88526py6Ybg4ntOUbIKF+tfzYkeUA9u+mooxCg0ncSFr?= =?us-ascii?Q?KHDkDUhZWuoL8UvWfpEFq8od1xNKhw3GaOvrHlF8wryYJpjO6P31JbbT6LXs?= =?us-ascii?Q?ieTzzDcChr0DogS/G50s5aZrF7p/EwhmgDzE8b8KDelaE76Nl9n3JPnBzL95?= =?us-ascii?Q?kwZQv+LBlKS4TL8NVVGCtZ7Ww/bU+IsYtv8B8+KhW8nrXVG/lTal7nGCtQuX?= =?us-ascii?Q?CZmLIkq1XYoWsNEg7LX/aFHLmpanca2Z4dLTQKpAMHucJR71G+ifpRpanHu3?= =?us-ascii?Q?+QKZAuuUblhHfFe87yudhwwOcKMFebPTwHe4qbVkBQ2MY3KMLK1I3xqeyZXZ?= =?us-ascii?Q?yKGZgNyCYfLTl2zmdqDgrK0qPyLicWUbt6+0p53ylPbioc5Mluy0IQ+kE2sL?= =?us-ascii?Q?QUFYiR7sMztbC9isK6rbar04KvCxf3/nLMWUr84sCXi30uTQ5A1VyCUrxGzF?= =?us-ascii?Q?lxsIa4UmxqFoOnTFq6Z2Dvqn1SYjFgq8U6bk2PhGwycen9g1jmbDNSBnDUdo?= =?us-ascii?Q?hkDEmgYh7d3Rf6vMOBr4IB51Ir9h6FlICk50F6x4EKhvCK9xbuukkcRPCaHU?= =?us-ascii?Q?aPUoUuLyS7Kx4S9FrTXoAjli9ESwrfXu2gxp85naKziq3Me2y4jND6+ukyLS?= =?us-ascii?Q?ALHVhWPhbTAV86JjBLTYkgQg2CPwXYijitcml3TgZaU45jDlkFfUUJx0WHbk?= =?us-ascii?Q?x9zrk5o2iMcvmdrn+GgtX09Bw5Shf6zhj/THwR3h7cZkIyXvEreFHBxzT9hQ?= =?us-ascii?Q?l//89k6EIl8Vx/M9cArJwHf0DgkwB1gl7wP/IGK9Z46dSOhieiyvzhOJpAkv?= =?us-ascii?Q?6Qxjcnk0J2WQ113bhY8W/W5dlR7dX3V+2hDpkLsA26p9ExjjdMnH?= X-OriginatorOrg: bp.renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b56a1eb-88ad-46a7-fdbd-08de7f88e03b X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11947.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2026 16:11:39.1075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FcPEL1ErcKMesacEOHvv+OKfQCkFdj0V65ZJ8D33RMz3WxKu1cMZQBYHmOQnF6BWSZ+owVfqZYkYmLRMhuM9SHcTYlDnLWfXEk8JjhCqZNRwD/IAfi4csqilB05u/IgM X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB9469 Hi Bartosz, Thanks for your patch. On Tue, Mar 10, 2026 at 04:15:15PM +0100, Bartosz Golaszewski wrote: > Fix a logic bug in reser_register() where we set fwnode_reset_n_cells to > 1 if fwnode is set and fwnode_xlate is not but we do it after assigning > of_fwnode_handle(of_node) to fwnode. > > Modify the logic to: assign fwnode from of_node if applicable, if fwnode > is still not set, try to get it from the device and only then check > of_xlate and fwnode_xlate and either assign fwnode_reset_n_cells from OF > or default to fwnode_reset_simple_xlate and fwnode_reset_n_cells = 1. > > Fixes: ba8dbbb14b7e ("reset: convert the core API to using firmware nodes") Tested on RZ/G3E. Tested-by: Tommaso Merciai Kind Regards, Tommaso > Reported-by: Mark Brown > Closes: https://lore.kernel.org/all/0b72286b-33dd-4bc9-8c0e-161c2f4baed8@sirena.org.uk/ > Signed-off-by: Bartosz Golaszewski > --- > drivers/reset/core.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/reset/core.c b/drivers/reset/core.c > index e625cf59cfb0..4d27bbea1a69 100644 > --- a/drivers/reset/core.c > +++ b/drivers/reset/core.c > @@ -132,20 +132,21 @@ int reset_controller_register(struct reset_controller_dev *rcdev) > if ((rcdev->of_node && rcdev->fwnode) || (rcdev->of_xlate && rcdev->fwnode_xlate)) > return -EINVAL; > > - if (!rcdev->of_node && !rcdev->fwnode) { > + if (rcdev->of_node && !rcdev->fwnode) > + rcdev->fwnode = of_fwnode_handle(rcdev->of_node); > + > + if (!rcdev->fwnode) { > rcdev->fwnode = dev_fwnode(rcdev->dev); > if (!rcdev->fwnode) > return -EINVAL; > } > > - if (rcdev->of_node) { > - rcdev->fwnode = of_fwnode_handle(rcdev->of_node); > + if (rcdev->of_xlate) > rcdev->fwnode_reset_n_cells = rcdev->of_reset_n_cells; > - } > > - if (rcdev->fwnode && !rcdev->fwnode_xlate) { > - rcdev->fwnode_reset_n_cells = 1; > + if (!rcdev->fwnode_xlate && !rcdev->of_xlate) { > rcdev->fwnode_xlate = fwnode_reset_simple_xlate; > + rcdev->fwnode_reset_n_cells = 1; > } > > INIT_LIST_HEAD(&rcdev->reset_control_head); > -- > 2.47.3 >