From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E654E1125859 for ; Wed, 11 Mar 2026 17:37:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w0NV3-0000nE-PF; Wed, 11 Mar 2026 13:37:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0NV1-0000lQ-IX for qemu-trivial@nongnu.org; Wed, 11 Mar 2026 13:37:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w0NUy-00034p-QV for qemu-trivial@nongnu.org; Wed, 11 Mar 2026 13:37:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773250651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ToyDvXxTl4dvyFR44x+Q5ypiFRuF0LVLNVZxrHziwtM=; b=DuTUhRqPCmOHCA9PMOUh5VU4h/gqkguvPysPptzhXjqhwg3EuhAyKspBy9cjqpEGIMdMO9 /55Q+qkVB/353wZpdbZl9CpkKBgqm2Fkx/0FaiDUF00UelpWMEH54ZG8AuF08Z7urF+FKZ qslpuKl4YBYEovhB98YElZtICOaicdQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-pytdX-hVNAOGFCyuD8J70g-1; Wed, 11 Mar 2026 13:37:30 -0400 X-MC-Unique: pytdX-hVNAOGFCyuD8J70g-1 X-Mimecast-MFC-AGG-ID: pytdX-hVNAOGFCyuD8J70g_1773250650 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd98d96382so15153885a.0 for ; Wed, 11 Mar 2026 10:37:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773250650; x=1773855450; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ToyDvXxTl4dvyFR44x+Q5ypiFRuF0LVLNVZxrHziwtM=; b=rbDgd1ZEwp5VhUxW87v9PMm3VhSKYVnqYTjX73M1lWYjarpMiojDo/b8f12IcxFG0F 051tnKo9uLtyX9MPIcg6NvRQvv05jQ7J2TEMfwhDmlQJwpMmDy+hKSvGNZV8MI1CwSDH DZYgedtRAzuQifMG0cWRct6iG0u8ubqs7ovPu5qrP/0kqtDrZn3/4v9IcQjMPSZLOU96 tm5+UBwJqtBXVA/Tqw6eEjTiLlccNzACnFT+ZbZqyk8NQnDCRr8sGJFQCypwtLUjEqI4 BdJaBcSiRao8aIyRzL+jCMN6sOMYJ9o4CHDU64eUGHi9KdVJKA2jEKyW77C+Xg5KmFGT hX3g== X-Forwarded-Encrypted: i=1; AJvYcCVpH/AjKqOx3zCmOBoLC4nGyg2MAwPfnlYUk7xSnsfPKp8clYRw6upBRrbvqOzRmxxtfJH47cc+PsEkrFc=@nongnu.org X-Gm-Message-State: AOJu0YyWsFz5Wlk7znAPMxUb6mL+HpLoZPxdubRysoQLOgxcboSOJNPV R8xz5b9j6IheLDdoCI56PHdX68ql5MKsXaPEK6KC1/HqwG5foX4g/BISs6gLjpRnDDqCxIZYUpL DiCK9m9fUcJKRVDC4vvsRNPZjz/UOP9hcsKDpBx4K1Qra/dfVFPr6wItrqOqITu6WVE0= X-Gm-Gg: ATEYQzxMC2i/djNrVwAwL50ND0aL8in1boRXrwd3xe6ChyCv+8Awjc/sEj3U1kuqmqY p8KCZUwj7EuONNbI5E6nTYvV8bPjZoSjJKt7GbCbX/sVHjN4pYmn5cpiGlZPcOYpi18FWmSvNhf gZHG3Myp/w0QBja9Ub2D6zIpEMJoRs6/3C0mx6eqsq+fStaqYc5oFxa4BADnEqFUr9Ck3zrbNFO 4uMn/atGfeC94XCGTJITJ24QR45UbuF7M4V7mHv3Gp4WzNe+1oGKVjpkTStE6vtEBhuOuqvnLOd uEJrg99xn+fWn3Veo6y3i4bvjHQqlOvpzCcTWiMT21TYtvBumfijgTeMbe8YSPwT+QAXvgJwYBy dWMkvPx/X7AB3kw== X-Received: by 2002:a05:620a:29c6:b0:8c6:e224:d55b with SMTP id af79cd13be357-8cda1a2d8a4mr428287385a.41.1773250649900; Wed, 11 Mar 2026 10:37:29 -0700 (PDT) X-Received: by 2002:a05:620a:29c6:b0:8c6:e224:d55b with SMTP id af79cd13be357-8cda1a2d8a4mr428282785a.41.1773250649377; Wed, 11 Mar 2026 10:37:29 -0700 (PDT) Received: from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cda216b7fasm173175785a.47.2026.03.11.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 10:37:28 -0700 (PDT) Date: Wed, 11 Mar 2026 13:37:22 -0400 From: Peter Xu To: Sergei Heifetz Cc: qemu-devel@nongnu.org, Fabiano Rosas , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Ani Sinha , qemu-trivial@nongnu.org Subject: Re: [PATCH v4 0/4] Fix a few minor issues reported by Coverity Message-ID: References: <20260311131522.58600-1-heifetz@yandex-team.com> MIME-Version: 1.0 In-Reply-To: <20260311131522.58600-1-heifetz@yandex-team.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ibumSRhdhhmfDYDXgCtMvwQSVjKMzdIoklvUeEg1KUI_1773250650 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org On Wed, Mar 11, 2026 at 06:15:18PM +0500, Sergei Heifetz wrote: > Hi. This patch series fixes several minor issues reported by our local > Coverity installation. > > Changes in v4: > - Included Peter's explanation why `assert` is redundant in the commit > message of the third patch. > - Added `Reviewed-by` tags that I missed in v2 to the other three patches. > > Changes in v3: > - Nothing. I sent the second version of the series without the corresponding > 'v2' suffix by mistake. I apologise. > > Changes in v2: > - Remove assert(block) in system/physmem.c instead of placing it > before the dereference. > > Sergei Heifetz (4): > migration/savevm.c: reorder usage and assertion of mis->from_src_file > dump/dump.c: reorder usage and assertion of block > system/physmem.c: remove useless assertion of block > hw/usb/core.c: reorder usage and assertion of p->ep Reviewed-by: Peter Xu -- Peter Xu