From: Harry Yoo <harry.yoo@oracle.com>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Hao Li <hao.li@linux.dev>, Qing Wang <wangqing7171@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: remove alloc_full_sheaf()
Date: Thu, 12 Mar 2026 13:36:11 +0900 [thread overview]
Message-ID: <abJCu71plqm4t0i_@hyeyoo> (raw)
In-Reply-To: <20260311-b4-slab-remove-alloc_full_sheaf-v1-1-c4c5bb587ae5@kernel.org>
On Wed, Mar 11, 2026 at 07:22:33PM +0100, Vlastimil Babka (SUSE) wrote:
> The function allocates and then refills and empty sheaf. It's only
nit: ^an empty sheaf?
> called from __pcs_replace_empty_main(), which can also in some cases
> refill an empty sheaf. We can therefore consolidate this code.
>
> Remove alloc_full_sheaf() and refactor __pcs_replace_empty_main() so it
> will call alloc_empty_sheaf() when necessary, and then use the
> pre-existing refill_sheaf(). The result should be simpler to follow and
> less duplicated code.
>
> Also adjust the comment about returning sheaves to barn, the part about
> where the empty sheaf we'd be returning comes from is incorrect.
>
> No functional change intended.
>
> Signed-off-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
> ---
Nice cleanup!
Looks good to me,
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2026-03-12 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 18:22 [PATCH] slab: remove alloc_full_sheaf() Vlastimil Babka (SUSE)
2026-03-12 3:31 ` Qing Wang
2026-03-12 9:10 ` vbabka
2026-03-12 9:27 ` Qing Wang
2026-03-12 4:36 ` Harry Yoo [this message]
2026-03-12 4:51 ` Hao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abJCu71plqm4t0i_@hyeyoo \
--to=harry.yoo@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
--cc=wangqing7171@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.