From: Guillaume Nault <gnault@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] ip_tunnel: adapt iptunnel_xmit_stats() to NETDEV_PCPU_STAT_DSTATS
Date: Thu, 12 Mar 2026 11:33:43 +0100 [thread overview]
Message-ID: <abKWh_F-RgNUXpcD@debian> (raw)
In-Reply-To: <20260311123110.1471930-1-edumazet@google.com>
On Wed, Mar 11, 2026 at 12:31:10PM +0000, Eric Dumazet wrote:
> Blamed commits forgot that vxlan/geneve use udp_tunnel[6]_xmit_skb() which
> call iptunnel_xmit_stats().
>
> iptunnel_xmit_stats() was assuming tunnels were only using
> NETDEV_PCPU_STAT_TSTATS.
>
> @syncp offset in pcpu_sw_netstats and pcpu_dstats is different.
>
> 32bit kernels would either have corruptions or freezes if the syncp
> sequence was overwritten.
>
> This patch also moves pcpu_stat_type closer to dev->{t,d}stats to avoid
> a potential cache line miss since iptunnel_xmit_stats() needs to read it.
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Thank!
next prev parent reply other threads:[~2026-03-12 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 12:31 [PATCH net] ip_tunnel: adapt iptunnel_xmit_stats() to NETDEV_PCPU_STAT_DSTATS Eric Dumazet
2026-03-12 10:33 ` Guillaume Nault [this message]
2026-03-12 14:46 ` Jakub Kicinski
2026-03-12 14:53 ` Eric Dumazet
2026-03-12 15:12 ` Jakub Kicinski
2026-03-13 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abKWh_F-RgNUXpcD@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.