From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Mark Brown <broonie@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Yosry Ahmed <yosry@kernel.org>
Subject: Re: linux-next: manual merge of the kvm-x86 tree with the kvm-fixes tree
Date: Thu, 12 Mar 2026 10:58:08 -0700 [thread overview]
Message-ID: <abL-sO9M_TaXYZUp@google.com> (raw)
In-Reply-To: <a48b3130-54d6-4cf4-a059-e576f163ebcd@redhat.com>
On Thu, Mar 12, 2026, Paolo Bonzini wrote:
> On 3/12/26 18:21, Mark Brown wrote:
> > diff --cc arch/x86/kvm/svm/svm.c
> > index e6477affac9a0,3407deac90bd6..0000000000000
> > --- a/arch/x86/kvm/svm/svm.c
> > +++ b/arch/x86/kvm/svm/svm.c
> > @@@ -4880,15 -5030,11 +5030,11 @@@ static int svm_leave_smm(struct kvm_vcp
> > vmcb12 = map.hva;
> > nested_copy_vmcb_control_to_cache(svm, &vmcb12->control);
> > nested_copy_vmcb_save_to_cache(svm, &vmcb12->save);
> > - ret = enter_svm_guest_mode(vcpu, smram64->svm_guest_vmcb_gpa, false);
> > - if (nested_svm_check_cached_vmcb12(vcpu) < 0)
> > - goto unmap_save;
>
> The right resolution is to keep these two lines...
>
> > -
> > - if (enter_svm_guest_mode(vcpu, smram64->svm_guest_vmcb_gpa,
> > - vmcb12, false) != 0)
> > - if (ret)
> > ++ if (enter_svm_guest_mode(vcpu, smram64->svm_guest_vmcb_gpa, false) != 0)
>
> ... while of course this part is okay.
I'm in the process of redoing kvm-x86/next on top of kvm/next, so I'll sort this
out on my end (and double check that I come up with the same resolution as Paolo).
next prev parent reply other threads:[~2026-03-12 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 17:21 linux-next: manual merge of the kvm-x86 tree with the kvm-fixes tree Mark Brown
2026-03-12 17:54 ` Paolo Bonzini
2026-03-12 17:58 ` Sean Christopherson [this message]
2026-03-12 17:58 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2024-04-03 0:53 Stephen Rothwell
2024-04-03 13:30 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abL-sO9M_TaXYZUp@google.com \
--to=seanjc@google.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.