All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Donnefort <vdonnefort@google.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Oliver Upton <oupton@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] KVM: arm64: fix include path for ring buffer implementation
Date: Thu, 12 Mar 2026 13:35:22 +0000	[thread overview]
Message-ID: <abLBGqgPkwYVYMa7@google.com> (raw)
In-Reply-To: <20260312123601.625063-1-arnd@kernel.org>

On Thu, Mar 12, 2026 at 01:35:42PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The simple_ring_buffer.c file is in the source tree rather than
> generated at build time, so the include path is wrong when using
> separate object trees:
> 
> arch/arm64/kvm/hyp/nvhe/trace.c:16:10: fatal error: simple_ring_buffer.c: No such file or directory
>    16 | #include "simple_ring_buffer.c"
> 
> Include it from the source tree instead.
> 
> Fixes: 680a04c333fa ("KVM: arm64: Add tracing capability for the nVHE/pKVM hyp")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I believe Marc has taken a fix already for that one

https://lore.kernel.org/all/20260311164956.1424119-1-vdonnefort@google.com/

> ---
>  arch/arm64/kvm/hyp/nvhe/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile
> index 143d55ec7298..3d33fbefdfc1 100644
> --- a/arch/arm64/kvm/hyp/nvhe/Makefile
> +++ b/arch/arm64/kvm/hyp/nvhe/Makefile
> @@ -33,7 +33,7 @@ hyp-obj-$(CONFIG_NVHE_EL2_TRACING) += clock.o trace.o events.o
>  hyp-obj-y += $(lib-objs)
>  
>  # Path to simple_ring_buffer.c
> -CFLAGS_trace.nvhe.o += -I$(objtree)/kernel/trace/
> +CFLAGS_trace.nvhe.o += -I$(srctree)/kernel/trace/
>  
>  ##
>  ## Build rules for compiling nVHE hyp code
> -- 
> 2.39.5
> 

  parent reply	other threads:[~2026-03-12 13:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 12:35 [PATCH 1/3] KVM: arm64: fix include path for ring buffer implementation Arnd Bergmann
2026-03-12 12:35 ` [PATCH 2/3] tracing: add more symbols to whitelist Arnd Bergmann
2026-03-12 13:40   ` Vincent Donnefort
2026-03-12 14:37     ` Arnd Bergmann
2026-03-12 15:21       ` Marc Zyngier
2026-03-12 15:37         ` Arnd Bergmann
2026-03-12 12:35 ` [PATCH 3/3] KVM: arm64: tracing: add ftrace dependency Arnd Bergmann
2026-03-12 13:52   ` Vincent Donnefort
2026-03-12 13:35 ` Vincent Donnefort [this message]
2026-03-12 15:45 ` (subset) [PATCH 1/3] KVM: arm64: fix include path for ring buffer implementation Marc Zyngier
2026-03-12 22:08   ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abLBGqgPkwYVYMa7@google.com \
    --to=vdonnefort@google.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.