All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zile Xiong <xiongzile99@gmail.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org, deller@gmx.de,
	abdun.nihaal@gmail.com, chintanlike@gmail.com,
	niejianglei2021@163.com, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg
Date: Thu, 12 Mar 2026 16:56:58 +0300	[thread overview]
Message-ID: <abLGKjvKMorbb3Vb@stanley.mountain> (raw)
In-Reply-To: <20260312111807.96789-1-xiongzile99@gmail.com>

On Thu, Mar 12, 2026 at 07:18:07PM +0800, Zile Xiong wrote:
> Replace the empty modifier argument with a simple identity macro.
> This fixes the error reported by scripts/checkpatch.pl while keeping
> the original semantics unchanged.
> 
> The generated code is equivalent and builds successfully.
> 
> Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-bus.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 30e436ff19e4..380dd374a566 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -61,10 +61,10 @@ out:									      \
>  	va_end(args);                                                         \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
> -
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +#define fbtft_identity(x) (x)

Someone sent this exact same patch before.  Same name and everything.

https://lore.kernel.org/all/aYECoy7Apjwgzr9r@stanley.mountain/

A better sollution is to learn to just ignore checkpatch when it is
wrong.  My previous email was longer.

regards,
dan carpenter


      reply	other threads:[~2026-03-12 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 11:18 [PATCH] staging: fbtft: avoid empty macro argument in define_fbtft_write_reg Zile Xiong
2026-03-12 13:56 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abLGKjvKMorbb3Vb@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=abdun.nihaal@gmail.com \
    --cc=andy@kernel.org \
    --cc=chintanlike@gmail.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=niejianglei2021@163.com \
    --cc=xiongzile99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.