All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Eric Biggers <ebiggers@kernel.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] lib: crypto: fix comments for count_leading_zeros()
Date: Thu, 12 Mar 2026 12:34:39 -0400	[thread overview]
Message-ID: <abLrHz5BRojkcoxM@yury> (raw)
In-Reply-To: <abLnLIRf6z8nh_Pu@ashevche-desk.local>

On Thu, Mar 12, 2026 at 06:17:48PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 12, 2026 at 12:11:32PM -0400, Yury Norov wrote:
> > count_leading_zeros() is based on fls(), which is defined for x == 0,
> > contrary to ffs() family. The comment in crypto/mpi erroneously states
> > that the function may return undef in such case.
> > 
> > Fix the comment together with the outdated function signature, and now
> > that COUNT_LEADING_ZEROS_0 is not referenced in the codebase, get rid of
> > it too.
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks, it worth!

Applied for testing in -next.

Thanks,
Yury

  reply	other threads:[~2026-03-12 16:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 16:11 [PATCH v2] lib: crypto: fix comments for count_leading_zeros() Yury Norov
2026-03-12 16:17 ` Andy Shevchenko
2026-03-12 16:34   ` Yury Norov [this message]
2026-03-12 21:55     ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abLrHz5BRojkcoxM@yury \
    --to=ynorov@nvidia.com \
    --cc=Jason@zx2c4.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.