From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans de Goede <hansg@kernel.org>
Cc: Antti Laakso <antti.laakso@linux.intel.com>,
linux-media@vger.kernel.org, linux-gpio@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linusw@kernel.org,
brgl@kernel.org, mchehab@kernel.org, dan.scally@ideasonboard.com,
ilpo.jarvinen@linux.intel.com, hverkuil+cisco@kernel.org,
sre@kernel.org, hao.yao@intel.com, jimmy.su@intel.com,
miguel.vadillo@intel.com, kees@kernel.org, ribalda@chromium.org
Subject: Re: [PATCH v2 5/5] platform: int3472: Add MSI prestige board data
Date: Thu, 12 Mar 2026 23:00:06 +0200 [thread overview]
Message-ID: <abMpVo1eCvtBObv_@kekkonen.localdomain> (raw)
In-Reply-To: <dc7f24b2-ec57-4937-92f1-f80b1f1e785a@kernel.org>
Hi Hans, others,
On Wed, Mar 11, 2026 at 03:35:28PM +0100, Hans de Goede wrote:
> > +static const struct regulator_init_data msi_p14_ai_evo_tps68470_vio_reg_init_data = {
> > + .constraints = {
> > + .min_uV = 1800600,
> > + .max_uV = 1800600,
> > + .apply_uV = 1,
> > + .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> > + },
>
> > + .num_consumer_supplies = 0,
> > + .consumer_supplies = NULL,
>
> Nit (no need to fix unless you need to do a v3 for other reasons),
> these 2 explicit foo = 0 initializers are not necessary and can
> be dropped.
I can fix this while applying...
>
> Otherwise this looks good to me:
>
> Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
...assuming everyone is fine with merging these via the media tree. Let me
know if there are concerns.
Thank you for the reviews.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2026-03-12 20:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 13:19 [PATCH v2 0/5] platform: int3472: Add MSI prestige 14 AI EVO data Antti Laakso
2026-03-11 13:19 ` [PATCH v2 1/5] media: i2c: ov5675: Wait for endpoint Antti Laakso
2026-03-11 14:31 ` Hans de Goede
2026-03-11 19:10 ` Dan Scally
2026-03-11 13:19 ` [PATCH v2 2/5] media: ipu-bridge: Add ov5675 sensor Antti Laakso
2026-03-17 12:52 ` Sakari Ailus
2026-03-11 13:19 ` [PATCH v2 3/5] platform: int3472: Add gpio software node Antti Laakso
2026-03-11 14:33 ` Hans de Goede
2026-03-11 14:43 ` Bartosz Golaszewski
2026-03-17 11:53 ` Ilpo Järvinen
2026-03-11 13:19 ` [PATCH v2 4/5] gpio: tps68470: Add i2c daisy chain support Antti Laakso
2026-03-11 14:33 ` Hans de Goede
2026-03-11 14:42 ` Bartosz Golaszewski
2026-03-11 13:19 ` [PATCH v2 5/5] platform: int3472: Add MSI prestige board data Antti Laakso
2026-03-11 14:35 ` Hans de Goede
2026-03-12 21:00 ` Sakari Ailus [this message]
2026-03-11 14:43 ` Bartosz Golaszewski
2026-03-11 19:27 ` Dan Scally
2026-03-17 11:52 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abMpVo1eCvtBObv_@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=antti.laakso@linux.intel.com \
--cc=brgl@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=hao.yao@intel.com \
--cc=hverkuil+cisco@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jimmy.su@intel.com \
--cc=kees@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=miguel.vadillo@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.