From: Li Wang <liwang@redhat.com>
To: Yosry Ahmed <yosry@kernel.org>
Cc: Nhat Pham <nphamcs@gmail.com>,
mkoutny@suse.com, yosryahmed@google.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <muchun.song@linux.dev>, Tejun Heo <tj@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>
Subject: Re: [PATCH v2 1/7] selftests/cgroup: skip test_zswap if zswap is globally disabled
Date: Fri, 13 Mar 2026 11:35:28 +0800 [thread overview]
Message-ID: <abOGAHNnv9OZltdq@redhat.com> (raw)
In-Reply-To: <abODRsaeEul9Aj2X@redhat.com>
On Fri, Mar 13, 2026 at 11:23:50AM +0800, Li Wang wrote:
> On Thu, Mar 12, 2026 at 07:58:28PM -0700, Yosry Ahmed wrote:
> > > Yes, this looks more tidy than open it. I'll go this helper in v3.
> > >
> > > >
> > > > static void check_zswap_enabled(void)
> > > > {
> > > > char value;
> > >
> > > read_text() requires string but not char.
> >
> > I was just illustrating. This should be passed in as &value. That should work?
>
> Yes, pass it as &value works well.
And use sizeof(&value) just get the pointer's size but not
the buffer size, so I would recommend: char value[2].
--
Regards,
Li Wang
prev parent reply other threads:[~2026-03-13 3:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 4:06 [PATCH v2 1/7] selftests/cgroup: skip test_zswap if zswap is globally disabled Li Wang
2026-03-12 4:06 ` [PATCH v2 2/7] selftests/cgroup: avoid OOM in test_swapin_nozswap Li Wang
2026-03-12 22:41 ` Yosry Ahmed
2026-03-12 4:06 ` [PATCH v2 3/7] selftests/cgroup: use runtime page size for zswpin check Li Wang
2026-03-12 4:06 ` [PATCH v2 4/7] selftests/cgroup: rename PAGE_SIZE to BUF_SIZE in cgroup_util Li Wang
2026-03-12 4:06 ` [PATCH v2 5/7] selftest/cgroup: fix zswap test_no_invasive_cgroup_shrink on 64K pagesize system Li Wang
2026-03-12 4:06 ` [PATCH v2 6/7] selftests/cgroup: replace hardcoded page size values in test_zswap Li Wang
2026-03-12 22:44 ` Yosry Ahmed
2026-03-13 2:01 ` Li Wang
2026-03-12 4:06 ` [PATCH v2 7/7] selftest/cgroup: fix zswap attempt_writeback() on 64K pagesize system Li Wang
2026-03-12 22:44 ` Yosry Ahmed
2026-03-12 18:32 ` [PATCH v2 1/7] selftests/cgroup: skip test_zswap if zswap is globally disabled Nhat Pham
2026-03-12 21:09 ` Yosry Ahmed
2026-03-13 1:50 ` Li Wang
2026-03-13 2:58 ` Yosry Ahmed
2026-03-13 3:23 ` Li Wang
2026-03-13 3:35 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abOGAHNnv9OZltdq@redhat.com \
--to=liwang@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosry@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.