From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F15ED58B0E for ; Sun, 15 Mar 2026 05:02:42 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id CE8D943959 for ; Sun, 15 Mar 2026 05:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.trustedfirmware.org; s=2024; t=1773550961; bh=xQ6MZVB/3zExDREkvTUaajHokVFRDIvOoon2dBy4krY=; h=Date:To:Subject:References:In-Reply-To:CC:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Reply-To:From; b=XiHib360Jv641y45KMAIJN6IOVn4QsDq6qqdxbfQjlrS/mW0lxpFaAbr47xI1n7XP KkONEf+04W4kABssc+6jsKbqJkI6mz6E8qhSHBwXM0XEbXbz8gxm6vEJ+FlEc7L9aF YGGxVouAUzq+REEnXNr+zxxC6WLz7BWqTEqyTmcZOoaA0gNZVbtszgYfwQ/tgme0V1 GPNMDLyS+yfZ6W51Tjcvu8Y7v6F9E9mc09ImlZECsID0LK4krVUwpVMtGACPli70rf EO7QRTxz2UzXS0x5zgzCdkniCcyr2AJeJxF1rhIAEgzfkymdna+IN7iIlPDYpo8qjK EImQZntP3mADg== Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by lists.trustedfirmware.org (Postfix) with ESMTPS id 477754373C for ; Sun, 15 Mar 2026 05:02:22 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=u7ZgeCv9; dkim-atps=neutral Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C1F1960018; Sun, 15 Mar 2026 05:02:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 427FDC4CEF7; Sun, 15 Mar 2026 05:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773550941; bh=y/qPg1BOLvx4bG6IThJrAhMyZd/utCNU//A3HXcgTNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u7ZgeCv9fBLbkIaWg5hUsa9LZLq5L/z1fCEpaPAZJ31/l9L1EpVWk40Brbyxt+E9W gm9Ipp3yLCKFsp2J8f0A1XWN4UyQ7q9V5rhTr8eXtCyatOQd3bVjieTLpcEDaZCU06 JZbqDPbLL10cqYKB+gIZNk09jCK5A29Hj2r7gDo71q16hZkMk9+60JADwYc2OuK3RU 5j5yizvjsVRcE8Fv+wKKlU51D5O2RnHZS69kWLaL1SBSaSb+QP2HeqIhM3k+pMNnWq Nuhj35OewMqm00DrASH6FJ1RCImdvC1JrjDO7d+0J+LasAjUz2mB0F5+K3i+BHtoN7 qDp/QszNKmyfw== Date: Sun, 15 Mar 2026 10:32:16 +0530 To: Jens Wiklander Subject: Re: [PATCH] optee: Check return value of tee_shm_get_va() Message-ID: References: <20260305083312.1040969-1-nichen@iscas.ac.cn> <2e15b2b8-7dd4-4e63-b9a9-a664323ebb36@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: base64 In-Reply-To: X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.00 / 15.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; DWL_DNSWL_LOW(-1.00)[kernel.org:dkim]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,quarantine]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; R_SPF_ALLOW(-0.20)[+ip4:172.105.4.254]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.105.0.0/19, country:SG]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; ALIAS_RESOLVED(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[web.de,iscas.ac.cn,lists.trustedfirmware.org,vger.kernel.org,linaro.org]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[172.105.4.254:from,100.75.92.58:received]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: 477754373C X-Spamd-Bar: -- Message-ID-Hash: GPK3TSKHCBHVQHAWWOI4BJT3PQFHM65N X-Message-ID-Hash: GPK3TSKHCBHVQHAWWOI4BJT3PQFHM65N X-MailFrom: sumit.garg@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Markus Elfring , Chen Ni , op-tee@lists.trustedfirmware.org, LKML , Ulf Hansson X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Sumit Garg via OP-TEE Reply-To: Sumit Garg T24gVGh1LCBNYXIgMTIsIDIwMjYgYXQgMTI6MTY6MTFQTSArMDEwMCwgSmVucyBXaWtsYW5kZXIg d3JvdGU6DQo+IE9uIFRodSwgTWFyIDEyLCAyMDI2IGF0IDEwOjE24oCvQU0gU3VtaXQgR2FyZyA8 c3VtaXQuZ2FyZ0BrZXJuZWwub3JnPiB3cm90ZToNCj4gPg0KPiA+IE9uIEZyaSwgTWFyIDA2LCAy MDI2IGF0IDEyOjUyOjM5UE0gKzAxMDAsIE1hcmt1cyBFbGZyaW5nIHdyb3RlOg0KPiA+ID4g4oCm DQo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdGVlL29wdGVlL3JwYy5jDQo+ID4gPiA+IEBAIC0zOTMs NiArMzkzLDExIEBAIHN0YXRpYyB2b2lkIGhhbmRsZV9ycGNfZnVuY19ycG1iX2ZyYW1lcyhzdHJ1 Y3QgdGVlX2NvbnRleHQgKmN0eCwNCj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgcGFy YW1zWzBdLnUubWVtcmVmLnNobV9vZmZzKTsNCj4gPiA+ID4gICAgIHAxID0gdGVlX3NobV9nZXRf dmEocGFyYW1zWzFdLnUubWVtcmVmLnNobSwNCj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAg ICAgcGFyYW1zWzFdLnUubWVtcmVmLnNobV9vZmZzKTsNCj4gPiA+ID4gKyAgIGlmIChJU19FUlIo cDApIHx8IElTX0VSUihwMSkpIHsNCj4gPiA+ID4gKyAgICAgICAgICAgYXJnLT5yZXQgPSBURUVD X0VSUk9SX0JBRF9QQVJBTUVURVJTOw0KPiA+ID4gPiArICAgICAgICAgICBnb3RvIG91dDsNCj4g PiA+ID4gKyAgIH0NCj4gPiA+ID4gKw0KPiA+ID4gPiAgICAgaWYgKHJwbWJfcm91dGVfZnJhbWVz KHJkZXYsIHAwLCBwYXJhbXNbMF0udS5tZW1yZWYuc2l6ZSwgcDEsDQo+ID4gPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgcGFyYW1zWzFdLnUubWVtcmVmLnNpemUpKSB7DQo+ID4gPiA+ICAg ICAgICAgICAgIGFyZy0+cmV0ID0gVEVFQ19FUlJPUl9CQURfUEFSQU1FVEVSUzsNCj4gPiA+IOKA pg0KPiA+ID4NCj4gPiA+IEhvdyBkbyB5b3UgdGhpbmsgYWJvdXQgdG8gdXNlIGFuIGFkZGl0aW9u YWwgbGFiZWwgZm9yIHRoZSBzaG93bg0KPiA+ID4gZXJyb3IgY29kZSBhc3NpZ25tZW50Pw0KPiA+ ID4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFs ZHMvbGludXguZ2l0L3RyZWUvRG9jdW1lbnRhdGlvbi9wcm9jZXNzL2NvZGluZy1zdHlsZS5yc3Q/ aD12Ny4wLXJjMiNuNTI2DQo+ID4gPg0KPiA+DQo+ID4gSSBzdXBwb3NlIGhlcmUgeW91IG1lYW50 IHRvIHVwZGF0ZSB0aGUgbGFiZWwgbmFtZSBzaW5jZSBpdCdzIHRoZSBzYW1lDQo+ID4gZXJyb3Ig dHlwZSB1c2VkIGJ5IG90aGVyIGNvZGUgcGF0aHMgdG9vLiBTbyBmb2xsb3dpbmcgbGFiZWwgcmVu YW1lDQo+ID4gc2hvdWxkIGJlIGZpbmUgSSB0aGluayBhcyBwZXIgY29kaW5nIGd1aWRlbGluZXM6 DQo+ID4NCj4gPiBzL291dC9lcnJfZGV2X3B1dC8NCj4gDQo+IFdvdWxkbid0IHRoZSBuYW1lIGVy cl9kZXZfcHV0IHN1Z2dlc3QgdGhpcyBvbmx5IG9jY3VycyBpbiB0aGUgZXJyb3IgcGF0aD8NCj4g DQoNCk9rYXksIGxldCByYXRoZXIgcmVuYW1lIGl0IHRvIG91dF9kZXZfcHV0Lg0KDQotU3VtaXQN Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3705E4A32 for ; Sun, 15 Mar 2026 05:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773550942; cv=none; b=k8Tm6HHyaGmb3+aWkw0woiVB+eSXpLMZvvDiVn3/FgwFUVasOjf6OIuEvqegwHI7y9BTkcUILiETIxdP/ktNxkSEhmSQbgZi1YOKhXeBWtrWE2W0YwWupfultPCPhFXMedTl/CY1Kzs0QQ41PLLZGfV92XX3f2+qApwxCrPyYTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773550942; c=relaxed/simple; bh=y/qPg1BOLvx4bG6IThJrAhMyZd/utCNU//A3HXcgTNg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WCR5V45N2xxo1Uo2iyKdmdCu2Ijfb009QkAknCnGaDVniqfnycYnKm2V4CiJzx1DgJiOOV/Q/LFs4cWKakG0dzKHrJ1HmLXiPyfwd5QYiSXWWUE6qI8oiJUaqhKuLhXmQFKj3Up6ljpi6mZtJSBpQbdv3MaVP9YvuiUuv4iLZd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u7ZgeCv9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u7ZgeCv9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 427FDC4CEF7; Sun, 15 Mar 2026 05:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773550941; bh=y/qPg1BOLvx4bG6IThJrAhMyZd/utCNU//A3HXcgTNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u7ZgeCv9fBLbkIaWg5hUsa9LZLq5L/z1fCEpaPAZJ31/l9L1EpVWk40Brbyxt+E9W gm9Ipp3yLCKFsp2J8f0A1XWN4UyQ7q9V5rhTr8eXtCyatOQd3bVjieTLpcEDaZCU06 JZbqDPbLL10cqYKB+gIZNk09jCK5A29Hj2r7gDo71q16hZkMk9+60JADwYc2OuK3RU 5j5yizvjsVRcE8Fv+wKKlU51D5O2RnHZS69kWLaL1SBSaSb+QP2HeqIhM3k+pMNnWq Nuhj35OewMqm00DrASH6FJ1RCImdvC1JrjDO7d+0J+LasAjUz2mB0F5+K3i+BHtoN7 qDp/QszNKmyfw== Date: Sun, 15 Mar 2026 10:32:16 +0530 From: Sumit Garg To: Jens Wiklander Cc: Markus Elfring , Chen Ni , op-tee@lists.trustedfirmware.org, LKML , Ulf Hansson Subject: Re: [PATCH] optee: Check return value of tee_shm_get_va() Message-ID: References: <20260305083312.1040969-1-nichen@iscas.ac.cn> <2e15b2b8-7dd4-4e63-b9a9-a664323ebb36@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 12, 2026 at 12:16:11PM +0100, Jens Wiklander wrote: > On Thu, Mar 12, 2026 at 10:16 AM Sumit Garg wrote: > > > > On Fri, Mar 06, 2026 at 12:52:39PM +0100, Markus Elfring wrote: > > > … > > > > +++ b/drivers/tee/optee/rpc.c > > > > @@ -393,6 +393,11 @@ static void handle_rpc_func_rpmb_frames(struct tee_context *ctx, > > > > params[0].u.memref.shm_offs); > > > > p1 = tee_shm_get_va(params[1].u.memref.shm, > > > > params[1].u.memref.shm_offs); > > > > + if (IS_ERR(p0) || IS_ERR(p1)) { > > > > + arg->ret = TEEC_ERROR_BAD_PARAMETERS; > > > > + goto out; > > > > + } > > > > + > > > > if (rpmb_route_frames(rdev, p0, params[0].u.memref.size, p1, > > > > params[1].u.memref.size)) { > > > > arg->ret = TEEC_ERROR_BAD_PARAMETERS; > > > … > > > > > > How do you think about to use an additional label for the shown > > > error code assignment? > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.0-rc2#n526 > > > > > > > I suppose here you meant to update the label name since it's the same > > error type used by other code paths too. So following label rename > > should be fine I think as per coding guidelines: > > > > s/out/err_dev_put/ > > Wouldn't the name err_dev_put suggest this only occurs in the error path? > Okay, let rather rename it to out_dev_put. -Sumit