From: "Arnd Bergmann" <arnd@arndb.de>
To: "Binbin Zhou" <zhoubinbin@loongson.cn>,
"Wolfram Sang" <wsa@kernel.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org
Cc: loongarch@lists.linux.dev, devicetree@vger.kernel.org,
"Huacai Chen" <chenhuacai@loongson.cn>,
"WANG Xuerui" <kernel@xen0n.name>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Jianmin Lv" <lvjianmin@loongson.cn>
Subject: Re: [PATCH V3 1/5] i2c: gpio: Fix potential unused warning for 'i2c_gpio_dt_ids'
Date: Fri, 25 Nov 2022 11:35:39 +0100 [thread overview]
Message-ID: <abb37a26-1659-4ba0-a621-55fef35f552d@app.fastmail.com> (raw)
In-Reply-To: <4ace98785f900bf1a818d006ae5906f6b51edf7e.1669359515.git.zhoubinbin@loongson.cn>
On Fri, Nov 25, 2022, at 09:54, Binbin Zhou wrote:
> of_match_ptr() compiles into NULL if CONFIG_OF is disabled.
> Fix warning by dropping of_match_ptr().
>
> Suggested by Andy Shevchenko, thanks.
>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
I think this is a useful cleanup in general, though I don't think
there is an actual warning in this particular driver that gets fixed
by the patch, so it would be good to change the changelog text to
describe this better: dropping a matching #ifdef check along with
dropping of_match_ptr() is just a cleanup, while dropping
of_match_ptr() that has no corresponding #ifdef fixes an actual
warning.
next prev parent reply other threads:[~2022-11-25 10:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:54 [PATCH V3 0/5] i2c: ls2x: Add support for the Loongson-2K/LS7A I2C controller Binbin Zhou
2022-11-25 8:54 ` [PATCH V3 1/5] i2c: gpio: Fix potential unused warning for 'i2c_gpio_dt_ids' Binbin Zhou
2022-11-25 10:21 ` Andy Shevchenko
2022-11-25 10:35 ` Arnd Bergmann [this message]
2022-11-25 8:54 ` [PATCH V3 2/5] i2c: gpio: Add support on ACPI-based system Binbin Zhou
2022-11-25 10:23 ` Andy Shevchenko
2022-11-28 1:28 ` Binbin Zhou
2022-11-25 8:54 ` [PATCH V3 3/5] dt-bindings: i2c: add bindings for Loongson LS2X I2C Binbin Zhou
2022-11-27 20:49 ` Krzysztof Kozlowski
2022-11-28 12:24 ` Binbin Zhou
2022-11-28 12:37 ` Krzysztof Kozlowski
2022-11-28 14:15 ` Krzysztof Kozlowski
2022-11-29 13:24 ` Binbin Zhou
2022-11-27 20:50 ` Krzysztof Kozlowski
2022-11-25 8:55 ` [PATCH V3 4/5] i2c: ls2x: Add driver for Loongson-2K/LS7A I2C controller Binbin Zhou
2022-11-25 10:41 ` Andy Shevchenko
2022-11-28 12:03 ` Binbin Zhou
2022-11-28 13:24 ` Andy Shevchenko
2022-11-29 11:34 ` Binbin Zhou
2022-11-29 12:53 ` Andy Shevchenko
2022-11-29 13:19 ` Binbin Zhou
2022-11-25 11:02 ` kernel test robot
2022-11-25 8:55 ` [PATCH V3 5/5] LoongArch: Enable LS2X I2C in loongson3_defconfig Binbin Zhou
2022-11-26 22:25 ` [PATCH V3 3/5] dt-bindings: i2c: add bindings for Loongson LS2X I2C Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abb37a26-1659-4ba0-a621-55fef35f552d@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.