From mboxrd@z Thu Jan 1 00:00:00 1970 From: hdegoede@redhat.com (Hans de Goede) Date: Wed, 18 May 2016 10:13:52 +0200 Subject: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various peripherals In-Reply-To: <1463500571-28970-1-git-send-email-wens@csie.org> References: <1463500571-28970-1-git-send-email-wens@csie.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, On 17-05-16 17:56, Chen-Yu Tsai wrote: > Hi everyone, > > This series enables more peripherals for Allwinner A13-based Q8 devices. > The peripherals include the WiFi, the PMIC's micro-usb power supply > (driver), audio codec (headphone and speaker), and full display support > with the new DRM KMS driver. The series is based on parts of Maxime's > "drm: Add Support for Passive RGB to VGA bridges" series, specifically > the clk and drm fixes, and common DTS bits. > > Hans, since you have a collection of q8 tablets, I'm hoping you could > test these bits and provide some feedback. I've not run any tests, just looked at the patches, the stuff in patch 3 is already present in arch/arm/boot/dts/sun5i-a13-q8-tablet.dts I put it there because I saw some .fex files which don't use ldo3 for wifi I'm fine with moving it to -common though, I believe that you're right that it makes more sense there, having it in 2 places is not really useful though. The other patches look good. Thanks & Regards, Hans > > > Patch 1 is a small fix for part of the init failure path. > > Patch 2 disables ldo5 on the axp209 by default. This regulator output is > muxed with a gpio, and the regulator on/off settings override the gpio. > > Patch 3 enables the USB WiFi module found. > > Patch 4 enables the USB/VBUS power supply of the PMIC. > > Patch 5 enables the audio codec, with support for the speaker amp. > > Patch 6 enables the LCD panel with the display pipeline. > > > Regards > ChenYu > > > Chen-Yu Tsai (6): > drm: sun4i: do cleanup if RGB output init fails > ARM: dts: axp209: Disable ldo5 by default > ARM: dts: sun5i: q8-common: Enable USB-based WiFi > ARM: dts: sun5i: q8-common: Enable USB power supply > ARM: dts: sun5i: q8-common: Enable audio codec > ARM: dts: sun5i: q8-common: Enable display pipeline and LCD display > > arch/arm/boot/dts/axp209.dtsi | 1 + > arch/arm/boot/dts/sun5i-q8-common.dtsi | 62 ++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 +++- > 3 files changed, 68 insertions(+), 1 deletion(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various peripherals Date: Wed, 18 May 2016 10:13:52 +0200 Message-ID: References: <1463500571-28970-1-git-send-email-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1463500571-28970-1-git-send-email-wens@csie.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai , Maxime Ripard , David Airlie Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgQ2hlbi1ZdSwKCk9uIDE3LTA1LTE2IDE3OjU2LCBDaGVuLVl1IFRzYWkgd3JvdGU6Cj4gSGkg ZXZlcnlvbmUsCj4KPiBUaGlzIHNlcmllcyBlbmFibGVzIG1vcmUgcGVyaXBoZXJhbHMgZm9yIEFs bHdpbm5lciBBMTMtYmFzZWQgUTggZGV2aWNlcy4KPiBUaGUgcGVyaXBoZXJhbHMgaW5jbHVkZSB0 aGUgV2lGaSwgdGhlIFBNSUMncyBtaWNyby11c2IgcG93ZXIgc3VwcGx5Cj4gKGRyaXZlciksIGF1 ZGlvIGNvZGVjIChoZWFkcGhvbmUgYW5kIHNwZWFrZXIpLCBhbmQgZnVsbCBkaXNwbGF5IHN1cHBv cnQKPiB3aXRoIHRoZSBuZXcgRFJNIEtNUyBkcml2ZXIuIFRoZSBzZXJpZXMgaXMgYmFzZWQgb24g cGFydHMgb2YgTWF4aW1lJ3MKPiAiZHJtOiBBZGQgU3VwcG9ydCBmb3IgUGFzc2l2ZSBSR0IgdG8g VkdBIGJyaWRnZXMiIHNlcmllcywgc3BlY2lmaWNhbGx5Cj4gdGhlIGNsayBhbmQgZHJtIGZpeGVz LCBhbmQgY29tbW9uIERUUyBiaXRzLgo+Cj4gSGFucywgc2luY2UgeW91IGhhdmUgYSBjb2xsZWN0 aW9uIG9mIHE4IHRhYmxldHMsIEknbSBob3BpbmcgeW91IGNvdWxkCj4gdGVzdCB0aGVzZSBiaXRz IGFuZCBwcm92aWRlIHNvbWUgZmVlZGJhY2suCgpJJ3ZlIG5vdCBydW4gYW55IHRlc3RzLCBqdXN0 IGxvb2tlZCBhdCB0aGUgcGF0Y2hlcywgdGhlIHN0dWZmIGluCnBhdGNoIDMgaXMgYWxyZWFkeSBw cmVzZW50IGluIGFyY2gvYXJtL2Jvb3QvZHRzL3N1bjVpLWExMy1xOC10YWJsZXQuZHRzCkkgcHV0 IGl0IHRoZXJlIGJlY2F1c2UgSSBzYXcgc29tZSAuZmV4IGZpbGVzIHdoaWNoIGRvbid0IHVzZSBs ZG8zIGZvciB3aWZpCkknbSBmaW5lIHdpdGggbW92aW5nIGl0IHRvIC1jb21tb24gdGhvdWdoLCBJ IGJlbGlldmUgdGhhdCB5b3UncmUgcmlnaHQKdGhhdCBpdCBtYWtlcyBtb3JlIHNlbnNlIHRoZXJl LCBoYXZpbmcgaXQgaW4gMiBwbGFjZXMgaXMgbm90IHJlYWxseQp1c2VmdWwgdGhvdWdoLgoKVGhl IG90aGVyIHBhdGNoZXMgbG9vayBnb29kLgoKVGhhbmtzICYgUmVnYXJkcywKCkhhbnMKCgo+Cj4K PiBQYXRjaCAxIGlzIGEgc21hbGwgZml4IGZvciBwYXJ0IG9mIHRoZSBpbml0IGZhaWx1cmUgcGF0 aC4KPgo+IFBhdGNoIDIgZGlzYWJsZXMgbGRvNSBvbiB0aGUgYXhwMjA5IGJ5IGRlZmF1bHQuIFRo aXMgcmVndWxhdG9yIG91dHB1dCBpcwo+IG11eGVkIHdpdGggYSBncGlvLCBhbmQgdGhlIHJlZ3Vs YXRvciBvbi9vZmYgc2V0dGluZ3Mgb3ZlcnJpZGUgdGhlIGdwaW8uCj4KPiBQYXRjaCAzIGVuYWJs ZXMgdGhlIFVTQiBXaUZpIG1vZHVsZSBmb3VuZC4KPgo+IFBhdGNoIDQgZW5hYmxlcyB0aGUgVVNC L1ZCVVMgcG93ZXIgc3VwcGx5IG9mIHRoZSBQTUlDLgo+Cj4gUGF0Y2ggNSBlbmFibGVzIHRoZSBh dWRpbyBjb2RlYywgd2l0aCBzdXBwb3J0IGZvciB0aGUgc3BlYWtlciBhbXAuCj4KPiBQYXRjaCA2 IGVuYWJsZXMgdGhlIExDRCBwYW5lbCB3aXRoIHRoZSBkaXNwbGF5IHBpcGVsaW5lLgo+Cj4KPiBS ZWdhcmRzCj4gQ2hlbll1Cj4KPgo+IENoZW4tWXUgVHNhaSAoNik6Cj4gICBkcm06IHN1bjRpOiBk byBjbGVhbnVwIGlmIFJHQiBvdXRwdXQgaW5pdCBmYWlscwo+ICAgQVJNOiBkdHM6IGF4cDIwOTog RGlzYWJsZSBsZG81IGJ5IGRlZmF1bHQKPiAgIEFSTTogZHRzOiBzdW41aTogcTgtY29tbW9uOiBF bmFibGUgVVNCLWJhc2VkIFdpRmkKPiAgIEFSTTogZHRzOiBzdW41aTogcTgtY29tbW9uOiBFbmFi bGUgVVNCIHBvd2VyIHN1cHBseQo+ICAgQVJNOiBkdHM6IHN1bjVpOiBxOC1jb21tb246IEVuYWJs ZSBhdWRpbyBjb2RlYwo+ICAgQVJNOiBkdHM6IHN1bjVpOiBxOC1jb21tb246IEVuYWJsZSBkaXNw bGF5IHBpcGVsaW5lIGFuZCBMQ0QgZGlzcGxheQo+Cj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2F4cDIw OS5kdHNpICAgICAgICAgIHwgIDEgKwo+ICBhcmNoL2FybS9ib290L2R0cy9zdW41aS1xOC1jb21t b24uZHRzaSB8IDYyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVy cy9ncHUvZHJtL3N1bjRpL3N1bjRpX3Rjb24uYyAgICAgfCAgNiArKystCj4gIDMgZmlsZXMgY2hh bmdlZCwgNjggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751967AbcERIOI (ORCPT ); Wed, 18 May 2016 04:14:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58599 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbcERIOA (ORCPT ); Wed, 18 May 2016 04:14:00 -0400 Subject: Re: [PATCH 0/6] ARM: dts: sun5i: q8-common: Enable various peripherals To: Chen-Yu Tsai , Maxime Ripard , David Airlie References: <1463500571-28970-1-git-send-email-wens@csie.org> Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: Date: Wed, 18 May 2016 10:13:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463500571-28970-1-git-send-email-wens@csie.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 18 May 2016 08:13:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen-Yu, On 17-05-16 17:56, Chen-Yu Tsai wrote: > Hi everyone, > > This series enables more peripherals for Allwinner A13-based Q8 devices. > The peripherals include the WiFi, the PMIC's micro-usb power supply > (driver), audio codec (headphone and speaker), and full display support > with the new DRM KMS driver. The series is based on parts of Maxime's > "drm: Add Support for Passive RGB to VGA bridges" series, specifically > the clk and drm fixes, and common DTS bits. > > Hans, since you have a collection of q8 tablets, I'm hoping you could > test these bits and provide some feedback. I've not run any tests, just looked at the patches, the stuff in patch 3 is already present in arch/arm/boot/dts/sun5i-a13-q8-tablet.dts I put it there because I saw some .fex files which don't use ldo3 for wifi I'm fine with moving it to -common though, I believe that you're right that it makes more sense there, having it in 2 places is not really useful though. The other patches look good. Thanks & Regards, Hans > > > Patch 1 is a small fix for part of the init failure path. > > Patch 2 disables ldo5 on the axp209 by default. This regulator output is > muxed with a gpio, and the regulator on/off settings override the gpio. > > Patch 3 enables the USB WiFi module found. > > Patch 4 enables the USB/VBUS power supply of the PMIC. > > Patch 5 enables the audio codec, with support for the speaker amp. > > Patch 6 enables the LCD panel with the display pipeline. > > > Regards > ChenYu > > > Chen-Yu Tsai (6): > drm: sun4i: do cleanup if RGB output init fails > ARM: dts: axp209: Disable ldo5 by default > ARM: dts: sun5i: q8-common: Enable USB-based WiFi > ARM: dts: sun5i: q8-common: Enable USB power supply > ARM: dts: sun5i: q8-common: Enable audio codec > ARM: dts: sun5i: q8-common: Enable display pipeline and LCD display > > arch/arm/boot/dts/axp209.dtsi | 1 + > arch/arm/boot/dts/sun5i-q8-common.dtsi | 62 ++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/sun4i/sun4i_tcon.c | 6 +++- > 3 files changed, 68 insertions(+), 1 deletion(-) >