From: Paolo Bonzini <pbonzini@redhat.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
rkrcmar@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
joe@perches.com
Subject: Re: [PATCH v2] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()
Date: Mon, 25 Jun 2018 19:01:42 +0200 [thread overview]
Message-ID: <abc2fb26-d94c-09df-dfef-9ae1da558973@redhat.com> (raw)
In-Reply-To: <CAKwvOdmmv9EtPB-jhwVruLASFve5d4h0+wx-6iY=ve=T9hbNdg@mail.gmail.com>
On 25/06/2018 18:47, Nick Desaulniers wrote:
> Here's an actual bug this warning caught applied to drivers/input/:
>
> dae1a432ab1f ("Input: mousedev - fix implicit conversion warning"):
> https://patchwork.kernel.org/patch/9753771/
>
How does the warning catch a bug there? While I do prefer the code
after the patch, wouldn't everything work just fine with "signed char
ps2[6]".
So it seems to me in that case (unlike KVM) the warning caught some ugly
code, but not a bug. (In fact if there was a bug, it should have been
mentioned in the commit message, but it wasn't).
Paolo
next prev parent reply other threads:[~2018-06-25 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 19:25 [PATCH v2] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask() Matthias Kaehlcke
2018-06-25 16:02 ` David Laight
2018-06-25 16:05 ` Paolo Bonzini
2018-06-25 16:47 ` Nick Desaulniers
2018-06-25 17:01 ` Paolo Bonzini [this message]
2018-06-25 17:05 ` Joe Perches
2018-06-25 17:12 ` Nick Desaulniers
2018-06-25 17:34 ` Joe Perches
2018-06-25 17:35 ` Matthias Kaehlcke
2018-06-25 17:50 ` Joe Perches
2018-06-25 19:05 ` Nick Desaulniers
2018-06-26 9:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc2fb26-d94c-09df-dfef-9ae1da558973@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.