From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Unger <tomasz.unger@yahoo.pl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: media: av7110: replace C++ comments with C style comments in sp8870.c
Date: Mon, 16 Mar 2026 11:24:32 +0300 [thread overview]
Message-ID: <abe-QCG4xF1L538e@stanley.mountain> (raw)
In-Reply-To: <20260313-sp8870-cleanup-v2-1-ca679e62f9b7@yahoo.pl>
On Fri, Mar 13, 2026 at 05:32:18PM +0100, Tomasz Unger wrote:
> @@ -490,7 +490,7 @@ static int sp8870_set_frontend(struct dvb_frontend *fe)
> return err;
>
> for (check_count = 0; check_count < MAXCHECKS; check_count++) {
> -// valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0);
> + /* valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0); */
Delete dead code.
> valid = sp8870_read_data_valid_signal(state);
> if (valid) {
> dprintk("delay = %i usec\n", check_count * 10);
prev parent reply other threads:[~2026-03-16 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260313-sp8870-cleanup-v2-1-ca679e62f9b7.ref@yahoo.pl>
2026-03-13 16:32 ` [PATCH v2] staging: media: av7110: replace C++ comments with C style comments in sp8870.c Tomasz Unger
2026-03-13 20:51 ` Ethan Tidmore
2026-03-16 8:24 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe-QCG4xF1L538e@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.